As per spec changes (https://github.com/WICG/feature-policy/blob/gh-pages/features.md) we should add an "autoplay" feature policy feature.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6b3eec088008a5e8bb516acf07d71f4924580720 commit 6b3eec088008a5e8bb516acf07d71f4924580720 Author: Becca Hughes <beccahughes@chromium.org> Date: Thu Nov 30 11:25:21 2017 Feature Policy: Enable "autoplay" feature Add an "autoplay" feature that controls autoplay and delegate activation state through frames. BUG= 788390 Change-Id: Ifeee15cf526d8a27e1b73fa62784e860c73af1ee Reviewed-on: https://chromium-review.googlesource.com/788858 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by: Ian Clelland <iclelland@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#520507} [add] https://crrev.com/6b3eec088008a5e8bb516acf07d71f4924580720/third_party/WebKit/LayoutTests/http/tests/media/autoplay/document-user-activation-cross-origin-feature-policy-delegation.html [add] https://crrev.com/6b3eec088008a5e8bb516acf07d71f4924580720/third_party/WebKit/LayoutTests/http/tests/media/autoplay/document-user-activation-cross-origin-feature-policy-disabled.html [add] https://crrev.com/6b3eec088008a5e8bb516acf07d71f4924580720/third_party/WebKit/LayoutTests/http/tests/media/autoplay/document-user-activation-cross-origin-feature-policy-gesture.html [add] https://crrev.com/6b3eec088008a5e8bb516acf07d71f4924580720/third_party/WebKit/LayoutTests/http/tests/media/autoplay/document-user-activation-cross-origin-feature-policy-header.html [add] https://crrev.com/6b3eec088008a5e8bb516acf07d71f4924580720/third_party/WebKit/LayoutTests/http/tests/media/autoplay/document-user-activation-feature-policy-alternating.html [add] https://crrev.com/6b3eec088008a5e8bb516acf07d71f4924580720/third_party/WebKit/LayoutTests/http/tests/media/autoplay/document-user-activation-feature-policy-iframe-no-gesture.html [add] https://crrev.com/6b3eec088008a5e8bb516acf07d71f4924580720/third_party/WebKit/LayoutTests/http/tests/media/autoplay/document-user-activation-feature-policy-same-origin.html [add] https://crrev.com/6b3eec088008a5e8bb516acf07d71f4924580720/third_party/WebKit/LayoutTests/http/tests/media/autoplay/document-user-activation-iframe-delegation.html [add] https://crrev.com/6b3eec088008a5e8bb516acf07d71f4924580720/third_party/WebKit/LayoutTests/http/tests/media/autoplay/resources/autoplay-test.js [add] https://crrev.com/6b3eec088008a5e8bb516acf07d71f4924580720/third_party/WebKit/LayoutTests/http/tests/media/autoplay/resources/nested-frame-with-header.php [add] https://crrev.com/6b3eec088008a5e8bb516acf07d71f4924580720/third_party/WebKit/LayoutTests/http/tests/media/autoplay/resources/nested-iframe-1a.html [add] https://crrev.com/6b3eec088008a5e8bb516acf07d71f4924580720/third_party/WebKit/LayoutTests/http/tests/media/autoplay/resources/nested-iframe-1b.html [add] https://crrev.com/6b3eec088008a5e8bb516acf07d71f4924580720/third_party/WebKit/LayoutTests/http/tests/media/autoplay/resources/nested-iframe-2.html [add] https://crrev.com/6b3eec088008a5e8bb516acf07d71f4924580720/third_party/WebKit/LayoutTests/http/tests/media/autoplay/resources/test-autoplay-post-navigation.html [modify] https://crrev.com/6b3eec088008a5e8bb516acf07d71f4924580720/third_party/WebKit/LayoutTests/media/autoplay/document-user-activation.html [modify] https://crrev.com/6b3eec088008a5e8bb516acf07d71f4924580720/third_party/WebKit/Source/core/html/media/AutoplayPolicy.cpp [modify] https://crrev.com/6b3eec088008a5e8bb516acf07d71f4924580720/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp [modify] https://crrev.com/6b3eec088008a5e8bb516acf07d71f4924580720/third_party/WebKit/Source/platform/runtime_enabled_features.json5 [modify] https://crrev.com/6b3eec088008a5e8bb516acf07d71f4924580720/third_party/WebKit/common/feature_policy/feature_policy.cc [modify] https://crrev.com/6b3eec088008a5e8bb516acf07d71f4924580720/third_party/WebKit/common/feature_policy/feature_policy_feature.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6652261767269b98b25356a7cde0233d6d33d455 commit 6652261767269b98b25356a7cde0233d6d33d455 Author: Becca Hughes <beccahughes@chromium.org> Date: Thu Nov 30 14:35:19 2017 Feature Policy: Fix flaky tests The tests are being flaky because sometimes playback is failing. This adds a condition so we consider any exception apart from NotAllowedError to count as allowing autoplay. This is because the play() logic will always check autoplay first. BUG= 788390 Change-Id: I8d0ed8bfb48b4d49ba35272e6a06668d6a543a8e Reviewed-on: https://chromium-review.googlesource.com/800590 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#520538} [modify] https://crrev.com/6652261767269b98b25356a7cde0233d6d33d455/third_party/WebKit/LayoutTests/http/tests/media/autoplay/resources/autoplay-test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab8e51588e567d3d50e701857459f9e8cae23d2a commit ab8e51588e567d3d50e701857459f9e8cae23d2a Author: Becca Hughes <beccahughes@chromium.org> Date: Thu Nov 30 15:10:51 2017 Revert "Feature Policy: Fix flaky tests" This reverts commit 6652261767269b98b25356a7cde0233d6d33d455. Reason for revert: Tests are still flaking https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty/36580 Original change's description: > Feature Policy: Fix flaky tests > > The tests are being flaky because sometimes playback is failing. This > adds a condition so we consider any exception apart from NotAllowedError > to count as allowing autoplay. This is because the play() logic will > always check autoplay first. > > BUG= 788390 > > Change-Id: I8d0ed8bfb48b4d49ba35272e6a06668d6a543a8e > Reviewed-on: https://chromium-review.googlesource.com/800590 > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#520538} TBR=mlamouri@chromium.org,beccahughes@chromium.org Change-Id: Icc78bd2eb920247067956a3045920666b375f508 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 788390 Reviewed-on: https://chromium-review.googlesource.com/800770 Reviewed-by: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#520544} [modify] https://crrev.com/ab8e51588e567d3d50e701857459f9e8cae23d2a/third_party/WebKit/LayoutTests/http/tests/media/autoplay/resources/autoplay-test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/593a2a3832f2b85d249e8984660b2ec934b48477 commit 593a2a3832f2b85d249e8984660b2ec934b48477 Author: Becca Hughes <beccahughes@chromium.org> Date: Thu Nov 30 15:12:47 2017 Revert "Feature Policy: Enable "autoplay" feature" This reverts commit 6b3eec088008a5e8bb516acf07d71f4924580720. Reason for revert: Tests are still flaking https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty/36580 Original change's description: > Feature Policy: Enable "autoplay" feature > > Add an "autoplay" feature that controls autoplay and delegate > activation state through frames. > > BUG= 788390 > > Change-Id: Ifeee15cf526d8a27e1b73fa62784e860c73af1ee > Reviewed-on: https://chromium-review.googlesource.com/788858 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Reviewed-by: Ian Clelland <iclelland@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#520507} TBR=mlamouri@chromium.org,skyostil@chromium.org,iclelland@chromium.org,beccahughes@chromium.org Change-Id: I28aaeaa201cd3f0412c263a68c1edc2c508c06d1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 788390 Reviewed-on: https://chromium-review.googlesource.com/800771 Reviewed-by: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#520547} [delete] https://crrev.com/0abf534c10c933af38575329f5fb2270e7829328/third_party/WebKit/LayoutTests/http/tests/media/autoplay/document-user-activation-cross-origin-feature-policy-delegation.html [delete] https://crrev.com/0abf534c10c933af38575329f5fb2270e7829328/third_party/WebKit/LayoutTests/http/tests/media/autoplay/document-user-activation-cross-origin-feature-policy-disabled.html [delete] https://crrev.com/0abf534c10c933af38575329f5fb2270e7829328/third_party/WebKit/LayoutTests/http/tests/media/autoplay/document-user-activation-cross-origin-feature-policy-gesture.html [delete] https://crrev.com/0abf534c10c933af38575329f5fb2270e7829328/third_party/WebKit/LayoutTests/http/tests/media/autoplay/document-user-activation-cross-origin-feature-policy-header.html [delete] https://crrev.com/0abf534c10c933af38575329f5fb2270e7829328/third_party/WebKit/LayoutTests/http/tests/media/autoplay/document-user-activation-feature-policy-alternating.html [delete] https://crrev.com/0abf534c10c933af38575329f5fb2270e7829328/third_party/WebKit/LayoutTests/http/tests/media/autoplay/document-user-activation-feature-policy-iframe-no-gesture.html [delete] https://crrev.com/0abf534c10c933af38575329f5fb2270e7829328/third_party/WebKit/LayoutTests/http/tests/media/autoplay/document-user-activation-feature-policy-same-origin.html [delete] https://crrev.com/0abf534c10c933af38575329f5fb2270e7829328/third_party/WebKit/LayoutTests/http/tests/media/autoplay/document-user-activation-iframe-delegation.html [delete] https://crrev.com/0abf534c10c933af38575329f5fb2270e7829328/third_party/WebKit/LayoutTests/http/tests/media/autoplay/resources/autoplay-test.js [delete] https://crrev.com/0abf534c10c933af38575329f5fb2270e7829328/third_party/WebKit/LayoutTests/http/tests/media/autoplay/resources/nested-frame-with-header.php [delete] https://crrev.com/0abf534c10c933af38575329f5fb2270e7829328/third_party/WebKit/LayoutTests/http/tests/media/autoplay/resources/nested-iframe-1a.html [delete] https://crrev.com/0abf534c10c933af38575329f5fb2270e7829328/third_party/WebKit/LayoutTests/http/tests/media/autoplay/resources/nested-iframe-1b.html [delete] https://crrev.com/0abf534c10c933af38575329f5fb2270e7829328/third_party/WebKit/LayoutTests/http/tests/media/autoplay/resources/nested-iframe-2.html [delete] https://crrev.com/0abf534c10c933af38575329f5fb2270e7829328/third_party/WebKit/LayoutTests/http/tests/media/autoplay/resources/test-autoplay-post-navigation.html [modify] https://crrev.com/593a2a3832f2b85d249e8984660b2ec934b48477/third_party/WebKit/LayoutTests/media/autoplay/document-user-activation.html [modify] https://crrev.com/593a2a3832f2b85d249e8984660b2ec934b48477/third_party/WebKit/Source/core/html/media/AutoplayPolicy.cpp [modify] https://crrev.com/593a2a3832f2b85d249e8984660b2ec934b48477/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp [modify] https://crrev.com/593a2a3832f2b85d249e8984660b2ec934b48477/third_party/WebKit/Source/platform/runtime_enabled_features.json5 [modify] https://crrev.com/593a2a3832f2b85d249e8984660b2ec934b48477/third_party/WebKit/common/feature_policy/feature_policy.cc [modify] https://crrev.com/593a2a3832f2b85d249e8984660b2ec934b48477/third_party/WebKit/common/feature_policy/feature_policy_feature.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02610543b96be59539144855a42adc0030212be9 commit 02610543b96be59539144855a42adc0030212be9 Author: Becca Hughes <beccahughes@chromium.org> Date: Thu Nov 30 17:34:27 2017 Reland: Feature Policy: Enable "autoplay" feature Add an "autoplay" feature that controls autoplay and delegate activation state through frames. BUG= 788390 TBR=skyostil@chromium.org,iclelland@chromium.org Change-Id: I67e40ae00b0ca7acad7bbef4b4cb4525a9e65fb3 Reviewed-on: https://chromium-review.googlesource.com/800851 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#520589} [modify] https://crrev.com/02610543b96be59539144855a42adc0030212be9/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/02610543b96be59539144855a42adc0030212be9/third_party/WebKit/LayoutTests/http/tests/media/autoplay/document-user-activation-cross-origin-feature-policy-delegation.html [add] https://crrev.com/02610543b96be59539144855a42adc0030212be9/third_party/WebKit/LayoutTests/http/tests/media/autoplay/document-user-activation-cross-origin-feature-policy-disabled.html [add] https://crrev.com/02610543b96be59539144855a42adc0030212be9/third_party/WebKit/LayoutTests/http/tests/media/autoplay/document-user-activation-cross-origin-feature-policy-gesture.html [add] https://crrev.com/02610543b96be59539144855a42adc0030212be9/third_party/WebKit/LayoutTests/http/tests/media/autoplay/document-user-activation-cross-origin-feature-policy-header.html [add] https://crrev.com/02610543b96be59539144855a42adc0030212be9/third_party/WebKit/LayoutTests/http/tests/media/autoplay/document-user-activation-feature-policy-alternating.html [add] https://crrev.com/02610543b96be59539144855a42adc0030212be9/third_party/WebKit/LayoutTests/http/tests/media/autoplay/document-user-activation-feature-policy-iframe-no-gesture.html [add] https://crrev.com/02610543b96be59539144855a42adc0030212be9/third_party/WebKit/LayoutTests/http/tests/media/autoplay/document-user-activation-feature-policy-same-origin.html [add] https://crrev.com/02610543b96be59539144855a42adc0030212be9/third_party/WebKit/LayoutTests/http/tests/media/autoplay/document-user-activation-iframe-delegation.html [add] https://crrev.com/02610543b96be59539144855a42adc0030212be9/third_party/WebKit/LayoutTests/http/tests/media/autoplay/resources/autoplay-test.js [add] https://crrev.com/02610543b96be59539144855a42adc0030212be9/third_party/WebKit/LayoutTests/http/tests/media/autoplay/resources/nested-frame-with-header.php [add] https://crrev.com/02610543b96be59539144855a42adc0030212be9/third_party/WebKit/LayoutTests/http/tests/media/autoplay/resources/nested-iframe-1a.html [add] https://crrev.com/02610543b96be59539144855a42adc0030212be9/third_party/WebKit/LayoutTests/http/tests/media/autoplay/resources/nested-iframe-1b.html [add] https://crrev.com/02610543b96be59539144855a42adc0030212be9/third_party/WebKit/LayoutTests/http/tests/media/autoplay/resources/nested-iframe-2.html [add] https://crrev.com/02610543b96be59539144855a42adc0030212be9/third_party/WebKit/LayoutTests/http/tests/media/autoplay/resources/test-autoplay-post-navigation.html [modify] https://crrev.com/02610543b96be59539144855a42adc0030212be9/third_party/WebKit/LayoutTests/media/autoplay/document-user-activation.html [modify] https://crrev.com/02610543b96be59539144855a42adc0030212be9/third_party/WebKit/Source/core/html/media/AutoplayPolicy.cpp [modify] https://crrev.com/02610543b96be59539144855a42adc0030212be9/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp [modify] https://crrev.com/02610543b96be59539144855a42adc0030212be9/third_party/WebKit/Source/platform/runtime_enabled_features.json5 [modify] https://crrev.com/02610543b96be59539144855a42adc0030212be9/third_party/WebKit/common/feature_policy/feature_policy.cc [modify] https://crrev.com/02610543b96be59539144855a42adc0030212be9/third_party/WebKit/common/feature_policy/feature_policy_feature.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7e8185c83d1757da4c35a889843dd1905b0aca5 commit a7e8185c83d1757da4c35a889843dd1905b0aca5 Author: Avi Drissman <avi@chromium.org> Date: Thu Nov 30 19:50:22 2017 Disable failing layout tests. BUG= 790549 , 788390 TBR=beccahughes NOTRY=true Change-Id: I4046eb8ca85c48ba0ec851a14700ace62deca5c0 Reviewed-on: https://chromium-review.googlesource.com/801656 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#520647} [modify] https://crrev.com/a7e8185c83d1757da4c35a889843dd1905b0aca5/third_party/WebKit/LayoutTests/TestExpectations
The CL landed in comment 6 has caused the Site Isolation Windows FYI bot to start failing. The some of tests are timing out: https://ci.chromium.org/buildbot/chromium.fyi/Site%20Isolation%20Win/21540.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c24e209f2e51c91379a5ec7ffda462a93a26782c commit c24e209f2e51c91379a5ec7ffda462a93a26782c Author: Nasko Oskov <nasko@chromium.org> Date: Fri Dec 01 21:43:04 2017 Disable failing autoplay feature policy layout tests. This CL disables tests failing on the Site Isolation Win FYI bot until they can be investigated and fixed. Bug: 788390 Change-Id: Ie51cd7dc3fe3559da7e2e3eec8ad9ca19169d794 Reviewed-on: https://chromium-review.googlesource.com/804146 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#521070} [modify] https://crrev.com/c24e209f2e51c91379a5ec7ffda462a93a26782c/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process
For site isolation tests it looks like everything is working correctly in feature policy / autoplay policy so this is most likely something in the tests.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/15a5eb566216dc0affec9523d41af91926347eba commit 15a5eb566216dc0affec9523d41af91926347eba Author: Becca Hughes <beccahughes@chromium.org> Date: Wed Dec 13 11:52:27 2017 Feature Policy: Add WPT tests for autoplay Add web platform tests for the new autoplay feature. BUG= 788390 Change-Id: I621ddd4f70b6882d837397b3f2f464c99253af13 Reviewed-on: https://chromium-review.googlesource.com/806535 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Ian Clelland <iclelland@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#523746} [modify] https://crrev.com/15a5eb566216dc0affec9523d41af91926347eba/content/shell/app/shell_main_delegate.cc [modify] https://crrev.com/15a5eb566216dc0affec9523d41af91926347eba/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/15a5eb566216dc0affec9523d41af91926347eba/third_party/WebKit/LayoutTests/VirtualTestSuites [add] https://crrev.com/15a5eb566216dc0affec9523d41af91926347eba/third_party/WebKit/LayoutTests/external/wpt/feature-policy/autoplay-allowed-by-feature-policy-attribute-redirect-on-load.https.sub.html [add] https://crrev.com/15a5eb566216dc0affec9523d41af91926347eba/third_party/WebKit/LayoutTests/external/wpt/feature-policy/autoplay-allowed-by-feature-policy-attribute.https.sub.html [add] https://crrev.com/15a5eb566216dc0affec9523d41af91926347eba/third_party/WebKit/LayoutTests/external/wpt/feature-policy/autoplay-allowed-by-feature-policy.https.sub.html [add] https://crrev.com/15a5eb566216dc0affec9523d41af91926347eba/third_party/WebKit/LayoutTests/external/wpt/feature-policy/autoplay-allowed-by-feature-policy.https.sub.html.headers [add] https://crrev.com/15a5eb566216dc0affec9523d41af91926347eba/third_party/WebKit/LayoutTests/external/wpt/feature-policy/autoplay-default-feature-policy.https.sub.html [add] https://crrev.com/15a5eb566216dc0affec9523d41af91926347eba/third_party/WebKit/LayoutTests/external/wpt/feature-policy/autoplay-disabled-by-feature-policy.https.sub.html [add] https://crrev.com/15a5eb566216dc0affec9523d41af91926347eba/third_party/WebKit/LayoutTests/external/wpt/feature-policy/autoplay-disabled-by-feature-policy.https.sub.html.headers [modify] https://crrev.com/15a5eb566216dc0affec9523d41af91926347eba/third_party/WebKit/LayoutTests/external/wpt/feature-policy/payment-allowed-by-feature-policy-attribute-redirect-on-load.https.sub.html [add] https://crrev.com/15a5eb566216dc0affec9523d41af91926347eba/third_party/WebKit/LayoutTests/external/wpt/feature-policy/resources/autoplay.js [add] https://crrev.com/15a5eb566216dc0affec9523d41af91926347eba/third_party/WebKit/LayoutTests/external/wpt/feature-policy/resources/feature-policy-autoplay.html [add] https://crrev.com/15a5eb566216dc0affec9523d41af91926347eba/third_party/WebKit/LayoutTests/virtual/unified-autoplay/external/wpt/feature-policy/README.txt
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/64e4aa7223ee1ebef7874515aaf30b7e64c24f50 commit 64e4aa7223ee1ebef7874515aaf30b7e64c24f50 Author: Becca Hughes <beccahughes@chromium.org> Date: Tue Dec 19 09:53:31 2017 Feature Policy: Launch autoplay attribute to stable The intent to ship has 3x LGTM so this marks the FeaturePolicyAutoplayFeature as stable. Intent to Ship: https://groups.google.com/a/chromium.org/forum/?hl=en#!topic/blink-dev/sufZCxRTvXk BUG= 788390 Change-Id: I59c583f01485c3358a5b226d6e4254c41479b62c Reviewed-on: https://chromium-review.googlesource.com/831520 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#524986} [modify] https://crrev.com/64e4aa7223ee1ebef7874515aaf30b7e64c24f50/third_party/WebKit/Source/platform/runtime_enabled_features.json5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d707c20476717b074f94584f90ddbefa05ad0d02 commit d707c20476717b074f94584f90ddbefa05ad0d02 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Mar 08 00:20:03 2018 Remove site-per-process expectations already covered by TestExpectations. This CL tries to remove test expectations from LayoutTests/FlagExpectations/site-per-process if they are already covered by expectations in LayoutTests/TestExpectations Bug: 477150, 711468 , 788390 Change-Id: I89b0838d7fc3dbdbb536d542baf2d3e5e31b6faf Reviewed-on: https://chromium-review.googlesource.com/953222 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Nick Carter <nick@chromium.org> Cr-Commit-Position: refs/heads/master@{#541649} [modify] https://crrev.com/d707c20476717b074f94584f90ddbefa05ad0d02/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47893d3f6778b0e5c94afeb245af6579c5647e06 commit 47893d3f6778b0e5c94afeb245af6579c5647e06 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Mar 08 17:46:16 2018 Re-add h/t/m/autoplay/document-user-activation expectation for Win-only. It turns out that some tests that have been removed from FlagExpectations/site-per-process in r541649 are still failing on the Site Isolation Win bot. This CL re-adds these test expectations, but makes them Windows-only. Bug: 788390 Change-Id: Ie09e0a66221e14734f7705b364e18ca204e1f308 Reviewed-on: https://chromium-review.googlesource.com/955962 Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#541828} [modify] https://crrev.com/47893d3f6778b0e5c94afeb245af6579c5647e06/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2189fb4fdc2b667a6154680235757558565863fd commit 2189fb4fdc2b667a6154680235757558565863fd Author: Luna Lu <loonybear@chromium.org> Date: Mon Mar 12 19:23:14 2018 Mark http/tests/media/autoplay/document-user-activation-cross-origin-feature-policy-gesture.html flaky on Mac Bug: 788390 Change-Id: I2216e1c17ef9b4431d361180fe7a0d998dd807aa Reviewed-on: https://chromium-review.googlesource.com/959385 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#542561} [modify] https://crrev.com/2189fb4fdc2b667a6154680235757558565863fd/third_party/WebKit/LayoutTests/TestExpectations
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/961c6c6cc919c92c4a8e4c51656646730c2a344c commit 961c6c6cc919c92c4a8e4c51656646730c2a344c Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Mon Mar 12 21:24:17 2018 Triaging layout test failures from FlagExpectations/site-per-process http/tests/devtools/appcache/appcache-iframe-manifests.js: - This test was associated with crbug.com/678481 and that bug is now fixed, and the test-related expectation has already been removed from LayoutTests/TestExpectations in r527386 http/tests/media/autoplay/document-user-activation-* - These tests are flaky regardless of site-per-process and are already covered by LayoutTests/TestExpectations. This CL just extends TestExpectations entry to also cover Win. external/wpt/payment-request/allowpaymentrequest/setting-allowpaymentrequest-timing.https.sub.html - New bug has been opened prior to this CL: https://crbug.com/819800 external/wpt/fullscreen/api/element-ready-check* - New bug has been opened prior to this CL: https://crbug.com/820617 external/wpt/css/css-fonts/font-display/font-display.html - This test is simply slow and often takes more than 5 seconds to finish - see https://crbug.com/816026#c7 - The timeout of this test is (since 2018-03-12) covered by the main LayoutTests/TestExpectations (see r542490). Other entries removed by this CL simply seem to have "healed" themselves and are currently passing on the waterfall and on the tryjobs. Bug: 477150, 794631 , 678481, 788390 Bug: 819800, 820617 , 788390 , 801992 Change-Id: If24ec321df9593ab217f50b7f1b39b3496faceef Reviewed-on: https://chromium-review.googlesource.com/957683 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#542601} [modify] https://crrev.com/961c6c6cc919c92c4a8e4c51656646730c2a344c/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process [modify] https://crrev.com/961c6c6cc919c92c4a8e4c51656646730c2a344c/third_party/WebKit/LayoutTests/TestExpectations
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2719d34c8fd57945ca47388060845499f5b3358f commit 2719d34c8fd57945ca47388060845499f5b3358f Author: Eric Willigers <ericwilligers@chromium.org> Date: Fri Aug 10 00:04:31 2018 Retire FeaturePolicyAutoplayFeature flag. Shipped in M64, this feature allows developers to selectively enable and disable use of autoplay through the feature policy HTTP header or the <iframe> "allow" attribute. https://chromium-review.googlesource.com/831520 https://www.chromestatus.com/features/5100524789563392 BUG= 788390 Change-Id: I0f4346bc75dc922c8004f0008921d68a5a3beede Reviewed-on: https://chromium-review.googlesource.com/1166614 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#581968} [modify] https://crrev.com/2719d34c8fd57945ca47388060845499f5b3358f/third_party/blink/renderer/core/html/media/autoplay_policy.cc [modify] https://crrev.com/2719d34c8fd57945ca47388060845499f5b3358f/third_party/blink/renderer/platform/feature_policy/feature_policy.cc [modify] https://crrev.com/2719d34c8fd57945ca47388060845499f5b3358f/third_party/blink/renderer/platform/runtime_enabled_features.json5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c38ef864f85f84f7d356d5b76b7d60322e663dd0 commit c38ef864f85f84f7d356d5b76b7d60322e663dd0 Author: Eric Willigers <ericwilligers@chromium.org> Date: Thu Aug 16 21:51:10 2018 Feature Policy: update virtual test flags FeaturePolicyForPermissions has been retired from runtime enabled features. We don't need to mention it in VirtualTestSuites. BUG= 788390 Change-Id: I22e05513852fcc17c2eea514fd5c54b3c0051b37 Reviewed-on: https://chromium-review.googlesource.com/1176882 Reviewed-by: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#583832} [modify] https://crrev.com/c38ef864f85f84f7d356d5b76b7d60322e663dd0/third_party/WebKit/LayoutTests/VirtualTestSuites
Comment 1 by beccahughes@chromium.org
, Nov 29 2017Summary: Launch autoplay feature policy (was: Autoplay should be controllable by feature policy)