For now the history popup is using frame to position itself. It should use named layout guide. Assigning to sczs@ as owner.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/470c50fcfc81c93f1a028e31840a97e05896519e commit 470c50fcfc81c93f1a028e31840a97e05896519e Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Dec 21 07:55:29 2017 Use LayoutGuide instead of frame for history popup This CL changes the history popup such as it is now using named layout guide instead of asking for the frame of the buttons. This is only enabled for the CleanToolbar as the old toolbar is not using autolayout. Bug: 788368 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib1777393ba0038044a691cd89772191ee5d434ed Reviewed-on: https://chromium-review.googlesource.com/836596 Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#525641} [modify] https://crrev.com/470c50fcfc81c93f1a028e31840a97e05896519e/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/470c50fcfc81c93f1a028e31840a97e05896519e/ios/chrome/browser/ui/history_popup/BUILD.gn [modify] https://crrev.com/470c50fcfc81c93f1a028e31840a97e05896519e/ios/chrome/browser/ui/history_popup/requirements/tab_history_positioner.h [modify] https://crrev.com/470c50fcfc81c93f1a028e31840a97e05896519e/ios/chrome/browser/ui/history_popup/tab_history_legacy_coordinator.mm [modify] https://crrev.com/470c50fcfc81c93f1a028e31840a97e05896519e/ios/chrome/browser/ui/toolbar/clean/toolbar_view_controller.mm [modify] https://crrev.com/470c50fcfc81c93f1a028e31840a97e05896519e/ios/chrome/browser/ui/util/named_guide.h [modify] https://crrev.com/470c50fcfc81c93f1a028e31840a97e05896519e/ios/chrome/browser/ui/util/named_guide.mm
Comment 1 by gambard@chromium.org
, Dec 20 2017Owner: gambard@chromium.org
Status: Started (was: Assigned)