New issue
Advanced search Search tips

Issue 788343 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocking:
issue 777555



Sign in to add a comment

Undefined-shift in ff_vorbis_len2vlc

Project Member Reported by ClusterFuzz, Nov 24 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6072411006173184

Fuzzer: libFuzzer_mediasource_WEBM_VORBIS_pipeline_integration_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Undefined-shift
Crash Address: 
Crash State:
  ff_vorbis_len2vlc
  vorbis_parse_setup_hdr_codebooks
  vorbis_parse_setup_hdr
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=499820:499882

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6072411006173184

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Nov 24 2017

Labels: Test-Predator-Auto-Owner
Owner: wolenetz@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/2ad785825859b6be6964d484a1d6a5f3f2c2ded5 (MSE: Expand pipeline integration fuzzer mimetype/codec coverage).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.
Cc: wolenetz@chromium.org
Components: Internals>Media>FFmpeg
Owner: dalecur...@chromium.org
=> Dale, this looks like an FFmpeg issue.
Blocking: 777555
Fix landed, rolling DEPS now, so tagging with M64 roll.
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/776821ccf8de3b55a216aa6db9735c4904d74afa

commit 776821ccf8de3b55a216aa6db9735c4904d74afa
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Thu Nov 30 21:44:19 2017

Roll src/third_party/ffmpeg/ 18c815f81..23e0b491f (1 commit)

https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/18c815f81428..23e0b491fa58

$ git log 18c815f81..23e0b491f --date=short --no-merges --format='%ad %ae %s'
2017-11-30 dalecurtis Fix another 1 << 31 > int32_t::max() with 1u.

Created with:
  roll-dep src/third_party/ffmpeg

BUG= 788343 
TEST=no more ubsan issue.
TBR=sandersd

Change-Id: I3511f4b657a56251812fec25a4c792578598e676
Reviewed-on: https://chromium-review.googlesource.com/801352
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520703}
[modify] https://crrev.com/776821ccf8de3b55a216aa6db9735c4904d74afa/DEPS

Status: Fixed (was: Assigned)
Project Member

Comment 6 by ClusterFuzz, Dec 1 2017

ClusterFuzz has detected this issue as fixed in range 520665:520708.

Detailed report: https://clusterfuzz.com/testcase?key=6072411006173184

Fuzzer: libFuzzer_mediasource_WEBM_VORBIS_pipeline_integration_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Undefined-shift
Crash Address: 
Crash State:
  ff_vorbis_len2vlc
  vorbis_parse_setup_hdr_codebooks
  vorbis_parse_setup_hdr
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=499820:499882
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=520665:520708

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6072411006173184

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Dec 1 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 6072411006173184 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment