New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 788342 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature



Sign in to add a comment

Apply the modern layout to the NTP

Project Member Reported by mvanouwe...@chromium.org, Nov 24 2017

Issue description

Apply the modern layout to the NTP. This will allow us to unfork much of our UI code and reduce complexity.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cdbbe333526281ee4997e31ee5aed0e858e8c0ce

commit cdbbe333526281ee4997e31ee5aed0e858e8c0ce
Author: Michael van Ouwerkerk <mvanouwerkerk@google.com>
Date: Fri Nov 24 15:07:06 2017

Apply the modern layout to the NTP.

These are visual changes in color, spacing, and position.
This change does not affect what data is shown, e.g. the
NTP will continue to show the "Recent bookmarks" and
"Downloads" sections.

Screenshots: http://shortn/_0SU7JgKkfU
9patch asset masters: http://shortn/_zUTmPSJknm

Bug:  788342 
Change-Id: I4290f4c12a2e4fe9803496620af48f9b273023e3
Reviewed-on: https://chromium-review.googlesource.com/788371
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519114}
[add] https://crrev.com/cdbbe333526281ee4997e31ee5aed0e858e8c0ce/chrome/android/java/res/drawable-hdpi/card_modern.9.png
[add] https://crrev.com/cdbbe333526281ee4997e31ee5aed0e858e8c0ce/chrome/android/java/res/drawable-mdpi/card_modern.9.png
[add] https://crrev.com/cdbbe333526281ee4997e31ee5aed0e858e8c0ce/chrome/android/java/res/drawable-xhdpi/card_modern.9.png
[add] https://crrev.com/cdbbe333526281ee4997e31ee5aed0e858e8c0ce/chrome/android/java/res/drawable-xxhdpi/card_modern.9.png
[add] https://crrev.com/cdbbe333526281ee4997e31ee5aed0e858e8c0ce/chrome/android/java/res/drawable-xxxhdpi/card_modern.9.png
[modify] https://crrev.com/cdbbe333526281ee4997e31ee5aed0e858e8c0ce/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/cdbbe333526281ee4997e31ee5aed0e858e8c0ce/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
[modify] https://crrev.com/cdbbe333526281ee4997e31ee5aed0e858e8c0ce/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java
[modify] https://crrev.com/cdbbe333526281ee4997e31ee5aed0e858e8c0ce/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/AllDismissedItem.java
[modify] https://crrev.com/cdbbe333526281ee4997e31ee5aed0e858e8c0ce/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java
[modify] https://crrev.com/cdbbe333526281ee4997e31ee5aed0e858e8c0ce/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/Footer.java
[modify] https://crrev.com/cdbbe333526281ee4997e31ee5aed0e858e8c0ce/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
[modify] https://crrev.com/cdbbe333526281ee4997e31ee5aed0e858e8c0ce/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java
[modify] https://crrev.com/cdbbe333526281ee4997e31ee5aed0e858e8c0ce/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusCardViewHolder.java
[modify] https://crrev.com/cdbbe333526281ee4997e31ee5aed0e858e8c0ce/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
[modify] https://crrev.com/cdbbe333526281ee4997e31ee5aed0e858e8c0ce/chrome/android/java/src/org/chromium/chrome/browser/suggestions/ContextualSuggestionsCardViewHolder.java
[modify] https://crrev.com/cdbbe333526281ee4997e31ee5aed0e858e8c0ce/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SiteSection.java
[modify] https://crrev.com/cdbbe333526281ee4997e31ee5aed0e858e8c0ce/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBinder.java
[modify] https://crrev.com/cdbbe333526281ee4997e31ee5aed0e858e8c0ce/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsConfig.java
[modify] https://crrev.com/cdbbe333526281ee4997e31ee5aed0e858e8c0ce/chrome/android/java/src/org/chromium/chrome/browser/suggestions/ThumbnailGradient.java
[modify] https://crrev.com/cdbbe333526281ee4997e31ee5aed0e858e8c0ce/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGridLayout.java
[modify] https://crrev.com/cdbbe333526281ee4997e31ee5aed0e858e8c0ce/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGridViewHolder.java
[modify] https://crrev.com/cdbbe333526281ee4997e31ee5aed0e858e8c0ce/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileView.java
[modify] https://crrev.com/cdbbe333526281ee4997e31ee5aed0e858e8c0ce/chrome/android/junit/src/org/chromium/chrome/browser/suggestions/TileGroupUnitTest.java
[modify] https://crrev.com/cdbbe333526281ee4997e31ee5aed0e858e8c0ce/chrome/browser/about_flags.cc
[modify] https://crrev.com/cdbbe333526281ee4997e31ee5aed0e858e8c0ce/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/cdbbe333526281ee4997e31ee5aed0e858e8c0ce/chrome/browser/android/chrome_feature_list.h
[modify] https://crrev.com/cdbbe333526281ee4997e31ee5aed0e858e8c0ce/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/cdbbe333526281ee4997e31ee5aed0e858e8c0ce/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/cdbbe333526281ee4997e31ee5aed0e858e8c0ce/tools/metrics/histograms/enums.xml

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f97a0aa60c2087ecb0791dcdb805ea013079446

commit 1f97a0aa60c2087ecb0791dcdb805ea013079446
Author: Michael van Ouwerkerk <mvanouwerkerk@google.com>
Date: Fri Nov 24 18:36:55 2017

Parameterize NewTabPageUiCaptureTest for Modern.

Screenshots: http://shortn/_L9D5ADvIbF

Bug:  788342 
Change-Id: I5a2658ee764c09069c008a685b3647be450f649e
Reviewed-on: https://chromium-review.googlesource.com/789011
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519146}
[modify] https://crrev.com/1f97a0aa60c2087ecb0791dcdb805ea013079446/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageUiCaptureTest.java

Status: Fixed (was: Started)

Sign in to add a comment