New issue
Advanced search Search tips

Issue 788341 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

3.9% regression in memory.top_10_mobile at 518547:518625

Project Member Reported by hjd@google.com, Nov 24 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Nov 24 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=788341

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=b2d10385ab1e1768a0f0b5507fb23aa083e8ff7d7559a44db232fee983299491


Bot(s) for this bug's original alert(s):

android-nexus5
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Nov 24 2017

Cc: bbudge@chromium.org
Owner: bbudge@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author bbudge@chromium.org ===

Hi bbudge@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Bill Budge
  Commit : 0481b23e2562fcb001494de3765a3ef61427fd00
  Date   : Tue Nov 21 16:48:55 2017
  Subject: [Memory] Rewrite platform OS Commit / Uncommit in terms of permissions.

Bisect Details
  Configuration: android_nexus5_perf_bisect
  Benchmark    : memory.top_10_mobile
  Metric       : memory:chrome:all_processes:reported_by_os:system_memory:proportional_resident_size_avg/foreground/http_en_m_wikipedia_org_wiki_Science
  Change       : 4.31% | 98507618.0 -> 102749196.0

Revision                           Result                    N
chromium@518546                    98507618 +- 251909        6      good
chromium@518566                    98813452 +- 573147        6      good
chromium@518571                    98879003 +- 593072        6      good
chromium@518573                    98919793 +- 306613        6      good
chromium@518573,v8@a8df8f38a1      98574177 +- 769036        6      good
chromium@518573,v8@8036c41f1e      98664972 +- 483167        6      good
chromium@518573,v8@0481b23e25      102855024 +- 1114708      6      bad       <--
chromium@518574                    102945619 +- 725813       6      bad
chromium@518576                    102976539 +- 805049       6      bad
chromium@518585                    102833491 +- 1149400      6      bad
chromium@518625                    102749196 +- 631247       6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http.en.m.wikipedia.org.wiki.Science memory.top_10_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8962047596997804880


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Nov 24 2017

 Issue 788179  has been merged into this issue.
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Nov 24 2017

 Issue 788399  has been merged into this issue.

Comment 6 by bbudge@chromium.org, Nov 24 2017

Status: Started (was: Assigned)
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Nov 25 2017

Issue 788358 has been merged into this issue.
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Nov 25 2017

Issue 788349 has been merged into this issue.
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Nov 26 2017

 Issue 788364  has been merged into this issue.
Project Member

Comment 10 by 42576172...@developer.gserviceaccount.com, Nov 28 2017

Issue 788790 has been merged into this issue.
Project Member

Comment 11 by 42576172...@developer.gserviceaccount.com, Nov 28 2017

Issue 788790 has been merged into this issue.
Project Member

Comment 12 by 42576172...@developer.gserviceaccount.com, Nov 28 2017

Issue 788790 has been merged into this issue.
Project Member

Comment 13 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/2cbfa2444d6192b472f02cab2c0f25b9df6145fb

commit 2cbfa2444d6192b472f02cab2c0f25b9df6145fb
Author: Bill Budge <bbudge@chromium.org>
Date: Tue Nov 28 17:08:36 2017

[Memory] Use madvise on POSIX to allow OS to reclaim memory.

- Use madvise when setting no permissions on memory.
- Move platform specific mmap flag calculations to a helper fn.

Bug:  chromium:756050 , chromium:788341 
Change-Id: I7d420a0abee9656a57fb0317301322da2fd7d7b5
Reviewed-on: https://chromium-review.googlesource.com/790932
Commit-Queue: Bill Budge <bbudge@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49681}
[modify] https://crrev.com/2cbfa2444d6192b472f02cab2c0f25b9df6145fb/src/base/platform/platform-posix.cc
[modify] https://crrev.com/2cbfa2444d6192b472f02cab2c0f25b9df6145fb/src/base/platform/platform.h

Project Member

Comment 14 by 42576172...@developer.gserviceaccount.com, Nov 28 2017

Issue 788790 has been merged into this issue.
Project Member

Comment 15 by 42576172...@developer.gserviceaccount.com, Nov 29 2017

Issue 788790 has been merged into this issue.
Project Member

Comment 16 by 42576172...@developer.gserviceaccount.com, Nov 30 2017

Cc: wolenetz@chromium.org
 Issue 789710  has been merged into this issue.
Status: Fixed (was: Started)
All perf graphs seem to have recovered to normal levels.
Project Member

Comment 18 by bugdroid1@chromium.org, Dec 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/3c5cb5e5c77b9aed4e0cb5a9bce14c381af26699

commit 3c5cb5e5c77b9aed4e0cb5a9bce14c381af26699
Author: John Barboza <jbarboza@ca.ibm.com>
Date: Fri Dec 08 14:21:50 2017

AIX: [Memory] Use madvise on POSIX to allow OS to reclaim memory.

Port 2cbfa2444d6192b472f02cab2c0f25b9df6145fb

Original Commit Message:

  [Memory] Use madvise on POSIX to allow OS to reclaim memory.

  - Use madvise when setting no permissions on memory.
  - Move platform specific mmap flag calculations to a helper fn.

  Bug:  chromium:756050 , chromium:788341 
  Change-Id: I7d420a0abee9656a57fb0317301322da2fd7d7b5
  Reviewed-on: https://chromium-review.googlesource.com/790932


Change-Id: I5f7957066d0be96bd429b3d55c9293ffb996750c
Reviewed-on: https://chromium-review.googlesource.com/804554
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49961}
[modify] https://crrev.com/3c5cb5e5c77b9aed4e0cb5a9bce14c381af26699/src/base/platform/platform-posix.cc

Sign in to add a comment