New issue
Advanced search Search tips

Issue 788337 link

Starred by 1 user
Status: Fixed
Owner:
mstensho@chromium.org
Closed: Dec 2017
Cc:
mstensho@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

31 css-multicol tests in web-platform-tests are failing

Project Member Reported by foolip@chromium.org, Nov 24 2017 
This is a bug to link in TestExpectations, as I'm importing the multicol tests from web-platform-tests and there will be some initially failing.

https://wpt.fyi/css/css-multicol is a useful guide for which of these failures are likely to be incorrect tests (failing everywhere) and which maybe are actual bugs (passing in some other browser).
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44906581b49621ee2d7be6ef9a3f575db4dca331

commit 44906581b49621ee2d7be6ef9a3f575db4dca331
Author: Philip Jägenstedt <foolip@chromium.org>
Date: Fri Nov 24 14:42:10 2017

Import css-break and css-multicol from web-platform-tests

For css-multicol, there are 145 new tests, out of which 31 are
failing. To check that these tests aren't duplicates, the tests in
fast/multicol/ and ietestcenter/css3/multicolumn/ were deleted in a
temporary commit and git diff --diff-filter=R used to look for what
would look like "renames", but nothing was found.

css-break actually has no tests, but ones could be added.

Imported from wpt@6e1df92d1080ef918244785e259bc3f4507cd88a using
wpt-import in Chromium a9c44f5f2f304e531aaad15b16eb6618120fbef9.

Bug:  788337 
Change-Id: Ia24553c214c2369c4db85288cf3cc6698f092fdc
No-Export: true
Reviewed-on: https://chromium-review.googlesource.com/788871
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519111}
[modify] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/W3CImportExpectations
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-break/OWNERS
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-break/break-before-always-001.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/OWNERS
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-basic-001.html
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-basic-002.html
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-basic-003.html
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-basic-004.html
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-basic-005.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-basic-006.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-basic-007.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-basic-008.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-block-no-clip-001-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-block-no-clip-001.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-block-no-clip-002-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-block-no-clip-002.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-br-inside-avoidcolumn-001.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-br-inside-avoidcolumn-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-break-000-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-break-000.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-break-001-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-break-001.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-clip-001-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-clip-001.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-clip-002-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-clip-002.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-collapsing-001-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-collapsing-001.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-columns-001-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-columns-001.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-columns-002.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-columns-003.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-columns-004.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-columns-005.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-columns-006.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-columns-007.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-columns-invalid-001-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-columns-invalid-001.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-columns-invalid-002.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-columns-toolong-001.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-containing-001-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-containing-001.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-containing-002-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-containing-002.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-count-001.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-count-002-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-count-002.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-count-computed-001.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-count-computed-002.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-count-computed-003-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-count-computed-003.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-count-computed-004-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-count-computed-004.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-count-computed-005.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-count-computed-2-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-count-computed-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-count-large-001.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-count-large-002.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-count-large-2-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-count-large-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-count-negative-001.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-count-negative-002.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-count-non-integer-001.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-count-non-integer-002.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-count-non-integer-003.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-fill-000-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-fill-000.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-fill-001-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-fill-001.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-fill-auto-001-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-fill-auto-001.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-fill-auto-002-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-fill-auto-002.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-fill-auto-003-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-fill-auto-003.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-fill-auto-block-children-001.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-fill-auto-block-children-002-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-fill-auto-block-children-002.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-fill-auto-block-children-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-fill-auto-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-fill-auto.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-fill-balance-001-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-fill-balance-001.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-fill-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-gap-000-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-gap-000.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-gap-001-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-gap-001.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-gap-002-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-gap-002.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-gap-003.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-gap-fraction-001-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-gap-fraction-001.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-gap-large-001-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-gap-large-001.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-gap-large-002-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-gap-large-002.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-gap-negative-001.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-height-001-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-height-001.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-height-block-child-001-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-height-block-child-001.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-inherit-001-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-inherit-001.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-inherit-002-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-inherit-002.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-inherit-003.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-inherit-004.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-inherit-3-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-inherit-4-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-list-item-001-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-list-item-001.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-margin-001.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-margin-002.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-margin-child-001-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-margin-child-001.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-nested-002-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-nested-002.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-nested-005-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-nested-005.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-nested-column-rule-001-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-nested-column-rule-001.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-nested-margin-001-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-nested-margin-001.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-nested-margin-002-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-nested-margin-002.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-nested-margin-003-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-nested-margin-003.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-nested-margin-004-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-nested-margin-004.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-nested-margin-005.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-overflow-000-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-overflow-000.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-overflowing-001-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-overflowing-001.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-red.png
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-reduce-000-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-reduce-000.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-rule-000-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-rule-000.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-rule-001-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-rule-001.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-rule-002.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-rule-003-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-rule-003.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-rule-004-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-rule-004.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-rule-color-001-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-rule-color-001.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-rule-color-inherit-001-ref.xht
[add] https://crrev.com/44906581b49621ee2d7be6ef9a3f575db4dca331/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-rule-color-inherit-001.xht
[add] https://crrev.com/44906

Comment 2 by cbiesin...@chromium.org, Nov 27 2017

Status: Available (was: Untriaged)

Comment 3 by mstensho@chromium.org, Nov 28 2017

Owner: mstensho@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d50fcb3a3a3b052174b1171552fbf4d16bb83bc

commit 7d50fcb3a3a3b052174b1171552fbf4d16bb83bc
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Fri Dec 01 14:50:24 2017

Rewrite wpt/css/css-multicol/multicol-br-inside-avoidcolumn-001.xht

It was invalid. Not quite sure what it assumed, but probably that
column-span:all was allowed to overlap with the column content that came
after.

Bug:  788337 
Change-Id: I63d5279da9939a0e027bb1ed9084b03b3a32bacb
Reviewed-on: https://chromium-review.googlesource.com/803277
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520936}
[modify] https://crrev.com/7d50fcb3a3a3b052174b1171552fbf4d16bb83bc/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/7d50fcb3a3a3b052174b1171552fbf4d16bb83bc/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-br-inside-avoidcolumn-001.xht
[delete] https://crrev.com/b62df366c54502a459d3a08f4426920b2d5b7c32/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-br-inside-avoidcolumn-ref.xht
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be06cfb35b9ba633173cbb7d4e2fd9f5932cbb0c

commit be06cfb35b9ba633173cbb7d4e2fd9f5932cbb0c
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Fri Dec 01 23:16:45 2017

Correct wpt/css/css-multicol/multicol-break-001.xht

There's no break opportunity before the first block child, only between
siblings.

Bug:  788337 
Change-Id: I185e9d5a8318d2964c9db3c3a80733ed2617eb24
Reviewed-on: https://chromium-review.googlesource.com/803441
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521106}
[modify] https://crrev.com/be06cfb35b9ba633173cbb7d4e2fd9f5932cbb0c/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/be06cfb35b9ba633173cbb7d4e2fd9f5932cbb0c/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-break-001-ref.xht
[modify] https://crrev.com/be06cfb35b9ba633173cbb7d4e2fd9f5932cbb0c/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-break-001.xht
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65f370487bfa2c4abd4f21e9d52053a598686afb

commit 65f370487bfa2c4abd4f21e9d52053a598686afb
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Mon Dec 04 15:40:51 2017

Remove css-multicol tests assuming that column-gap affects column-count.

This may have been correct with some version of the spec, but the
current one just says to use column-count as specified, if column-width
is auto.  There's nothing that suggests that the width of column-gap
should affect used column-count.

https://www.w3.org/TR/css-multicol-1/#pseudo-algorithm

See line 04 below.
(01)  if ((column-width = auto) and (column-count = auto)) then
(02)      exit; /* not a multicol element */
(03)  if column-width = auto then
(04)      N := column-count

Bug:  788337 
Change-Id: I583aa0c3752a9a43b9b59725be2aa67d947487c9
Reviewed-on: https://chromium-review.googlesource.com/805975
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521343}
[modify] https://crrev.com/65f370487bfa2c4abd4f21e9d52053a598686afb/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/7f1542b75645fb2e269d4aee46b5a41d49442ac8/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-count-computed-001.xht
[delete] https://crrev.com/7f1542b75645fb2e269d4aee46b5a41d49442ac8/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-count-computed-002.xht
[delete] https://crrev.com/7f1542b75645fb2e269d4aee46b5a41d49442ac8/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-count-computed-2-ref.xht
[delete] https://crrev.com/7f1542b75645fb2e269d4aee46b5a41d49442ac8/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-count-computed-ref.xht
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96213b157ec9e295032b2a63163b3a80a55ddb66

commit 96213b157ec9e295032b2a63163b3a80a55ddb66
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Mon Dec 04 19:52:24 2017

Remove css-multicol tests assuming no support for subpixel rendering.

In an engine with subpixel support, these tests would render ever so
slightly "incorrectly", compared to the ref, which assumed that all
values less than 1px be rounded down to 0.

Bug:  788337 
Change-Id: I5810a9620763fa0065ee480ed953a1426c95cf93
Reviewed-on: https://chromium-review.googlesource.com/806173
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521419}
[modify] https://crrev.com/96213b157ec9e295032b2a63163b3a80a55ddb66/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/449d25524a82d1d93999ed2dcf5dbb3e2e926080/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-count-large-001.xht
[delete] https://crrev.com/449d25524a82d1d93999ed2dcf5dbb3e2e926080/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-count-large-002.xht
[delete] https://crrev.com/449d25524a82d1d93999ed2dcf5dbb3e2e926080/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-count-large-2-ref.xht
[delete] https://crrev.com/449d25524a82d1d93999ed2dcf5dbb3e2e926080/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-count-large-ref.xht
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8485e49994ab48e6c736242c04884f3d998f9d1f

commit 8485e49994ab48e6c736242c04884f3d998f9d1f
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Mon Dec 04 20:58:52 2017

Fix css-multicol test to not make assumptions about the window size.

This test used to fail in Blink, because the default window width is
800px when running tests. The test assumed a slightly wider window in
order to not produce a horizontal scrollbar in the test (while the ref
would not produce any scrollbar that easily).

Bug:  788337 
Change-Id: I30e5c628ad584862bdbdf71140d228a552e12e74
Reviewed-on: https://chromium-review.googlesource.com/806196
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521446}
[modify] https://crrev.com/8485e49994ab48e6c736242c04884f3d998f9d1f/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/8485e49994ab48e6c736242c04884f3d998f9d1f/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-fill-auto-block-children-002-ref.xht
[modify] https://crrev.com/8485e49994ab48e6c736242c04884f3d998f9d1f/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-fill-auto-block-children-002.xht
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc432e126d20adea43b2fd57b604ec65238b8655

commit cc432e126d20adea43b2fd57b604ec65238b8655
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Tue Dec 05 09:21:22 2017

Remove css-multicol/multicol-fill-auto.xht test with bogus ref.

It doesn't seem too interesting (given that we have other tests that
test column-fill:auto), and the reference it's paired with has nothing
to do with the test.

Bug:  788337 
Change-Id: Ic98b339219bee74fe07ebfa5778869cdd2bfa28e
Reviewed-on: https://chromium-review.googlesource.com/806277
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521647}
[modify] https://crrev.com/cc432e126d20adea43b2fd57b604ec65238b8655/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/0ec0451c51ef1dfb026b5cba65eb2e8af3277810/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-fill-auto.xht
[delete] https://crrev.com/0ec0451c51ef1dfb026b5cba65eb2e8af3277810/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-fill-ref.xht
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a92b4e19ccd2bcb49bbb80b7eae5daf0c6369f9

commit 5a92b4e19ccd2bcb49bbb80b7eae5daf0c6369f9
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Tue Dec 05 10:42:20 2017

Remove css-multicol/multicol-inherit-004.xht test.

It's obsoleted by multicol-nested-column-rule-001.xht, according to that
test.

Bug:  788337 
Change-Id: I8a4b324c936d25137e0775164b7bee21b1fdaa0a
Reviewed-on: https://chromium-review.googlesource.com/807927
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521657}
[modify] https://crrev.com/5a92b4e19ccd2bcb49bbb80b7eae5daf0c6369f9/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/08a8eeaf4c40bc1f2b6800dfb31514c269e7134f/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-inherit-004.xht
[delete] https://crrev.com/08a8eeaf4c40bc1f2b6800dfb31514c269e7134f/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-inherit-4-ref.xht
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fce5d69feeb5d0117ee507100be2e72273708dfe

commit fce5d69feeb5d0117ee507100be2e72273708dfe
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Tue Dec 05 12:20:37 2017

Make css-multicol/multicol-nested-column-rule-001.xht narrower.

Allows for narrower windows without causing scrollbar issues. Blink uses
800px when running layout tests.

Bug:  788337 
Change-Id: I7abd46699d1d58511ec3489f180f8733d3f7f1c3
Reviewed-on: https://chromium-review.googlesource.com/808306
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521675}
[modify] https://crrev.com/fce5d69feeb5d0117ee507100be2e72273708dfe/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/fce5d69feeb5d0117ee507100be2e72273708dfe/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-nested-column-rule-001-ref.xht
[modify] https://crrev.com/fce5d69feeb5d0117ee507100be2e72273708dfe/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-nested-column-rule-001.xht
Project Member

Comment 12 by bugdroid1@chromium.org, Dec 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11a86f3cdf6ec7c30e39b6057dac82d5ac1836d8

commit 11a86f3cdf6ec7c30e39b6057dac82d5ac1836d8
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Wed Dec 06 15:43:51 2017

Correct multicol-rule-fraction-3-ref.xht offsets.

I'm not sure what this test really provides. The name suggests that it
has something to do with column rules, but there are no column rules
defined. There is something that looks like rules, but they are in fact
absolutely positioned boxes placed in the middle of the column gaps.
Anyway, let's at least use the same offsets in the test and in the ref,
instead of being slightly off.

Bug:  788337 
Change-Id: Ic6a07e7020d54e545413c1c7a68f5acdd52019a4
Reviewed-on: https://chromium-review.googlesource.com/810966
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522096}
[modify] https://crrev.com/11a86f3cdf6ec7c30e39b6057dac82d5ac1836d8/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/11a86f3cdf6ec7c30e39b6057dac82d5ac1836d8/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-rule-fraction-3-ref.xht
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1608b461d20e9cc38683476b5d3037e3ed2d4a82

commit 1608b461d20e9cc38683476b5d3037e3ed2d4a82
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Wed Dec 06 17:19:54 2017

Remove multicol-rule-style-* tests.

multicol-rule-style-foo were covering exactly the same thing that
multicol-rule-foo did.

Bug:  788337 
Change-Id: I4102a21194a6f99e595930054655f7aaeace432e
Reviewed-on: https://chromium-review.googlesource.com/811164
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522123}
[modify] https://crrev.com/1608b461d20e9cc38683476b5d3037e3ed2d4a82/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/36fe3be5307e91c7cefa3491835d890c3424613a/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-rule-style-groove-001-ref.xht
[delete] https://crrev.com/36fe3be5307e91c7cefa3491835d890c3424613a/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-rule-style-groove-001.xht
[delete] https://crrev.com/36fe3be5307e91c7cefa3491835d890c3424613a/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-rule-style-inset-001.xht
[delete] https://crrev.com/36fe3be5307e91c7cefa3491835d890c3424613a/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-rule-style-outset-001.xht
[delete] https://crrev.com/36fe3be5307e91c7cefa3491835d890c3424613a/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-rule-style-ridge-001-ref.xht
[delete] https://crrev.com/36fe3be5307e91c7cefa3491835d890c3424613a/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-rule-style-ridge-001.xht
Project Member

Comment 14 by bugdroid1@chromium.org, Dec 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/101dbbefb8147a25944294f577263ef468e65b3e

commit 101dbbefb8147a25944294f577263ef468e65b3e
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Wed Dec 06 18:15:34 2017

Don't let multicol-span-all-child-001.xht be affected by orphans/widows.

That was clearly not the author's intention.

Bug:  788337 
Change-Id: I0b60d27ecf339aa2ca3caecdeb6327e08b2b3039
Reviewed-on: https://chromium-review.googlesource.com/810746
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522138}
[modify] https://crrev.com/101dbbefb8147a25944294f577263ef468e65b3e/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/101dbbefb8147a25944294f577263ef468e65b3e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-003.xht
Project Member

Comment 15 by bugdroid1@chromium.org, Dec 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff25a70575bec00552a2c7a6ac9de7a539fe0960

commit ff25a70575bec00552a2c7a6ac9de7a539fe0960
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Wed Dec 06 19:35:44 2017

Remove multicol-span-all-margin-nested-003.xht.

It's unclear what it attempted to test. The file name suggests something
with margins, but there are no margins in the test. Furthermore, the ref
assumes a buggy intrinsic width calculation: There are four words of
column content. The max-content-width should be so that the multicol container
can hold all the four words on the same line. There are four columns too, so
the multicol container actually has to be rather wide.

If column-gap is 1em and each character and non-collapsable whitespace
also is 1em wide, the width of the line of text will be 4+1+4+1+4+1+4em
= 19em. That's the column width we want. But we have 4 columns, so
multiply that by 4 -> 76em. Add the 3 gaps between the 4 columns ->
79em. I.e. 1264px if the font-size is 16px. The ref assumes way less
than that (22em).

Bug:  788337 
Change-Id: I076af29bf53914557c40b5e438b5eebfb8439e42
Reviewed-on: https://chromium-review.googlesource.com/811645
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522164}
[modify] https://crrev.com/ff25a70575bec00552a2c7a6ac9de7a539fe0960/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/e5c484ddc7c689b81baf441cde5abc4d1394d2d6/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-margin-nested-003.xht
[delete] https://crrev.com/e5c484ddc7c689b81baf441cde5abc4d1394d2d6/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-margin-nested-3-ref.xht
Project Member

Comment 16 by bugdroid1@chromium.org, Dec 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ea001db6e08710a43b36bd41cd91c8f858a3a1a

commit 9ea001db6e08710a43b36bd41cd91c8f858a3a1a
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Wed Dec 06 21:03:33 2017

Change ahem font size in multicol-table-cell-vertical-align-001.xht

The Ahem font doesn't behave reliably at any given size. Multiples of
5px is supposed to work better. So use 20px instead of the default
(16px).

Bug:  788337 
Change-Id: Ifd803008c6780a32fbeb5609faf23270ed4e8066
Reviewed-on: https://chromium-review.googlesource.com/811485
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522190}
[modify] https://crrev.com/9ea001db6e08710a43b36bd41cd91c8f858a3a1a/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/9ea001db6e08710a43b36bd41cd91c8f858a3a1a/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-table-cell-vertical-align-001.xht
[modify] https://crrev.com/9ea001db6e08710a43b36bd41cd91c8f858a3a1a/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-table-cell-vertical-align-ref.xht
Project Member

Comment 17 by bugdroid1@chromium.org, Dec 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ac7b1abd494d0131f513fbd675e2f6f9c7b00a9

commit 9ac7b1abd494d0131f513fbd675e2f6f9c7b00a9
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Fri Dec 08 17:58:25 2017

Rework and rename multicol-width-ems-001.xht (ems -> ch).

Change it to use ch units instead of em, so that we can specify the
number of characters that are expected to fit more reliably (with a
monospace font).

Bug:  788337 
Change-Id: I0d67b21f5dea3f3cb34cfd92114255826f1c7d88
Reviewed-on: https://chromium-review.googlesource.com/812224
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522818}
[modify] https://crrev.com/9ac7b1abd494d0131f513fbd675e2f6f9c7b00a9/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/9ac7b1abd494d0131f513fbd675e2f6f9c7b00a9/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-width-ch-001.xht
[add] https://crrev.com/9ac7b1abd494d0131f513fbd675e2f6f9c7b00a9/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-width-ch-ref.xht
[delete] https://crrev.com/06650609c78bbb6675c012ef67d75f22ddc4c034/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-width-ems-001.xht
[delete] https://crrev.com/06650609c78bbb6675c012ef67d75f22ddc4c034/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-width-ems-ref.xht
Project Member

Comment 19 by bugdroid1@chromium.org, Dec 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3196e1dd3d2ae1609b0a4c17d28c0d080fb0a64

commit e3196e1dd3d2ae1609b0a4c17d28c0d080fb0a64
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Mon Dec 11 22:12:35 2017

Correct multicol-width-small-001.xht to clip overflow.

This test was expected to clip overflow, but the current version of the
spec says that column boxes should not clip overflow [1]. This
contradicts older versions of the spec, where we were supposed to clip
at column gaps. But even with such an old version of the spec, the final
"c" letter would not get clipped, because there's no adjacent column gap
there, since it's in the last column.

So just wrap everything inside the multicol container inside an
overflow:hidden DIV.

[1] https://www.w3.org/TR/css-multicol-1/#overflow-inside-multicol-elements

Bug:  788337 
Change-Id: I9b7382bf40a0c2aeb0fb2c6b9b309e9c334c534f
Reviewed-on: https://chromium-review.googlesource.com/817994
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523228}
[modify] https://crrev.com/e3196e1dd3d2ae1609b0a4c17d28c0d080fb0a64/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/e3196e1dd3d2ae1609b0a4c17d28c0d080fb0a64/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-width-small-001.xht
Project Member

Comment 20 by bugdroid1@chromium.org, Dec 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eff3260661d0e96a855fa075c32a13bfb2bd296e

commit eff3260661d0e96a855fa075c32a13bfb2bd296e
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Tue Dec 12 00:58:05 2017

multicol-zero-height-001-ref.xht produces 1px tall fragmentainers.

The fragmentation spec says that fragmentainer heights should never be
shorter than 1px [1], so that we don't get stuck without content
progress. This means that if the multicol container's content box height
is 0, fragmentainers inside it will still be 1px. The ref depended on
incorrect behavior in Presto, where floats would never be fragmented.

[1] https://www.w3.org/TR/css-break-3/#breaking-rules

Bug:  788337 
Change-Id: I96338070458a9df518d1b4bb70eee399bfde48ab
Reviewed-on: https://chromium-review.googlesource.com/821010
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523278}
[modify] https://crrev.com/eff3260661d0e96a855fa075c32a13bfb2bd296e/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/eff3260661d0e96a855fa075c32a13bfb2bd296e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-zero-height-001-ref.xht
[modify] https://crrev.com/eff3260661d0e96a855fa075c32a13bfb2bd296e/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-zero-height-001.xht
Project Member

Comment 21 by bugdroid1@chromium.org, Dec 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5040512de8c4075b9a8c52639672130bc50ea87a

commit 5040512de8c4075b9a8c52639672130bc50ea87a
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Tue Dec 12 10:30:21 2017

Update multicol-height-block-child-001.xht to match the current spec.

The multicol spec [1] changed at some point from saying to clip overflow
at the middle of column gaps, to saying that we shouldn't clip at all.

A lot of tests got adjusted to match this some time ago [2], but this one
was left behind.

[1] https://www.w3.org/TR/css-multicol-1/#overflow-inside-multicol-elements
[2] https://github.com/w3c/web-platform-tests/commit/b554395c79e502eee8cab95266461e607fa1d8e4

While Blink generally follows an old version of the spec, and therefore
clips, it miraculously fails to do so here. So the test passes, now that
it has been corrected.

Bug:  788337 
Change-Id: I1b1e556102461e5442058f54d612fa7f696456c2
Reviewed-on: https://chromium-review.googlesource.com/822094
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523393}
[modify] https://crrev.com/5040512de8c4075b9a8c52639672130bc50ea87a/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/5040512de8c4075b9a8c52639672130bc50ea87a/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-height-block-child-001-ref.xht
[modify] https://crrev.com/5040512de8c4075b9a8c52639672130bc50ea87a/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-height-block-child-001.xht
Project Member

Comment 22 by bugdroid1@chromium.org, Dec 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/afe06dbb5eaaf6cd81529e0abe04b1257b90c0d0

commit afe06dbb5eaaf6cd81529e0abe04b1257b90c0d0
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Tue Dec 12 11:31:00 2017

Remove invalid multicol tall spanner tests.

The spec says the following about an object with column-span:all [1]:

"When space is limited, it may be impossible to find room for the
spanning element. In these cases, user agents may treat the element as
if none had been specified on this property."

So... user agents MAY? In other words, it's not a requirement, and
therefore we cannot test this.

[1] https://www.w3.org/TR/css-multicol-1/#column-span (and then scroll
down some)

Bug:  788337 
Change-Id: I404a763397294c83c6611e3722f809cfa0f5a389
Reviewed-on: https://chromium-review.googlesource.com/822113
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523403}
[modify] https://crrev.com/afe06dbb5eaaf6cd81529e0abe04b1257b90c0d0/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/c54ff4dcca16c77a096ef6a0e0e5e00ebc1faee5/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-child-001-ref.xht
[delete] https://crrev.com/c54ff4dcca16c77a096ef6a0e0e5e00ebc1faee5/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-child-001.xht
[delete] https://crrev.com/c54ff4dcca16c77a096ef6a0e0e5e00ebc1faee5/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-child-002-ref.xht
[delete] https://crrev.com/c54ff4dcca16c77a096ef6a0e0e5e00ebc1faee5/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-child-002.xht
Project Member

Comment 23 by bugdroid1@chromium.org, Dec 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c22925f307e891ac5184b3258a56b9347098d810

commit c22925f307e891ac5184b3258a56b9347098d810
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Tue Dec 12 13:18:42 2017

Associate remaining wpt multicol tests with dedicated bug reports.

Bug:  788337 , 776051 ,792435,792437,636055,792446, 794136 
Change-Id: I933ece936b79323bfcdf16cc96fd3475f42349f6
Reviewed-on: https://chromium-review.googlesource.com/822254
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523416}
[modify] https://crrev.com/c22925f307e891ac5184b3258a56b9347098d810/third_party/WebKit/LayoutTests/TestExpectations

Comment 24 by mstensho@chromium.org, Dec 12 2017

Status: Fixed (was: Assigned)
I've gone through all failing tests now, and fixed the tests that needed fixing, and deleted invalid ones. I've associated the remaining failing tests with 5 bugs: bug 636055,  bug 776051 , bug 792435, bug 792437 and bug 792446.

Finally, there are some flaky tests on a certain Windows bot. That's reported as  bug 794136 .
►

Sign in to add a comment