New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 788325 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

4.5% regression in thread_times.key_silk_cases at 517735:517746

Project Member Reported by hjd@google.com, Nov 24 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Nov 24 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=788325

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=3374b19b1e88ecd7704e50758b8866041a7bd01e36b39f14055f3d66cafb44af


Bot(s) for this bug's original alert(s):

android-one
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Nov 24 2017

Cc: rsesek@chromium.org
Owner: rsesek@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author rsesek@chromium.org ===

Hi rsesek@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Robert Sesek
  Commit : 6f117f26d776f0ba5657451d89800f556a30c3f3
  Date   : Mon Nov 20 00:56:36 2017
  Subject: Introduce the new CrashKeyString API.

Bisect Details
  Configuration: android_one_perf_bisect
  Benchmark    : thread_times.key_silk_cases
  Metric       : thread_GPU_cpu_time_per_frame/inbox_app.html?toggle_drawer
  Change       : 4.14% | 3.07078724281 -> 3.19786226147

Revision             Result                    N
chromium@517734      3.07079 +- 0.0935823      6      good
chromium@517737      3.02339 +- 0.0509178      6      good
chromium@517739      3.01595 +- 0.178909       6      good
chromium@517740      3.20185 +- 0.0755065      6      bad       <--
chromium@517746      3.19786 +- 0.111235       6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=inbox.app.html.toggle.drawer thread_times.key_silk_cases

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8962048331081744496


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Nov 24 2017

 Issue 788351  has been merged into this issue.
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Nov 24 2017

 Issue 788369  has been merged into this issue.
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Nov 24 2017

 Issue 788376  has been merged into this issue.
Cc: pmeenan@chromium.org
 Issue 792016  has been merged into this issue.
Cc: vmi...@chromium.org
rsesek: Have you had a chance to look into this bug? Adding benchmark owner vmiura in case there are questions about severity.

Comment 9 by rsesek@chromium.org, Jan 23 2018

It looks like the metric has already improved at 528341 - 528436 to be below where it was before this regression.
Status: WontFix (was: Assigned)
Not sure if it was a targeted fix or improved from other work but closing it out since it is better than pre-regression.

Sign in to add a comment