New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 788322 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android , Windows , iOS , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

4767.3% regression in system_health.memory_mobile at 517074:517429

Project Member Reported by hjd@google.com, Nov 24 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Nov 24 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=788322

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=30d082c06f89cbfc4b04e9e1481e81c09536ae41037d85013f2c2413909997dd


Bot(s) for this bug's original alert(s):

android-one
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Nov 24 2017

Cc: ericrk@chromium.org
Owner: ericrk@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author ericrk@chromium.org ===

Hi ericrk@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Eric Karl
  Commit : 86c790e6a6dcdbec73f22ed343265963c901e749
  Date   : Thu Nov 16 22:15:14 2017
  Subject: Remove use of DeferredTextureImageData APIs and Support Decode to Scale

Bisect Details
  Configuration: android_one_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:chrome:all_processes:reported_by_chrome:skia:effective_size_avg/browse_media/browse_media_flickr_infinite_scroll
  Change       : 4767.28% | 47560.0 -> 2314880.0

Revision             Result                  N
chromium@517073      47560.0 +- 0.0          6      good
chromium@517163      47560.0 +- 0.0          6      good
chromium@517186      47560.0 +- 0.0          6      good
chromium@517197      47396.0 +- 898.265      6      good
chromium@517203      47560.0 +- 0.0          6      good
chromium@517205      47560.0 +- 0.0          5      good
chromium@517206      2314880 +- 0.0          6      bad       <--
chromium@517208      2314880 +- 0.0          6      bad
chromium@517252      2259380 +- 303986       6      bad
chromium@517429      2314880 +- 0.0          5      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.media.flickr.infinite.scroll system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8962048467586981008


For feedback, file a bug with component Speed>Bisection

Comment 4 by ericrk@chromium.org, Dec 18 2017

Cc: abdulsyed@chromium.org
Labels: -Pri-2 Merge-Request-64 Pri-1
Landed a revert to address this: https://chromium-review.googlesource.com/c/chromium/src/+/830587

This turned out to be harder to address than expected, so I opted for revert rather than fix. The same revert will also address  issue 787193  and  issue 787182 . Given that this will address 3 regressions I'm bumping this to P1.

+abdulsyed@, per offline discussion on Friday, I'd like to merge this to M64. This is a straightforward revert and very low risk. The code is baking in Today's Canary build, and I haven't seen any issues so far. I'll check in tomorrow morning as well.

Project Member

Comment 5 by sheriffbot@chromium.org, Dec 18 2017

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by cma...@chromium.org, Dec 19 2017

ericrk@ please add the right OS(es)

Comment 7 by ericrk@chromium.org, Dec 19 2017

Labels: OS-Android OS-Mac OS-Windows
Duping the other two issues to this one. Two regressions were from Mac (and probably Windows as well, but our bots don't have coverage there), one was from Android. Adding OSes.

Comment 8 by ericrk@chromium.org, Dec 19 2017

Cc: benhenry@google.com
 Issue 787193  has been merged into this issue.

Comment 9 by ericrk@chromium.org, Dec 19 2017

Cc: vmp...@chromium.org
 Issue 787182  has been merged into this issue.
I've confirmed that the revert addressed the issues mentioned. Additionally, we haven't seen any new issues since landing on Sat.
Labels: -Merge-Review-64 Merge-Approved-64 OS-iOS
Thanks for the revert ericrk@, approving revert for M64. branch:3282
Labels: -Merge-Approved-64 merge-merged-3282
Modifying labels as per c#12.

Sign in to add a comment