4767.3% regression in system_health.memory_mobile at 517074:517429 |
||||||||
Issue descriptionSee the link to graphs below.
,
Nov 24 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8962048467586981008
,
Nov 24 2017
=== Auto-CCing suspected CL author ericrk@chromium.org === Hi ericrk@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Eric Karl Commit : 86c790e6a6dcdbec73f22ed343265963c901e749 Date : Thu Nov 16 22:15:14 2017 Subject: Remove use of DeferredTextureImageData APIs and Support Decode to Scale Bisect Details Configuration: android_one_perf_bisect Benchmark : system_health.memory_mobile Metric : memory:chrome:all_processes:reported_by_chrome:skia:effective_size_avg/browse_media/browse_media_flickr_infinite_scroll Change : 4767.28% | 47560.0 -> 2314880.0 Revision Result N chromium@517073 47560.0 +- 0.0 6 good chromium@517163 47560.0 +- 0.0 6 good chromium@517186 47560.0 +- 0.0 6 good chromium@517197 47396.0 +- 898.265 6 good chromium@517203 47560.0 +- 0.0 6 good chromium@517205 47560.0 +- 0.0 5 good chromium@517206 2314880 +- 0.0 6 bad <-- chromium@517208 2314880 +- 0.0 6 bad chromium@517252 2259380 +- 303986 6 bad chromium@517429 2314880 +- 0.0 5 bad Please refer to the following doc on diagnosing memory regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.media.flickr.infinite.scroll system_health.memory_mobile More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8962048467586981008 For feedback, file a bug with component Speed>Bisection
,
Dec 18 2017
Landed a revert to address this: https://chromium-review.googlesource.com/c/chromium/src/+/830587 This turned out to be harder to address than expected, so I opted for revert rather than fix. The same revert will also address issue 787193 and issue 787182 . Given that this will address 3 regressions I'm bumping this to P1. +abdulsyed@, per offline discussion on Friday, I'd like to merge this to M64. This is a straightforward revert and very low risk. The code is baking in Today's Canary build, and I haven't seen any issues so far. I'll check in tomorrow morning as well.
,
Dec 18 2017
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 19 2017
ericrk@ please add the right OS(es)
,
Dec 19 2017
Duping the other two issues to this one. Two regressions were from Mac (and probably Windows as well, but our bots don't have coverage there), one was from Android. Adding OSes.
,
Dec 19 2017
,
Dec 19 2017
,
Dec 19 2017
I've confirmed that the revert addressed the issues mentioned. Additionally, we haven't seen any new issues since landing on Sat.
,
Dec 19 2017
Thanks for the revert ericrk@, approving revert for M64. branch:3282
,
Dec 19 2017
Merged as 94479c4cca4e9c4b4ec9a910b83c056005fb0ac7 - https://chromium-review.googlesource.com/c/chromium/src/+/834451
,
Jan 2 2018
Modifying labels as per c#12. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Nov 24 2017