Issue metadata
Sign in to add a comment
|
1.4% regression in webrtc_perf_tests at 20835:20835 |
||||||||||||||||||||
Issue descriptionCan't really see anything that should've caused this, but https://webrtc-review.googlesource.com/24880 is the closest thing I could find. PTAL or close if that seems unreasonable.
,
Nov 24 2017
Duped this one: https://chromeperf.appspot.com/report?sid=2ffef4eb055bf4c4c7da8592374e2b10d0533b400ee8d120584a80ec9d2c8e57&rev=20831 to this bug as well. They changed at the same time.
,
Nov 24 2017
Seems to be a non-issue. Reassigning to the author of the test (ivoc@).
,
Nov 24 2017
This test is infamous for it's false positives, so I will disable/remove it. Also, I don't think it has ever caught a real regression, so I don't think it will be missed. I'll use this bug to disable it.
,
Nov 24 2017
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/69d276d7dcc774d273a94758af9e29501bacf310 commit 69d276d7dcc774d273a94758af9e29501bacf310 Author: Ivo Creusen <ivoc@webrtc.org> Date: Fri Nov 24 16:15:59 2017 Removed residual echo complexity unittest. This test produces a consistent stream of false positive alerts, and I have been unable to make it more robust, despite several attempts. It also has never managed to catch a real regression, so I think it is better to remove it. Bug: chromium:788318 Change-Id: I7e9731834f67af1ef2fa15a655e620bd64a4cfde Reviewed-on: https://webrtc-review.googlesource.com/25824 Commit-Queue: Ivo Creusen <ivoc@webrtc.org> Reviewed-by: Alex Loiko <aleloi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20874} [modify] https://crrev.com/69d276d7dcc774d273a94758af9e29501bacf310/modules/audio_processing/BUILD.gn [delete] https://crrev.com/7bd6cccb40f550850501b56077b872f8b13380aa/modules/audio_processing/residual_echo_detector_complexity_unittest.cc
,
Nov 24 2017
I think this is now 'fixed', since I removed the test. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Nov 24 2017