New issue
Advanced search Search tips

Issue 788315 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 781761



Sign in to add a comment

[Dice] When preparing migration, clear tokens when cookies are cleared

Project Member Reported by droger@chromium.org, Nov 24 2017

Issue description

Dice milestone 2 collects Chrome LST tokens when users get Gaia cookies.
These tokens should be cleared when the cookies are cleared.
 

Comment 1 by droger@chromium.org, Nov 24 2017

Cc: ew...@chromium.org
ewald: I have a CL for this, no need to followup with privacy team to change this requirement.

Comment 2 by ew...@chromium.org, Nov 27 2017

Cc: msarda@chromium.org
Labels: -Pri-3 M-64 Pri-2
Thanks for the heads up, David. Chatted with Mihai about this as well.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc9fb2297c61ac6127949c17e3d0414aebfc0c23

commit cc9fb2297c61ac6127949c17e3d0414aebfc0c23
Author: David Roger <droger@chromium.org>
Date: Tue Nov 28 15:53:19 2017

[signin] Dice migration: Clear LST tokens when gaia cookies are cleared

This CL adds ShouldReconcileAccount() function on the
DiceAccountReconcilor delegate, that is used to revoke the tokens when
cookies are empty.

As a cleanup, the chrome_account_ member is changed to a local variable,
to reduce the amount of state in the AccountReconcilor, making it
hopefully more readable.

Bug:  788315 
Change-Id: Id4348a6ae2e524de721d39c84cb4e150adb892b2
Reviewed-on: https://chromium-review.googlesource.com/789032
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519697}
[modify] https://crrev.com/cc9fb2297c61ac6127949c17e3d0414aebfc0c23/components/signin/core/browser/account_reconcilor.cc
[modify] https://crrev.com/cc9fb2297c61ac6127949c17e3d0414aebfc0c23/components/signin/core/browser/account_reconcilor.h
[modify] https://crrev.com/cc9fb2297c61ac6127949c17e3d0414aebfc0c23/components/signin/core/browser/account_reconcilor_delegate.cc
[modify] https://crrev.com/cc9fb2297c61ac6127949c17e3d0414aebfc0c23/components/signin/core/browser/account_reconcilor_delegate.h
[modify] https://crrev.com/cc9fb2297c61ac6127949c17e3d0414aebfc0c23/components/signin/core/browser/account_reconcilor_unittest.cc
[modify] https://crrev.com/cc9fb2297c61ac6127949c17e3d0414aebfc0c23/components/signin/core/browser/dice_account_reconcilor_delegate.cc
[modify] https://crrev.com/cc9fb2297c61ac6127949c17e3d0414aebfc0c23/components/signin/core/browser/dice_account_reconcilor_delegate.h
[modify] https://crrev.com/cc9fb2297c61ac6127949c17e3d0414aebfc0c23/components/signin/core/browser/dice_account_reconcilor_delegate_unittest.cc

Comment 4 by droger@chromium.org, Nov 28 2017

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/635a63b73406b5cf326881a014e39edcb93f480a

commit 635a63b73406b5cf326881a014e39edcb93f480a
Author: Scott Little <sclittle@chromium.org>
Date: Tue Nov 28 17:40:22 2017

Revert "[signin] Dice migration: Clear LST tokens when gaia cookies are cleared"

This reverts commit cc9fb2297c61ac6127949c17e3d0414aebfc0c23.

Reason for revert: This seems to have broken ios_chrome_settings_egtests (iPad Air 2 iOS 10.0) failing on chromium.mac/ios-simulator-full-configs

The AccountCollectionsTestCase/testMDMError test is failing.

See https://uberchromegw.corp.google.com/i/chromium.mac/builders/ios-simulator-full-configs.

Original change's description:
> [signin] Dice migration: Clear LST tokens when gaia cookies are cleared
> 
> This CL adds ShouldReconcileAccount() function on the
> DiceAccountReconcilor delegate, that is used to revoke the tokens when
> cookies are empty.
> 
> As a cleanup, the chrome_account_ member is changed to a local variable,
> to reduce the amount of state in the AccountReconcilor, making it
> hopefully more readable.
> 
> Bug:  788315 
> Change-Id: Id4348a6ae2e524de721d39c84cb4e150adb892b2
> Reviewed-on: https://chromium-review.googlesource.com/789032
> Commit-Queue: David Roger <droger@chromium.org>
> Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#519697}

TBR=droger@chromium.org,msarda@chromium.org

Change-Id: If4f5e30f574365d1cf7d58e4ca1c41889fa1b0bd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  788315 
Reviewed-on: https://chromium-review.googlesource.com/794250
Reviewed-by: Scott Little <sclittle@chromium.org>
Commit-Queue: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519730}
[modify] https://crrev.com/635a63b73406b5cf326881a014e39edcb93f480a/components/signin/core/browser/account_reconcilor.cc
[modify] https://crrev.com/635a63b73406b5cf326881a014e39edcb93f480a/components/signin/core/browser/account_reconcilor.h
[modify] https://crrev.com/635a63b73406b5cf326881a014e39edcb93f480a/components/signin/core/browser/account_reconcilor_delegate.cc
[modify] https://crrev.com/635a63b73406b5cf326881a014e39edcb93f480a/components/signin/core/browser/account_reconcilor_delegate.h
[modify] https://crrev.com/635a63b73406b5cf326881a014e39edcb93f480a/components/signin/core/browser/account_reconcilor_unittest.cc
[modify] https://crrev.com/635a63b73406b5cf326881a014e39edcb93f480a/components/signin/core/browser/dice_account_reconcilor_delegate.cc
[modify] https://crrev.com/635a63b73406b5cf326881a014e39edcb93f480a/components/signin/core/browser/dice_account_reconcilor_delegate.h
[modify] https://crrev.com/635a63b73406b5cf326881a014e39edcb93f480a/components/signin/core/browser/dice_account_reconcilor_delegate_unittest.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ddc5c1f1ad6343362195001a093b415b5cd0479

commit 5ddc5c1f1ad6343362195001a093b415b5cd0479
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Tue Nov 28 17:47:59 2017

Revert "[signin] Dice migration: Clear LST tokens when gaia cookies are cleared"

This reverts commit cc9fb2297c61ac6127949c17e3d0414aebfc0c23.

Reason for revert: breaks ios_chrome_settings_egtests

Original change's description:
> [signin] Dice migration: Clear LST tokens when gaia cookies are cleared
> 
> This CL adds ShouldReconcileAccount() function on the
> DiceAccountReconcilor delegate, that is used to revoke the tokens when
> cookies are empty.
> 
> As a cleanup, the chrome_account_ member is changed to a local variable,
> to reduce the amount of state in the AccountReconcilor, making it
> hopefully more readable.
> 
> Bug:  788315 
> Change-Id: Id4348a6ae2e524de721d39c84cb4e150adb892b2
> Reviewed-on: https://chromium-review.googlesource.com/789032
> Commit-Queue: David Roger <droger@chromium.org>
> Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#519697}

TBR=droger@chromium.org,msarda@chromium.org

Change-Id: I523e02e242bbb48fb978528c4789f73ce562dd28
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  788315 
Reviewed-on: https://chromium-review.googlesource.com/794111
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519733}

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71a5785e699b81357f2859caa9f2636dcc7de518

commit 71a5785e699b81357f2859caa9f2636dcc7de518
Author: David Roger <droger@chromium.org>
Date: Wed Nov 29 12:49:24 2017

[signin] Dice migration: Clear LST tokens when gaia cookies are cleared

This CL adds ShouldReconcileAccount() function on the
DiceAccountReconcilor delegate, that is used to revoke the tokens when
cookies are empty.

As a cleanup, the chrome_account_ member is changed to a local variable,
to reduce the amount of state in the AccountReconcilor, making it
hopefully more readable.

Bug:  788315 
Change-Id: I2deb86641b6994c3a042b90849b1b6651e4a5264
Reviewed-on: https://chromium-review.googlesource.com/795725
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520085}
[modify] https://crrev.com/71a5785e699b81357f2859caa9f2636dcc7de518/components/signin/core/browser/account_reconcilor.cc
[modify] https://crrev.com/71a5785e699b81357f2859caa9f2636dcc7de518/components/signin/core/browser/account_reconcilor.h
[modify] https://crrev.com/71a5785e699b81357f2859caa9f2636dcc7de518/components/signin/core/browser/account_reconcilor_delegate.cc
[modify] https://crrev.com/71a5785e699b81357f2859caa9f2636dcc7de518/components/signin/core/browser/account_reconcilor_delegate.h
[modify] https://crrev.com/71a5785e699b81357f2859caa9f2636dcc7de518/components/signin/core/browser/account_reconcilor_unittest.cc
[modify] https://crrev.com/71a5785e699b81357f2859caa9f2636dcc7de518/components/signin/core/browser/dice_account_reconcilor_delegate.cc
[modify] https://crrev.com/71a5785e699b81357f2859caa9f2636dcc7de518/components/signin/core/browser/dice_account_reconcilor_delegate.h
[modify] https://crrev.com/71a5785e699b81357f2859caa9f2636dcc7de518/components/signin/core/browser/dice_account_reconcilor_delegate_unittest.cc

Sign in to add a comment