Issue metadata
Sign in to add a comment
|
Regression : Page doesn't navigate to chrome://settings page after clicking on 'REMOVE ANDROID APPS' button instead navigates to New Tab |
||||||||||||||||||||||
Issue descriptionChrome Version: 64.0.3274.0/10156.0.0 dev-channel Squawks,Peppy and Link OS: Chrome What steps will reproduce the problem? (1)Sign in to User ->Open New tab and now type chrome://settings and press 'Enter' -> Scroll down up to section 'Google play store' (2)Now under 'Google play store' section -> Click on 'Turn on' option available at 'Google play store' text (3)Google Play store is enabled -> after Play store gets synced go to 'Google play store' section in chrome://settings Click on 'Google play store' -> Navigates to chrome://settings/androidApps/details page (4)Now click on 'Remove Google play store' option -> 'Remove Android apps?' dialog box is seen and select 'REMOVE ANDROID APPS' button and observe page is navigated to New Tab (Please refer video) Expected: Page should navigate to chrome://settings page after clicking on 'REMOVE ANDROID APPS' button Actual: Instead after clicking on 'REMOVE ANDROID APPS' button page navigates to New Tab This is a Regression issue as same is working fine in M-58 @khmel: please confirm the issue Note : 1.In M-58 under 'Google play store' section 'Enable Google Play Store on your Chromebook' with Toggle button is available. On enabling toggle button play store is enabled -> after play store is synced -> disabled toggle button and observed page does not navigates to New Tab (Please refer 'Expected_PageNavigationInM-58' Video) 3.In Old settings page 'Enable Google Play Store on your Chromebook' with checkbox is available. On clicking text checkbox is checked play store is enabled -> after play store is synced -> click on text and unchecked and observed page does not navigates to New Tab (Please refer 'Oldsettings' Video)
,
Nov 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dee4154b5aae30e1af3fff65d3f19ed2b40766ac commit dee4154b5aae30e1af3fff65d3f19ed2b40766ac Author: khmel <khmel@google.com> Date: Mon Nov 27 23:40:59 2017 arc: Fix navigation back on "Removing Google Play Store" Bug: 788308 Test: Manually in multiple chrome://settings tabs Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3c63ad6e5c6de64054c1cb10db3c744e199cea08 Reviewed-on: https://chromium-review.googlesource.com/791931 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#519452} [modify] https://crrev.com/dee4154b5aae30e1af3fff65d3f19ed2b40766ac/chrome/browser/resources/settings/android_apps_page/android_apps_subpage.js
,
Nov 27 2017
,
Feb 6 2018
Adding M65 since it has branched, and changing from beta to stable blocking since M64 is beyond beta. This doesn't seem to be a blocking issue, however. The workflow is quite specific. I'd like to remove it as a block.
,
Feb 6 2018
@khmel: FYI https://chromium-review.googlesource.com/c/chromium/src/+/879492. I don't know if this re-surfaced the issue, but it was fixing another Relase blocking bug (Settings search broken in ChromeOS).
,
Feb 6 2018
#6 - Thanks, I remember this issue. I don't think this is culprit. Taking a look.
,
Feb 6 2018
,
Feb 6 2018
very unstable repro. tried many times and saw only 2 times
,
Feb 6 2018
,
Feb 6 2018
Details in crrev.com/c/905339
,
Feb 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d904dbf238dd93f373100da6a80fb5233e52e5bf commit d904dbf238dd93f373100da6a80fb5233e52e5bf Author: khmel <khmel@google.com> Date: Wed Feb 07 06:35:59 2018 arc: Fix back navigation for Play Store disabled. androidAppsInfo is composite structure. That means observer on its change can be called multiple times. At Android apps subpage we check only playStoreEnabled == false to navigate back. This leads to case when back is requested few times due the async nature of back processing. As result settings page might be re-directed to wrong place. This CL adds internal flag that indicates playStoreEnabled == false was already handled. This prevents multiple redirection. Bug: 788308 Test: Manually Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iff2b80d2c5e51db066f4a89fc433e3a9f3fd301d Reviewed-on: https://chromium-review.googlesource.com/905339 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#534936} [modify] https://crrev.com/d904dbf238dd93f373100da6a80fb5233e52e5bf/chrome/browser/resources/settings/android_apps_page/android_apps_subpage.js
,
Feb 8 2018
,
Feb 8 2018
This bug requires manual review: M65 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 9 2018
,
Feb 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/623e5890219828d0c4b501ad692d58806911c0e2 commit 623e5890219828d0c4b501ad692d58806911c0e2 Author: khmel <khmel@google.com> Date: Fri Feb 09 18:27:06 2018 [Merge M65] arc: Fix back navigation for Play Store disabled. androidAppsInfo is composite structure. That means observer on its change can be called multiple times. At Android apps subpage we check only playStoreEnabled == false to navigate back. This leads to case when back is requested few times due the async nature of back processing. As result settings page might be re-directed to wrong place. This CL adds internal flag that indicates playStoreEnabled == false was already handled. This prevents multiple redirection. TBR=khmel@google.com (cherry picked from commit d904dbf238dd93f373100da6a80fb5233e52e5bf) Bug: 788308 Test: Manually Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iff2b80d2c5e51db066f4a89fc433e3a9f3fd301d Reviewed-on: https://chromium-review.googlesource.com/905339 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#534936} Reviewed-on: https://chromium-review.googlesource.com/911900 Reviewed-by: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#407} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/623e5890219828d0c4b501ad692d58806911c0e2/chrome/browser/resources/settings/android_apps_page/android_apps_subpage.js
,
Feb 9 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by khmel@chromium.org
, Nov 27 2017