New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 788305 link

Starred by 4 users
Status: Fixed
Owner:
beccahughes@chromium.org
Closed: Mar 2018
Cc:
█ sandeepkumars@chromium.org
beccahughes@chromium.org
mlamouri@chromium.org
steimel@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug


Participants' hotlists:
Modern-Media-Controls


Sign in to add a comment

New Media Controls icons are blurry

Project Member Reported by fbeaufort@chromium.org, Nov 24 2017 
Chrome Version       : 64.0.3274.0
OS Version: 10154.0.0
URLs (if applicable) : https://www.youtube.com/watch?v=tO01J-M3g0U

I'm not sure why but new Media Controls (behind the experimental flag) are blurry while the current ones are not. See screenshots attached
current-media-controls.png
875 KB View Download
new-media-controls.png
901 KB View Download

Comment 1 by pnangunoori@chromium.org, Nov 27 2017

Labels: Needs-triage-Mobile

Comment 2 by sandeepkumars@chromium.org, Nov 27 2017

Cc: sandeepkumars@chromium.org
Labels: M-64 Triaged-Mobile
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue in Android.

Steps Followed:
1. Launched Browser 
2. Navigated to Youtube.com
3. Observed the new media controls are a bit blurry

Chrome versions tested:
64.0.3277.0

OS
Android 8.1.0

Android Devices
8.1.0 Pixel XL Build/OPM1.171019.007.

This is a Non-Regression Issue as the flag "New Media Controls" is available since M64# 64.0.3242.0. Untriaged for further inputs from dev team

Thanks!!

Comment 3 by mlamouri@chromium.org, Nov 29 2017

Labels: -Needs-triage-Mobile -M-64 M-65
Owner: beccahughes@chromium.org
Status: Assigned (was: Untriaged)
It's mostly visible on the mute icon on my phone but it's not as obvious as your screenshots. I guess probably because it's not as "zoomed". We might want to double check that the icon sizes are correct and see if adding 3x or 2.5x icon would help.

fbeaufort@, which phone where you using?

Comment 4 by fbeaufort@chromium.org, Nov 29 2017 

Pixel 1 (sailfish) Android 8.1.0

Comment 5 by beccahughes@chromium.org, Dec 7 2017

Status: Started (was: Assigned)
I will convert the icons to vectors.

Comment 6 by mlamouri@chromium.org, Dec 7 2017 

Before we convert the icons to SVG, we should check what would be the impact. I assume the icons may be smaller in size? Do we know if there would be a runtime cost?

Regarding the issue itself, I believe its source is because we use smaller icons for the modern controls: we used 128px icons for the previous buttons and the new ones seem to be at 24dp (24/48px) which is a significant size difference.

Comment 7 by beccahughes@chromium.org, Dec 7 2017 

Here is one icons size compared:

SVG: 177b

24dp: 150b
24dp (HDPI): 208b

48dp: 208b
48dp (HDPI): 320b

For HDPI platforms we ship both the 1x and the 2x asset so it is more like 150b + 208b. I will try to find out if there is an additional memory overhead with using SVG.

Comment 8 by mlamouri@chromium.org, Dec 7 2017

Labels: OS-Chrome OS-iOS OS-Linux OS-Mac OS-Windows
Those numbers look good. The overhead seems small enough for us to use SVG. It may even help us with some animations :) Unless you find some issues, feel free to do the change :)

Comment 9 by beccahughes@chromium.org, Dec 7 2017

Labels: -OS-Linux -OS-Windows -OS-iOS -OS-Chrome -OS-Mac
Pending CL out to fix.
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6dd82658a5059a606d4ca19e7fd8dee3df234931

commit 6dd82658a5059a606d4ca19e7fd8dee3df234931
Author: Becca Hughes <beccahughes@chromium.org>
Date: Tue Dec 12 12:15:16 2017

Media Controls: Move new controls to SVG icons

Move the new media controls to SVG icons so they are no longer blurry in
some situations.

BUG= 788305 

Change-Id: I3f97be618152c2d8cc00653ab8ff63de260c7d13
Reviewed-on: https://chromium-review.googlesource.com/814296
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523411}
[delete] https://crrev.com/ebf3a5282adcb4eaa862516508517d57ae052009/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/modern/ic_arrow_back.png
[delete] https://crrev.com/ebf3a5282adcb4eaa862516508517d57ae052009/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/modern/ic_check_blue.png
[delete] https://crrev.com/ebf3a5282adcb4eaa862516508517d57ae052009/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/modern/ic_fullscreen.png
[delete] https://crrev.com/ebf3a5282adcb4eaa862516508517d57ae052009/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/modern/ic_fullscreen_exit.png
[delete] https://crrev.com/ebf3a5282adcb4eaa862516508517d57ae052009/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/modern/ic_menu.png
[delete] https://crrev.com/ebf3a5282adcb4eaa862516508517d57ae052009/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/modern/ic_pause.png
[delete] https://crrev.com/ebf3a5282adcb4eaa862516508517d57ae052009/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/modern/ic_play_arrow.png
[delete] https://crrev.com/ebf3a5282adcb4eaa862516508517d57ae052009/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/modern/ic_volume_off.png
[delete] https://crrev.com/ebf3a5282adcb4eaa862516508517d57ae052009/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/modern/ic_volume_up.png
[delete] https://crrev.com/ebf3a5282adcb4eaa862516508517d57ae052009/third_party/WebKit/Source/modules/media_controls/resources/default_200_percent/modern/ic_arrow_back.png
[delete] https://crrev.com/ebf3a5282adcb4eaa862516508517d57ae052009/third_party/WebKit/Source/modules/media_controls/resources/default_200_percent/modern/ic_check_blue.png
[delete] https://crrev.com/ebf3a5282adcb4eaa862516508517d57ae052009/third_party/WebKit/Source/modules/media_controls/resources/default_200_percent/modern/ic_fullscreen.png
[delete] https://crrev.com/ebf3a5282adcb4eaa862516508517d57ae052009/third_party/WebKit/Source/modules/media_controls/resources/default_200_percent/modern/ic_fullscreen_exit.png
[delete] https://crrev.com/ebf3a5282adcb4eaa862516508517d57ae052009/third_party/WebKit/Source/modules/media_controls/resources/default_200_percent/modern/ic_menu.png
[delete] https://crrev.com/ebf3a5282adcb4eaa862516508517d57ae052009/third_party/WebKit/Source/modules/media_controls/resources/default_200_percent/modern/ic_pause.png
[delete] https://crrev.com/ebf3a5282adcb4eaa862516508517d57ae052009/third_party/WebKit/Source/modules/media_controls/resources/default_200_percent/modern/ic_play_arrow.png
[delete] https://crrev.com/ebf3a5282adcb4eaa862516508517d57ae052009/third_party/WebKit/Source/modules/media_controls/resources/default_200_percent/modern/ic_volume_off.png
[delete] https://crrev.com/ebf3a5282adcb4eaa862516508517d57ae052009/third_party/WebKit/Source/modules/media_controls/resources/default_200_percent/modern/ic_volume_up.png
[add] https://crrev.com/6dd82658a5059a606d4ca19e7fd8dee3df234931/third_party/WebKit/Source/modules/media_controls/resources/ic_arrow_back.svg
[add] https://crrev.com/6dd82658a5059a606d4ca19e7fd8dee3df234931/third_party/WebKit/Source/modules/media_controls/resources/ic_cast_off.svg
[add] https://crrev.com/6dd82658a5059a606d4ca19e7fd8dee3df234931/third_party/WebKit/Source/modules/media_controls/resources/ic_cast_on.svg
[add] https://crrev.com/6dd82658a5059a606d4ca19e7fd8dee3df234931/third_party/WebKit/Source/modules/media_controls/resources/ic_check_blue.svg
[add] https://crrev.com/6dd82658a5059a606d4ca19e7fd8dee3df234931/third_party/WebKit/Source/modules/media_controls/resources/ic_closed_caption.svg
[add] https://crrev.com/6dd82658a5059a606d4ca19e7fd8dee3df234931/third_party/WebKit/Source/modules/media_controls/resources/ic_download.svg
[add] https://crrev.com/6dd82658a5059a606d4ca19e7fd8dee3df234931/third_party/WebKit/Source/modules/media_controls/resources/ic_fullscreen.svg
[add] https://crrev.com/6dd82658a5059a606d4ca19e7fd8dee3df234931/third_party/WebKit/Source/modules/media_controls/resources/ic_fullscreen_exit.svg
[add] https://crrev.com/6dd82658a5059a606d4ca19e7fd8dee3df234931/third_party/WebKit/Source/modules/media_controls/resources/ic_menu.svg
[add] https://crrev.com/6dd82658a5059a606d4ca19e7fd8dee3df234931/third_party/WebKit/Source/modules/media_controls/resources/ic_pause.svg
[add] https://crrev.com/6dd82658a5059a606d4ca19e7fd8dee3df234931/third_party/WebKit/Source/modules/media_controls/resources/ic_play_arrow.svg
[add] https://crrev.com/6dd82658a5059a606d4ca19e7fd8dee3df234931/third_party/WebKit/Source/modules/media_controls/resources/ic_volume_off.svg
[add] https://crrev.com/6dd82658a5059a606d4ca19e7fd8dee3df234931/third_party/WebKit/Source/modules/media_controls/resources/ic_volume_up.svg
[modify] https://crrev.com/6dd82658a5059a606d4ca19e7fd8dee3df234931/third_party/WebKit/Source/modules/media_controls/resources/modernMediaControls.css

Comment 11 by beccahughes@chromium.org, Dec 12 2017

Status: Fixed (was: Started)

Comment 12 by fbeaufort@chromium.org, Dec 12 2017

Status: Verified (was: Fixed)
Verified in Chromium 65.0.3293.0.
Thank you Becca!
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7356ebea488b13caaf2df57f93bf4b9cf9842f5

commit c7356ebea488b13caaf2df57f93bf4b9cf9842f5
Author: Christos Froussios <cfroussios@chromium.org>
Date: Tue Dec 12 13:48:41 2017

Revert "Media Controls: Move new controls to SVG icons"

This reverts commit 6dd82658a5059a606d4ca19e7fd8dee3df234931.

Reason for revert: Suspected of breaking multiple webkit_layout_tests.
E.g. https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/13134/steps/webkit_layout_tests


Original change's description:
> Media Controls: Move new controls to SVG icons
>
> Move the new media controls to SVG icons so they are no longer blurry in
> some situations.
>
> BUG= 788305 
>
> Change-Id: I3f97be618152c2d8cc00653ab8ff63de260c7d13
> Reviewed-on: https://chromium-review.googlesource.com/814296
> Commit-Queue: Becca Hughes <beccahughes@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#523411}

TBR=mlamouri@chromium.org,beccahughes@chromium.org

Change-Id: If2c4643d5e6455c86fb1afdc5a68f20279eaaeec
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  788305 ,  794159 
Reviewed-on: https://chromium-review.googlesource.com/822611
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523422}
[add] https://crrev.com/c7356ebea488b13caaf2df57f93bf4b9cf9842f5/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/modern/ic_arrow_back.png
[add] https://crrev.com/c7356ebea488b13caaf2df57f93bf4b9cf9842f5/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/modern/ic_check_blue.png
[add] https://crrev.com/c7356ebea488b13caaf2df57f93bf4b9cf9842f5/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/modern/ic_fullscreen.png
[add] https://crrev.com/c7356ebea488b13caaf2df57f93bf4b9cf9842f5/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/modern/ic_fullscreen_exit.png
[add] https://crrev.com/c7356ebea488b13caaf2df57f93bf4b9cf9842f5/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/modern/ic_menu.png
[add] https://crrev.com/c7356ebea488b13caaf2df57f93bf4b9cf9842f5/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/modern/ic_pause.png
[add] https://crrev.com/c7356ebea488b13caaf2df57f93bf4b9cf9842f5/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/modern/ic_play_arrow.png
[add] https://crrev.com/c7356ebea488b13caaf2df57f93bf4b9cf9842f5/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/modern/ic_volume_off.png
[add] https://crrev.com/c7356ebea488b13caaf2df57f93bf4b9cf9842f5/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/modern/ic_volume_up.png
[add] https://crrev.com/c7356ebea488b13caaf2df57f93bf4b9cf9842f5/third_party/WebKit/Source/modules/media_controls/resources/default_200_percent/modern/ic_arrow_back.png
[add] https://crrev.com/c7356ebea488b13caaf2df57f93bf4b9cf9842f5/third_party/WebKit/Source/modules/media_controls/resources/default_200_percent/modern/ic_check_blue.png
[add] https://crrev.com/c7356ebea488b13caaf2df57f93bf4b9cf9842f5/third_party/WebKit/Source/modules/media_controls/resources/default_200_percent/modern/ic_fullscreen.png
[add] https://crrev.com/c7356ebea488b13caaf2df57f93bf4b9cf9842f5/third_party/WebKit/Source/modules/media_controls/resources/default_200_percent/modern/ic_fullscreen_exit.png
[add] https://crrev.com/c7356ebea488b13caaf2df57f93bf4b9cf9842f5/third_party/WebKit/Source/modules/media_controls/resources/default_200_percent/modern/ic_menu.png
[add] https://crrev.com/c7356ebea488b13caaf2df57f93bf4b9cf9842f5/third_party/WebKit/Source/modules/media_controls/resources/default_200_percent/modern/ic_pause.png
[add] https://crrev.com/c7356ebea488b13caaf2df57f93bf4b9cf9842f5/third_party/WebKit/Source/modules/media_controls/resources/default_200_percent/modern/ic_play_arrow.png
[add] https://crrev.com/c7356ebea488b13caaf2df57f93bf4b9cf9842f5/third_party/WebKit/Source/modules/media_controls/resources/default_200_percent/modern/ic_volume_off.png
[add] https://crrev.com/c7356ebea488b13caaf2df57f93bf4b9cf9842f5/third_party/WebKit/Source/modules/media_controls/resources/default_200_percent/modern/ic_volume_up.png
[delete] https://crrev.com/e223d5aee70a70447a67910b7c8315c6aad777af/third_party/WebKit/Source/modules/media_controls/resources/ic_arrow_back.svg
[delete] https://crrev.com/e223d5aee70a70447a67910b7c8315c6aad777af/third_party/WebKit/Source/modules/media_controls/resources/ic_cast_off.svg
[delete] https://crrev.com/e223d5aee70a70447a67910b7c8315c6aad777af/third_party/WebKit/Source/modules/media_controls/resources/ic_cast_on.svg
[delete] https://crrev.com/e223d5aee70a70447a67910b7c8315c6aad777af/third_party/WebKit/Source/modules/media_controls/resources/ic_check_blue.svg
[delete] https://crrev.com/e223d5aee70a70447a67910b7c8315c6aad777af/third_party/WebKit/Source/modules/media_controls/resources/ic_closed_caption.svg
[delete] https://crrev.com/e223d5aee70a70447a67910b7c8315c6aad777af/third_party/WebKit/Source/modules/media_controls/resources/ic_download.svg
[delete] https://crrev.com/e223d5aee70a70447a67910b7c8315c6aad777af/third_party/WebKit/Source/modules/media_controls/resources/ic_fullscreen.svg
[delete] https://crrev.com/e223d5aee70a70447a67910b7c8315c6aad777af/third_party/WebKit/Source/modules/media_controls/resources/ic_fullscreen_exit.svg
[delete] https://crrev.com/e223d5aee70a70447a67910b7c8315c6aad777af/third_party/WebKit/Source/modules/media_controls/resources/ic_menu.svg
[delete] https://crrev.com/e223d5aee70a70447a67910b7c8315c6aad777af/third_party/WebKit/Source/modules/media_controls/resources/ic_pause.svg
[delete] https://crrev.com/e223d5aee70a70447a67910b7c8315c6aad777af/third_party/WebKit/Source/modules/media_controls/resources/ic_play_arrow.svg
[delete] https://crrev.com/e223d5aee70a70447a67910b7c8315c6aad777af/third_party/WebKit/Source/modules/media_controls/resources/ic_volume_off.svg
[delete] https://crrev.com/e223d5aee70a70447a67910b7c8315c6aad777af/third_party/WebKit/Source/modules/media_controls/resources/ic_volume_up.svg
[modify] https://crrev.com/c7356ebea488b13caaf2df57f93bf4b9cf9842f5/third_party/WebKit/Source/modules/media_controls/resources/modernMediaControls.css

Comment 14 by beccahughes@chromium.org, Dec 12 2017

Status: Started (was: Verified)

Comment 15 by beccahughes@chromium.org, Dec 19 2017 

Just to clarify why that was reverted. Our leak detection in Blink checks the number of live resources, documents, etc. after a test has run and makes sure it is zero.

User agent resources live beyond a page so they are incorrectly picked up as leaks. For images this was fairly simple as we could just mark them as a user agent resource. SVGs are a little more complicated and create a bunch of resource types. We also only create the SVG resources when we use the image for the first time so we can't even predict how many resources we should have at the end.

We could move this to an inline <style> element which would dispose of the SVGs when the media controls are destroyed but that would break out -webkit-appearance: none; hack for backwards compatibility.

Comment 16 by beccahughes@chromium.org, Dec 19 2017

Cc: steimel@chromium.org

Comment 17 by beccahughes@chromium.org, Jan 2 2018

Status: Available (was: Started)

Comment 18 by beccahughes@chromium.org, Jan 5 2018

Owner: ----

Comment 19 by steimel@chromium.org, Mar 7 2018

Labels: -Pri-3 -M-65 M-67 Pri-2

Comment 20 by mlamouri@chromium.org, Mar 9 2018 

 Issue 761006  has been merged into this issue.

Comment 21 by beccahughes@chromium.org, Mar 12 2018

Cc: cfroussios@google.com
 Issue 794159  has been merged into this issue.

Comment 22 by beccahughes@chromium.org, Mar 20 2018

Owner: beccahughes@chromium.org
Status: Started (was: Available)

Comment 23 by cfroussios@chromium.org, Mar 21 2018

Cc: -cfroussios@google.com

Comment 24 by mlamouri@chromium.org, Mar 28 2018

Labels: -Pri-2 Pri-1
Project Member

Comment 25 by bugdroid1@chromium.org, Mar 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cc53890a252923a6ae35f968b998f8d1cf13d0a

commit 0cc53890a252923a6ae35f968b998f8d1cf13d0a
Author: Becca Hughes <beccahughes@chromium.org>
Date: Wed Mar 28 20:44:15 2018

Media Controls: Move new controls to SVG icons

Move the new media controls to SVG icons so they are no longer blurry in
some situations.

BUG= 788305 

Change-Id: I626f79917ddc9872ef4a5c5dbe3239a049cb7912
Reviewed-on: https://chromium-review.googlesource.com/970646
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546589}
[delete] https://crrev.com/d164667ac55dbd74167b1b8319876f779ce9cfba/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/modern/ic_arrow_back.png
[delete] https://crrev.com/d164667ac55dbd74167b1b8319876f779ce9cfba/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/modern/ic_check_blue.png
[delete] https://crrev.com/d164667ac55dbd74167b1b8319876f779ce9cfba/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/modern/ic_fullscreen.png
[delete] https://crrev.com/d164667ac55dbd74167b1b8319876f779ce9cfba/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/modern/ic_fullscreen_exit.png
[delete] https://crrev.com/d164667ac55dbd74167b1b8319876f779ce9cfba/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/modern/ic_fullscreen_exit_white.png
[delete] https://crrev.com/d164667ac55dbd74167b1b8319876f779ce9cfba/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/modern/ic_fullscreen_white.png
[delete] https://crrev.com/d164667ac55dbd74167b1b8319876f779ce9cfba/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/modern/ic_menu.png
[delete] https://crrev.com/d164667ac55dbd74167b1b8319876f779ce9cfba/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/modern/ic_menu_white.png
[delete] https://crrev.com/d164667ac55dbd74167b1b8319876f779ce9cfba/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/modern/ic_pause.png
[delete] https://crrev.com/d164667ac55dbd74167b1b8319876f779ce9cfba/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/modern/ic_pause_white.png
[delete] https://crrev.com/d164667ac55dbd74167b1b8319876f779ce9cfba/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/modern/ic_play_arrow.png
[delete] https://crrev.com/d164667ac55dbd74167b1b8319876f779ce9cfba/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/modern/ic_play_arrow_white.png
[delete] https://crrev.com/d164667ac55dbd74167b1b8319876f779ce9cfba/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/modern/ic_volume_off.png
[delete] https://crrev.com/d164667ac55dbd74167b1b8319876f779ce9cfba/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/modern/ic_volume_off_white.png
[delete] https://crrev.com/d164667ac55dbd74167b1b8319876f779ce9cfba/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/modern/ic_volume_up.png
[delete] https://crrev.com/d164667ac55dbd74167b1b8319876f779ce9cfba/third_party/WebKit/Source/modules/media_controls/resources/default_100_percent/modern/ic_volume_up_white.png
[delete] https://crrev.com/d164667ac55dbd74167b1b8319876f779ce9cfba/third_party/WebKit/Source/modules/media_controls/resources/default_200_percent/modern/ic_arrow_back.png
[delete] https://crrev.com/d164667ac55dbd74167b1b8319876f779ce9cfba/third_party/WebKit/Source/modules/media_controls/resources/default_200_percent/modern/ic_check_blue.png
[delete] https://crrev.com/d164667ac55dbd74167b1b8319876f779ce9cfba/third_party/WebKit/Source/modules/media_controls/resources/default_200_percent/modern/ic_fullscreen.png
[delete] https://crrev.com/d164667ac55dbd74167b1b8319876f779ce9cfba/third_party/WebKit/Source/modules/media_controls/resources/default_200_percent/modern/ic_fullscreen_exit.png
[delete] https://crrev.com/d164667ac55dbd74167b1b8319876f779ce9cfba/third_party/WebKit/Source/modules/media_controls/resources/default_200_percent/modern/ic_fullscreen_exit_white.png
[delete] https://crrev.com/d164667ac55dbd74167b1b8319876f779ce9cfba/third_party/WebKit/Source/modules/media_controls/resources/default_200_percent/modern/ic_fullscreen_white.png
[delete] https://crrev.com/d164667ac55dbd74167b1b8319876f779ce9cfba/third_party/WebKit/Source/modules/media_controls/resources/default_200_percent/modern/ic_menu.png
[delete] https://crrev.com/d164667ac55dbd74167b1b8319876f779ce9cfba/third_party/WebKit/Source/modules/media_controls/resources/default_200_percent/modern/ic_menu_white.png
[delete] https://crrev.com/d164667ac55dbd74167b1b8319876f779ce9cfba/third_party/WebKit/Source/modules/media_controls/resources/default_200_percent/modern/ic_pause.png
[delete] https://crrev.com/d164667ac55dbd74167b1b8319876f779ce9cfba/third_party/WebKit/Source/modules/media_controls/resources/default_200_percent/modern/ic_pause_white.png
[delete] https://crrev.com/d164667ac55dbd74167b1b8319876f779ce9cfba/third_party/WebKit/Source/modules/media_controls/resources/default_200_percent/modern/ic_play_arrow.png
[delete] https://crrev.com/d164667ac55dbd74167b1b8319876f779ce9cfba/third_party/WebKit/Source/modules/media_controls/resources/default_200_percent/modern/ic_play_arrow_white.png
[delete] https://crrev.com/d164667ac55dbd74167b1b8319876f779ce9cfba/third_party/WebKit/Source/modules/media_controls/resources/default_200_percent/modern/ic_volume_off.png
[delete] https://crrev.com/d164667ac55dbd74167b1b8319876f779ce9cfba/third_party/WebKit/Source/modules/media_controls/resources/default_200_percent/modern/ic_volume_off_white.png
[delete] https://crrev.com/d164667ac55dbd74167b1b8319876f779ce9cfba/third_party/WebKit/Source/modules/media_controls/resources/default_200_percent/modern/ic_volume_up.png
[delete] https://crrev.com/d164667ac55dbd74167b1b8319876f779ce9cfba/third_party/WebKit/Source/modules/media_controls/resources/default_200_percent/modern/ic_volume_up_white.png
[add] https://crrev.com/0cc53890a252923a6ae35f968b998f8d1cf13d0a/third_party/WebKit/Source/modules/media_controls/resources/ic_arrow_back.svg
[add] https://crrev.com/0cc53890a252923a6ae35f968b998f8d1cf13d0a/third_party/WebKit/Source/modules/media_controls/resources/ic_cast_off.svg
[add] https://crrev.com/0cc53890a252923a6ae35f968b998f8d1cf13d0a/third_party/WebKit/Source/modules/media_controls/resources/ic_cast_on.svg
[add] https://crrev.com/0cc53890a252923a6ae35f968b998f8d1cf13d0a/third_party/WebKit/Source/modules/media_controls/resources/ic_check_blue.svg
[add] https://crrev.com/0cc53890a252923a6ae35f968b998f8d1cf13d0a/third_party/WebKit/Source/modules/media_controls/resources/ic_closed_caption.svg
[add] https://crrev.com/0cc53890a252923a6ae35f968b998f8d1cf13d0a/third_party/WebKit/Source/modules/media_controls/resources/ic_download.svg
[add] https://crrev.com/0cc53890a252923a6ae35f968b998f8d1cf13d0a/third_party/WebKit/Source/modules/media_controls/resources/ic_fullscreen.svg
[add] https://crrev.com/0cc53890a252923a6ae35f968b998f8d1cf13d0a/third_party/WebKit/Source/modules/media_controls/resources/ic_fullscreen_exit.svg
[add] https://crrev.com/0cc53890a252923a6ae35f968b998f8d1cf13d0a/third_party/WebKit/Source/modules/media_controls/resources/ic_fullscreen_exit_white.svg
[add] https://crrev.com/0cc53890a252923a6ae35f968b998f8d1cf13d0a/third_party/WebKit/Source/modules/media_controls/resources/ic_fullscreen_white.svg
[add] https://crrev.com/0cc53890a252923a6ae35f968b998f8d1cf13d0a/third_party/WebKit/Source/modules/media_controls/resources/ic_menu.svg
[add] https://crrev.com/0cc53890a252923a6ae35f968b998f8d1cf13d0a/third_party/WebKit/Source/modules/media_controls/resources/ic_menu_white.svg
[add] https://crrev.com/0cc53890a252923a6ae35f968b998f8d1cf13d0a/third_party/WebKit/Source/modules/media_controls/resources/ic_pause.svg
[add] https://crrev.com/0cc53890a252923a6ae35f968b998f8d1cf13d0a/third_party/WebKit/Source/modules/media_controls/resources/ic_pause_white.svg
[add] https://crrev.com/0cc53890a252923a6ae35f968b998f8d1cf13d0a/third_party/WebKit/Source/modules/media_controls/resources/ic_play_arrow.svg
[add] https://crrev.com/0cc53890a252923a6ae35f968b998f8d1cf13d0a/third_party/WebKit/Source/modules/media_controls/resources/ic_play_arrow_white.svg
[add] https://crrev.com/0cc53890a252923a6ae35f968b998f8d1cf13d0a/third_party/WebKit/Source/modules/media_controls/resources/ic_volume_off.svg
[add] https://crrev.com/0cc53890a252923a6ae35f968b998f8d1cf13d0a/third_party/WebKit/Source/modules/media_controls/resources/ic_volume_off_white.svg
[add] https://crrev.com/0cc53890a252923a6ae35f968b998f8d1cf13d0a/third_party/WebKit/Source/modules/media_controls/resources/ic_volume_up.svg
[add] https://crrev.com/0cc53890a252923a6ae35f968b998f8d1cf13d0a/third_party/WebKit/Source/modules/media_controls/resources/ic_volume_up_white.svg
[modify] https://crrev.com/0cc53890a252923a6ae35f968b998f8d1cf13d0a/third_party/WebKit/Source/modules/media_controls/resources/modernMediaControls.css

Comment 26 by beccahughes@chromium.org, Mar 28 2018

Status: Fixed (was: Started)

Comment 27 by fbeaufort@chromium.org, Mar 29 2018 

It looks great. Thank you!
►

Sign in to add a comment