New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 788303 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: ----



Sign in to add a comment

ios_chrome_ui_egtests (iPhone 7 iOS 11.0) failing on chromium.mac/ios-simulator-full-configs

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Nov 24 2017

Issue description

ios_chrome_ui_egtests (iPhone 7 iOS 11.0) failing on chromium.mac/ios-simulator-full-configs

Builders failed on: 
- ios-simulator-full-configs: 
  https://build.chromium.org/p/chromium.mac/builders/ios-simulator-full-configs


 

Comment 1 by grt@chromium.org, Nov 24 2017

Labels: OS-iOS
Owner: sdefresne@chromium.org
Status: Assigned (was: Available)
First failure: https://build.chromium.org/p/chromium.mac/builders/ios-simulator-full-configs/builds/780

WebUITestCase/testChromeURLsLoadWithoutError:
[1123/121303.114291:FATAL:crw_web_ui_page_builder.mm(119)] Check failed: webUIHTML.

Maybe caused by r518975?

Comment 2 by grt@chromium.org, Nov 24 2017

Labels: -Sheriff-Chromium
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c4fc9b8a2599aecf75d53ff53f0d0b8d2fe69e0

commit 1c4fc9b8a2599aecf75d53ff53f0d0b8d2fe69e0
Author: Greg Thompson <grt@chromium.org>
Date: Fri Nov 24 09:58:22 2017

Disabling testChromeURLsLoadWithoutError due to failures.

BUG= 788303 
TBR=grt@chromium.org
NOTRY=true

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I3a93f68c78690845adf648044cf69ed0e9819241
Reviewed-on: https://chromium-review.googlesource.com/787899
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519076}
[modify] https://crrev.com/1c4fc9b8a2599aecf75d53ff53f0d0b8d2fe69e0/ios/chrome/browser/ui/webui/web_ui_egtest.mm

Owner: lod@chromium.org
=> lod (iOS sheriff)

Looks like unrelated to my CL that changes code for ios/web/shell which is not used by ios/chrome and not tested by the disabled test.
Cc: vadym@chromium.org
Components: UI>Browser>Passwords Tests>Disabled
lod: I think this is caused by https://chromium-review.googlesource.com/c/chromium/src/+/735479

The CL adds a new WebUI page (chrome://password-manager-internals). The test that is failing is iterating over all WebUI pages and try to load them one after the other. It is likely that the new page is not working correctly.

Can you check that reverting that the test pass if you revert https://chromium-review.googlesource.com/c/chromium/src/+/735479? If it does, then please revert the CL adding the new WebUI page and re-enable the test.

Comment 6 by vabr@chromium.org, Nov 24 2017

This is iPhone 7 specific (could reproduce locally with iPhone 7 but not 8).
dvadym@ is not available at the moment, I might have a look at fixing if I find time.

lod@ tells me that enabling the test is on the way.
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45383bf3eca02830d5e554cb389073f29f3f4eb8

commit 45383bf3eca02830d5e554cb389073f29f3f4eb8
Author: Elodie Banel <lod@chromium.org>
Date: Fri Nov 24 15:57:12 2017

Revert "Disabling testChromeURLsLoadWithoutError due to failures."

This reverts commit 1c4fc9b8a2599aecf75d53ff53f0d0b8d2fe69e0.

Reason for revert: Breaking code has been reverted.

Original change's description:
> Disabling testChromeURLsLoadWithoutError due to failures.
> 
> BUG= 788303 
> TBR=grt@chromium.org
> NOTRY=true
> 
> Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
> Change-Id: I3a93f68c78690845adf648044cf69ed0e9819241
> Reviewed-on: https://chromium-review.googlesource.com/787899
> Commit-Queue: Greg Thompson <grt@chromium.org>
> Reviewed-by: Greg Thompson <grt@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#519076}

TBR=grt@chromium.org

Change-Id: I513c1dcb03b1aad42e916fe7440cb8f0f5e36fd4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  788303 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/789310
Reviewed-by: Elodie Banel <lod@chromium.org>
Commit-Queue: Elodie Banel <lod@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519123}
[modify] https://crrev.com/45383bf3eca02830d5e554cb389073f29f3f4eb8/ios/chrome/browser/ui/webui/web_ui_egtest.mm

Status: Fixed (was: Assigned)

Comment 9 by grt@chromium.org, Nov 27 2017

Thanks for jumping on this one and resolving it so quickly!
Components: Tests>Disabled
Labels: Test-Disabled

Sign in to add a comment