New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 788302 link

Starred by 2 users
Status: Fixed
Owner:
mlamouri@chromium.org
Closed: Dec 2017
Cc:
beccahughes@chromium.org
█ dah...@chromium.org
isandrk@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

New Autoplay Policy changes should not apply to Chrome Apps

Project Member Reported by fbeaufort@chromium.org, Nov 24 2017 
Chrome Version       : 64.0.3274.0
OS Version: 10154.0.0

What steps will reproduce the problem?
1. Download a video
2. Play it with the Files App

What is the expected result?
The video should play

What happens instead of that?
The video is paused.

I believe Chrome Apps should be granted the "Autoplay" permission as user installed them.

Comment 1 by mlamouri@chromium.org, Nov 24 2017

Cc: -mlamouri@chromium.org dah...@chromium.org
Labels: -Pri-3 M-64 Pri-1
Owner: mlamouri@chromium.org
Status: Assigned (was: Unconfirmed)
I will have a look if I can find time today.

+dahlke@ because I think there might be another bug opened by the Chrome OS team.

Comment 2 by fbeaufort@chromium.org, Nov 27 2017 

Note that I've turned on the experimental flag: autoplay-policy=document-user-activation-required

Comment 3 by mlamouri@chromium.org, Dec 1 2017

Labels: -M-64 M-65
I can confirm that the issue happens on a ChromeBook Pixel but I can't reproduce it building Chrome OS for Linux. Though, I think it must be something related to how the profile data is read.

Comment 4 by mlamouri@chromium.org, Dec 1 2017

Cc: beccahughes@chromium.org
Status: Started (was: Assigned)
Taking the bug as I think I have a fix for this.

+beccahughes FYI

Comment 5 by mlamouri@chromium.org, Dec 5 2017 

Issue 772456 has been merged into this issue.

Comment 6 by isandrk@chromium.org, Dec 5 2017

Cc: isandrk@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ddcd5b21da8a2a38d52bd56e184e4432c1e55077

commit ddcd5b21da8a2a38d52bd56e184e4432c1e55077
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Wed Dec 13 11:53:25 2017

Autoplay: override autoplay restrictions on Chrome Apps/Extensions.

This is forcing no autoplay restrictions to all `Extensions`. It does
not apply to WebViews.

Bug:  788302 
Change-Id: I9c7e89133279453382976ff0f79d285672a5f1ac
Reviewed-on: https://chromium-review.googlesource.com/803440
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523747}
[modify] https://crrev.com/ddcd5b21da8a2a38d52bd56e184e4432c1e55077/chrome/browser/apps/guest_view/web_view_browsertest.cc
[add] https://crrev.com/ddcd5b21da8a2a38d52bd56e184e4432c1e55077/chrome/browser/extensions/autoplay_browsertest.cc
[modify] https://crrev.com/ddcd5b21da8a2a38d52bd56e184e4432c1e55077/chrome/browser/extensions/extension_webkit_preferences.cc
[modify] https://crrev.com/ddcd5b21da8a2a38d52bd56e184e4432c1e55077/chrome/test/BUILD.gn
[add] https://crrev.com/ddcd5b21da8a2a38d52bd56e184e4432c1e55077/chrome/test/data/extensions/autoplay/background.js
[add] https://crrev.com/ddcd5b21da8a2a38d52bd56e184e4432c1e55077/chrome/test/data/extensions/autoplay/manifest.json
[add] https://crrev.com/ddcd5b21da8a2a38d52bd56e184e4432c1e55077/chrome/test/data/extensions/platform_apps/web_view/autoplay/guest.html
[add] https://crrev.com/ddcd5b21da8a2a38d52bd56e184e4432c1e55077/chrome/test/data/extensions/platform_apps/web_view/autoplay/guest.js
[add] https://crrev.com/ddcd5b21da8a2a38d52bd56e184e4432c1e55077/chrome/test/data/extensions/platform_apps/web_view/autoplay/main.html
[add] https://crrev.com/ddcd5b21da8a2a38d52bd56e184e4432c1e55077/chrome/test/data/extensions/platform_apps/web_view/autoplay/main.js
[add] https://crrev.com/ddcd5b21da8a2a38d52bd56e184e4432c1e55077/chrome/test/data/extensions/platform_apps/web_view/autoplay/manifest.json
[add] https://crrev.com/ddcd5b21da8a2a38d52bd56e184e4432c1e55077/chrome/test/data/extensions/platform_apps/web_view/autoplay/test.js

Comment 8 by mlamouri@chromium.org, Dec 13 2017

Status: Fixed (was: Started)
►

Sign in to add a comment