Regression: View site info bubble does not load when cookies still loading.
Reported by
aiman.an...@etouch.net,
Nov 24 2017
|
||
Issue descriptionChrome Version: 64.0.3277.0 (Official Build) (cohort: Stable)64db0c41d5d476f76c9cb3d72fbc82e0f2a6d13e-refs/heads/master@{#519018} (32/64-bit) OS:Win(7,8,10), Mac(10.12.6, 10.13.2), Linux(14.04 LTS) Test URL: https://chrome.google.com/webstore/detail/colorzilla/bhlhnicpbhignbdhedgjhgdocnmhomnp Steps to reproduce: 1. Launch chrome, login to gmail with valid credentials and click on security chip in omnibox. 2. Observe. Actual Result: View site info bubble does not load when cookies still loading. Expected Result: View site info bubble should load when cookies still loading. This is regression issue broken in ‘M-61’ and and will soon update the bisect info. Using the per-revision bisect providing the bisect results, Good build: 60.0.3112.0(Revision:474898) Bad build: 61.0.3113.0(Revision:475195) You are probably looking for a change made after 475018 (known good), but no later than 475019 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/515337ad5ffce033fd8ee6498bf9ded54d564514..f582e25a561c090b75b0dc1c96f9d8136ad6991b Suspect: https://chromium.googlesource.com/chromium/src/+/f582e25a561c090b75b0dc1c96f9d8136ad6991b @ellyjones:Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thank You!
,
Dec 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab68fc91410e27fc7f02a7ad4ba408af759b3b34 commit ab68fc91410e27fc7f02a7ad4ba408af759b3b34 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Fri Dec 15 15:12:13 2017 views: only hide page info bubble on user navigations Otherwise, the page info bubble hides when an iframe on the page navigates, which happens dozens of times on some JS-heavy pages, or when the page navigates itself using a meta-refresh or similar. Bug: 788301 Change-Id: I10e4676bc3e0b4c688e5e435d243799a831c5bc3 Reviewed-on: https://chromium-review.googlesource.com/793230 Reviewed-by: Raymes Khoury <raymes@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#524383} [modify] https://crrev.com/ab68fc91410e27fc7f02a7ad4ba408af759b3b34/chrome/browser/ui/views/page_info/page_info_bubble_view_base.cc [modify] https://crrev.com/ab68fc91410e27fc7f02a7ad4ba408af759b3b34/chrome/browser/ui/views/page_info/page_info_bubble_view_browsertest.cc
,
Dec 15 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by patricia...@chromium.org
, Nov 29 2017