New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 788286 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Billing address is removed from a credit card after editing the card

Reported by xae...@yandex-team.ru, Nov 24 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

Steps to reproduce the problem:
1. Open https://googlechrome.github.io/samples/paymentrequest/credit-cards/ and press "Buy".
2. Add the card, or select existing, and assign a billing address to it.
3. Complete the payment.
4. Open chrome://settings/autofill
5. Edit the credit card in any way (e.g. change the cardholder's name).
6.  Open https://googlechrome.github.io/samples/paymentrequest/credit-cards/ press "Buy", and then select the payment. You will notice that there is no billing address associated with the card.

What is the expected behavior?
The edited credit card keeps its billing address assigned.

What went wrong?
The edited credit card loses the billing address assignment.

Did this work before? No 

Chrome version: 64.0.3277.0  Channel: canary
OS Version: 10.12
Flash Version: Shockwave Flash 27.0 r0
 

Comment 1 by meh...@chromium.org, Nov 25 2017

Components: -UI UI>Browser>Autofill

Comment 2 by se...@chromium.org, Nov 26 2017

Labels: -Pri-2 M-64 OS-Chrome OS-Linux OS-Windows Pri-1
Owner: se...@chromium.org
Status: Started (was: Unconfirmed)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70207eded2ac5604551f0294db1cada341007573

commit 70207eded2ac5604551f0294db1cada341007573
Author: Sebastien SG <sebsg@chromium.org>
Date: Mon Nov 27 13:24:01 2017

[Autofill] Preserve local card billing address when editing its settings

Since there is no possibility to set/add a billing address id to a local
card in the Autofill settings, the value was resort when a card was
edited.

This CL fixes the bug by preserving the billing address even if
the field is not editable in the settings, making sure the value set in
Payment Request is preserved.

Bug:  788286 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8ba282253ce48b0d13df77ebabd1cf3071dfa2f2
Reviewed-on: https://chromium-review.googlesource.com/789562
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519290}
[modify] https://crrev.com/70207eded2ac5604551f0294db1cada341007573/chrome/browser/extensions/api/autofill_private/autofill_private_api.cc
[modify] https://crrev.com/70207eded2ac5604551f0294db1cada341007573/chrome/browser/extensions/api/autofill_private/autofill_util.cc
[modify] https://crrev.com/70207eded2ac5604551f0294db1cada341007573/chrome/common/extensions/api/autofill_private.idl
[modify] https://crrev.com/70207eded2ac5604551f0294db1cada341007573/third_party/closure_compiler/externs/autofill_private.js

Comment 4 by se...@chromium.org, Nov 27 2017

Status: Fixed (was: Started)
Cc: ranjitkan@chromium.org
Labels: TE-Verified-64.0.3279.0 TE-Verified-M64
Rechecked the issue on Windows 10, Mac 10.12.6, Ubuntu 14.04 using chrome version# 64.0.3279.0 by following the steps mentioned in the issue description. Fix is working as intended as the edited Credit card details keeps the Billing address assigned.

Adding TE-Verified labels.

Thanks.!

Sign in to add a comment