ServiceWorkerContextTest.UnregisterMultiple failed on cl.exe bot |
|||
Issue descriptionhttps://build.chromium.org/p/chromium.fyi/builders/CrWinClexeGoma/builds/996 https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.fyi%2FCrWinClexeGoma%2F996%2F%2B%2Frecipes%2Fsteps%2Fcontent_unittests%2F0%2Flogs%2FServiceWorkerContextTest.UnregisterMultiple%2F0 [ RUN ] ServiceWorkerContextTest.UnregisterMultiple Received fatal exception EXCEPTION_ACCESS_VIOLATION Backtrace: content::ServiceWorkerContextCore::DidGetRegistrationsForDeleteForOrigin [0x017F5708+264] https://chromium.googlesource.com/chromium/src/+/816eedaf2af6529416fd2403255bad5ef7874f10
,
Nov 24 2017
ukai: What is a CrWinClexeGoma build? dullweber can you look at this? It's likely change in the bug description.
,
Nov 24 2017
ClWinClexeGoma is builder using cl.exe (msvc) intead of clang-cl.
,
Nov 24 2017
Thanks. FWIW I ran the test 100 times with Asan build on Linux and got no errors :(
,
Nov 24 2017
yeah, other bots looks ok. it might be a compiler specific bug. (i.e bug occurred only with cl.exe). (it runs test on swarming, so I guess it won't be a problem of test running machine..)
,
Nov 27 2017
There is also a crash report that looks very similar: https://crbug.com/788611. Is there a similar configuration on the try bots or a way to run ClWinClexeGoma with changes from a CL? I tried win-msvc-rel and win-msvc-dbg and they succeed. https://crrev.com/c/789837
,
Nov 27 2017
I was able to reproduce this locally and the crash was caused by accessing an object after moving it. Here is a fix: https://crbug.com/788277
,
Nov 28 2017
I think win-msvc-rel and win-msvc-dbg just compile, but not run any tests.
,
Nov 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/602312af7e474ebd072cacada31960890b60aa29 commit 602312af7e474ebd072cacada31960890b60aa29 Author: Christian Dullweber <dullweber@chromium.org> Date: Tue Nov 28 09:03:48 2017 Service Worker: Fix RegistrationDeletionListener crash. A ServiceWorkerRegistration was accessed after move. Bug: 788277 , 788611 Change-Id: Icd2a86f2273ccdd0fb4d0a902f8cff0086019410 Reviewed-on: https://chromium-review.googlesource.com/789888 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#519617} [modify] https://crrev.com/602312af7e474ebd072cacada31960890b60aa29/content/browser/service_worker/service_worker_context_core.cc
,
Nov 28 2017
CrWinClexeGoma is green again |
|||
►
Sign in to add a comment |
|||
Comment 1 by nhiroki@chromium.org
, Nov 24 2017