Originally skipped test remains skipped after factory_restart |
||||
Issue descriptionfactory repo: 633033c5451e859651a985ff2b076d9b79757b6f Steps to reproduce: 1. Remove a not yet run test from skipped_test. 2. Run factory_restart. (Or, run sync_factory_server to update to a toolkit that remove that test from skipped_test.) 3. That test would be still skipped. Probability to reproduce: Always
,
Nov 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/a509ad13c341a8cd82e01014420a1844c8735816 commit a509ad13c341a8cd82e01014420a1844c8735816 Author: Wei-Han Chen <stimim@google.com> Date: Mon Nov 27 06:51:51 2017 test list iterator: retest skipped test if its run_if is not set For runnable tests (parallel test, leaf test), if it was skipped by 'skipped_test' and it is removed from 'skipped_test', it won't be retested by current logic. Change the way we deal with run_if so this kind of test will be retested. BUG= chromium:788264 TEST=make test Change-Id: Id42f4931eb9dac0c3ba66aa5b9fd2d6037f1edd5 Reviewed-on: https://chromium-review.googlesource.com/788647 Commit-Ready: Wei-Han Chen <stimim@chromium.org> Tested-by: Youcheng Syu <youcheng@chromium.org> Tested-by: Wei-Han Chen <stimim@chromium.org> Reviewed-by: Youcheng Syu <youcheng@chromium.org> [modify] https://crrev.com/a509ad13c341a8cd82e01014420a1844c8735816/py/goofy/test_list_iterator_unittest.py [modify] https://crrev.com/a509ad13c341a8cd82e01014420a1844c8735816/py/goofy/test_list_iterator.py
,
Nov 27 2017
,
Jan 22 2018
,
Jan 23 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by stimim@chromium.org
, Nov 24 2017