MacViewsBrowser: Chrome menu "cut/copy/paste" commands do not work on the omnibox |
|||||||
Issue descriptionChrome Version : 64.0.3269.3 OS Version: OS X 10.12.6 In a `mac_views_browser = true` Chrome build What steps will reproduce the problem? 1. select some text in the omnibox 2. Chrome menu -> Cut 3. Chrome menu -> Paste What is the expected result? Text in the omnibox should be cut/pasted. What happens instead of that? It isn't. `Edit` in the menu bar works fine. So does the right-click context menu. Just not the Chrome "App"/hotdog menu. I'm changing some stuff around accelerators for Issue 773565 (http://crrev.com/c/788632), but this is a pre-existing issue in mac_views_browser.
,
Mar 26 2018
,
Mar 27 2018
,
Mar 27 2018
Initial finding: No accelerator handled the Cut/Copy/Paste.
,
Mar 27 2018
Likely Regressing CL: https://chromium.googlesource.com/chromium/src/+/a8d23c3e4f19bf3bd7b652c5cb2a38bf608e51cc Going through the Mac edit menu however does work fine. The fix here might involve wiring up the Chrome menu to the Mac menu.
,
Mar 27 2018
Confirmed adding those accelerators back in (with the proper modifier key) fixes the issue.
,
Mar 27 2018
,
Mar 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fae152cc908337b9584d256c4f466e9f64dbd481 commit fae152cc908337b9584d256c4f466e9f64dbd481 Author: Robert Liao <robliao@chromium.org> Date: Thu Mar 29 02:50:34 2018 Forward BrowserView::CutCopyPaste to the NSApp http://crbug.com/773565 removed accelerators for textfields, breaking Cut, Copy, and Paste in the Chrome Menu. This fix forwards those calls to NSApp. BUG= 788262 Change-Id: I70adfe270dd672961ca04bc0e4a9ab498e7f2944 Reviewed-on: https://chromium-review.googlesource.com/984346 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#546712} [modify] https://crrev.com/fae152cc908337b9584d256c4f466e9f64dbd481/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/fae152cc908337b9584d256c4f466e9f64dbd481/chrome/browser/ui/views/frame/browser_view.cc [add] https://crrev.com/fae152cc908337b9584d256c4f466e9f64dbd481/chrome/browser/ui/views/frame/browser_view_commands_mac.h [add] https://crrev.com/fae152cc908337b9584d256c4f466e9f64dbd481/chrome/browser/ui/views/frame/browser_view_commands_mac.mm
,
Mar 29 2018
Is anything pending or this can be marked as fixed?
,
Mar 29 2018
,
Apr 2 2018
Verified the fix on Mac 10.12.6 using Chrome version #67.0.3386.0 as per the comment #0. Attaching screen cast for reference. Observed that "cut/copy/paste" commands are working properly. Hence, the fix is working as expected. Adding the verified labels. Note: Able to reproduce the issue on reported chrome version 64.0.3269.3 Thanks...!! |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by ellyjo...@chromium.org
, Mar 26 2018Owner: robliao@chromium.org
Status: Assigned (was: Available)