desktop-pwas: Clarify what is means for a WebContents to be an “app WebContents” |
|
Issue descriptionAlso, clearly define when a WebContents is an “app WebContents”. Currently, it's not clear what calling extensions::TabHelper::SetExtensionApp() means for that WebContents. The docs mention that calling it means the "tab becomes an app-tab" and extensions::TabHelper::is_app() returns true. But it's not clear what that means. Once it's clear when is_app() returns true we can use it to make decisions about the WebContents without having to retrieve the browser associated with it e.g. is the current navigation in a Hosted App?
,
Nov 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f379af2b74a85c5bb4fed81d890a859f61699971 commit f379af2b74a85c5bb4fed81d890a859f61699971 Author: Giovanni Ortuño Urquidi <ortuno@chromium.org> Date: Fri Nov 24 03:16:35 2017 extensions: Remove two unused methods from TabHelper Removes two methods to set the icon in TabHelper. These methods have no users and make it harder to reason about what icon is associated with the WebContents. Bug: 788254 Change-Id: If51826eb8f19b24e7c8ab9f4643cb0d782c88006 Reviewed-on: https://chromium-review.googlesource.com/788489 Reviewed-by: calamity <calamity@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#519050} [modify] https://crrev.com/f379af2b74a85c5bb4fed81d890a859f61699971/chrome/browser/extensions/tab_helper.cc [modify] https://crrev.com/f379af2b74a85c5bb4fed81d890a859f61699971/chrome/browser/extensions/tab_helper.h |
|
►
Sign in to add a comment |
|
Comment 1 by ortuno@chromium.org
, Nov 24 2017