New issue
Advanced search Search tips

Issue 788246 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug

Blocking:
issue 62400



Sign in to add a comment

Abrt in CXFA_WidgetData::GetUIMargin

Project Member Reported by ClusterFuzz, Nov 24 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5391113228910592

Fuzzer: libFuzzer_pdfium_xfa_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Abrt
Crash Address: 0x03e900007328
Crash State:
  CXFA_WidgetData::GetUIMargin
  CXFA_FFField::CapLeftRightPlacement
  CXFA_FFField::CapPlacement
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=518357:518408

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5391113228910592

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Nov 24 2017

Components: Internals>Plugins>PDF
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Cc: kkaluri@chromium.org
Labels: M-64
Owner: dsinclair@chromium.org
Status: Assigned (was: Untriaged)
Predator has provided 4 Possible suspects

* Make CXFA_MarginData::Try* methods return Optional by dsinclair@chromium.org
* Add CXFA_MarginData::Get*Inset helpers by dsinclair@chromium.org
* Rename CXFA_DataData::TryMeasure by dsinclair@chromium.org
* Convert CXFA_WidgetData methods to Optional by dsinclair@chromium.org

Suspect CL: https://pdfium.googlesource.com/pdfium/+/ddc9965f60823a63c1d402e2f35e7ce093bf3ee8

dsinclair@ -- Could you please look into this issue, kindly reassign if it has nothing to do with your changes.

Blocking: 62400
Labels: -M-64
Status: Started (was: Assigned)
Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/99acb1c816dc88dbda5d03ef28dbdaa928f7e22a

commit 99acb1c816dc88dbda5d03ef28dbdaa928f7e22a
Author: Dan Sinclair <dsinclair@chromium.org>
Date: Tue Nov 28 17:15:48 2017

[XFA] Use default values to optionals

When accessing the margin data for a widget, the Inset values can come
back as empty optionals. Those would only get values if there was a
border data node present. If there is no border data node, we need to
default the optional value.

Bug:  chromium:788246 
Change-Id: Id3d5b76e8dc9d391aaa0d0440bf6ee2e2636fcdc
Reviewed-on: https://pdfium-review.googlesource.com/19671
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>

[modify] https://crrev.com/99acb1c816dc88dbda5d03ef28dbdaa928f7e22a/xfa/fxfa/parser/cxfa_widgetdata.cpp

Project Member

Comment 7 by ClusterFuzz, Nov 29 2017

ClusterFuzz has detected this issue as fixed in range 519747:519798.

Detailed report: https://clusterfuzz.com/testcase?key=5391113228910592

Fuzzer: libFuzzer_pdfium_xfa_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Abrt
Crash Address: 0x03e900007328
Crash State:
  CXFA_WidgetData::GetUIMargin
  CXFA_FFField::CapLeftRightPlacement
  CXFA_FFField::CapPlacement
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=518357:518408
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=519747:519798

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5391113228910592

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Nov 29 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5391113228910592 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment