We will delete the old code path in Dec 2017.
Can we prioritize removing the virtual layout tests for mojo-loading? Each time sheriffs/bot maintainers need to disable tests, it need to be duplicated for mojo-loading.
Sure!
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/491e311c3a78192830126f0679d1481591185d24 commit 491e311c3a78192830126f0679d1481591185d24 Author: Yutaka Hirano <yhirano@chromium.org> Date: Mon Dec 04 07:34:32 2017 Remove mojo-loading virtual test suite As we have launched LoadingWithMojo, the virtual test suite is no longer needed. Bug: 603396 , 788241 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_mojo Change-Id: Id40b27d02de03d3880076c53283527c5fed7a294 Reviewed-on: https://chromium-review.googlesource.com/805175 Reviewed-by: Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#521285} [modify] https://crrev.com/491e311c3a78192830126f0679d1481591185d24/third_party/WebKit/LayoutTests/ASANExpectations [modify] https://crrev.com/491e311c3a78192830126f0679d1481591185d24/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG [modify] https://crrev.com/491e311c3a78192830126f0679d1481591185d24/third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation [modify] https://crrev.com/491e311c3a78192830126f0679d1481591185d24/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService [modify] https://crrev.com/491e311c3a78192830126f0679d1481591185d24/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 [modify] https://crrev.com/491e311c3a78192830126f0679d1481591185d24/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls [modify] https://crrev.com/491e311c3a78192830126f0679d1481591185d24/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process [modify] https://crrev.com/491e311c3a78192830126f0679d1481591185d24/third_party/WebKit/LayoutTests/LeakExpectations [modify] https://crrev.com/491e311c3a78192830126f0679d1481591185d24/third_party/WebKit/LayoutTests/MSANExpectations [modify] https://crrev.com/491e311c3a78192830126f0679d1481591185d24/third_party/WebKit/LayoutTests/NeverFixTests [modify] https://crrev.com/491e311c3a78192830126f0679d1481591185d24/third_party/WebKit/LayoutTests/SlowTests [modify] https://crrev.com/491e311c3a78192830126f0679d1481591185d24/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/491e311c3a78192830126f0679d1481591185d24/third_party/WebKit/LayoutTests/VirtualTestSuites [delete] https://crrev.com/6e1a1cdba89e456c7a3236f3ddd12983c7b211bf/third_party/WebKit/LayoutTests/virtual/mojo-loading/css1/README.txt [delete] https://crrev.com/6e1a1cdba89e456c7a3236f3ddd12983c7b211bf/third_party/WebKit/LayoutTests/virtual/mojo-loading/fast/table/README.txt [delete] https://crrev.com/6e1a1cdba89e456c7a3236f3ddd12983c7b211bf/third_party/WebKit/LayoutTests/virtual/mojo-loading/http/tests/README.txt [delete] https://crrev.com/6e1a1cdba89e456c7a3236f3ddd12983c7b211bf/third_party/WebKit/LayoutTests/virtual/mojo-loading/http/tests/devtools/sources/debugger-ui/source-frame-count-expected.txt [delete] https://crrev.com/6e1a1cdba89e456c7a3236f3ddd12983c7b211bf/third_party/WebKit/LayoutTests/virtual/mojo-loading/http/tests/images/gif-animated-partial-load-expected.png [delete] https://crrev.com/6e1a1cdba89e456c7a3236f3ddd12983c7b211bf/third_party/WebKit/LayoutTests/virtual/mojo-loading/http/tests/performance-timing/longtask-v2/README.txt [delete] https://crrev.com/6e1a1cdba89e456c7a3236f3ddd12983c7b211bf/third_party/WebKit/LayoutTests/virtual/mojo-loading/webexposed/README.txt
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8193e8706e41d61289bd44a7242eb7fc98731e6e commit 8193e8706e41d61289bd44a7242eb7fc98731e6e Author: Yutaka Hirano <yhirano@chromium.org> Date: Tue Dec 12 06:44:23 2017 Remove content_features::kLoadingWithMojo This change removes the feature as we've launched it. Bug: 788241 , 603396 Change-Id: If651428dd301b4393570a05e7a20499e95f7ed7b Reviewed-on: https://chromium-review.googlesource.com/818597 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#523359} [modify] https://crrev.com/8193e8706e41d61289bd44a7242eb7fc98731e6e/android_webview/lib/aw_main_delegate.cc [modify] https://crrev.com/8193e8706e41d61289bd44a7242eb7fc98731e6e/chrome/browser/about_flags.cc [modify] https://crrev.com/8193e8706e41d61289bd44a7242eb7fc98731e6e/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/8193e8706e41d61289bd44a7242eb7fc98731e6e/chrome/browser/flag_descriptions.h [modify] https://crrev.com/8193e8706e41d61289bd44a7242eb7fc98731e6e/content/browser/cross_site_transfer_browsertest.cc [modify] https://crrev.com/8193e8706e41d61289bd44a7242eb7fc98731e6e/content/browser/loader/async_resource_handler_browsertest.cc [modify] https://crrev.com/8193e8706e41d61289bd44a7242eb7fc98731e6e/content/child/runtime_features.cc [modify] https://crrev.com/8193e8706e41d61289bd44a7242eb7fc98731e6e/content/public/common/content_features.cc [modify] https://crrev.com/8193e8706e41d61289bd44a7242eb7fc98731e6e/content/public/common/content_features.h [modify] https://crrev.com/8193e8706e41d61289bd44a7242eb7fc98731e6e/content/renderer/loader/site_isolation_stats_gatherer_browsertest.cc [modify] https://crrev.com/8193e8706e41d61289bd44a7242eb7fc98731e6e/content/renderer/loader/web_url_loader_impl.cc [modify] https://crrev.com/8193e8706e41d61289bd44a7242eb7fc98731e6e/testing/variations/fieldtrial_testing_config.json [modify] https://crrev.com/8193e8706e41d61289bd44a7242eb7fc98731e6e/third_party/WebKit/Source/platform/exported/WebRuntimeFeatures.cpp [modify] https://crrev.com/8193e8706e41d61289bd44a7242eb7fc98731e6e/third_party/WebKit/public/platform/WebRuntimeFeatures.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2490056b35eafc16d207791f6ad23ba1bc434460 commit 2490056b35eafc16d207791f6ad23ba1bc434460 Author: Reilly Grant <reillyg@chromium.org> Date: Tue Dec 12 18:54:21 2017 Update filter for tests that are no longer parameterized With the removal of kLoadingWithMojo some tests are no longer parameterized and so the test filters need to be updated. Bug: 788241 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: If11985aff0e666304e8649515ebdb0eede761d8d No-Try: true No-Presubmit: true No-Tree-Checks: true Tbr: jam@chromium.org Reviewed-on: https://chromium-review.googlesource.com/823076 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#523493} [modify] https://crrev.com/2490056b35eafc16d207791f6ad23ba1bc434460/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/51fa0ebf570902e098876c2884c3d378f0df569e commit 51fa0ebf570902e098876c2884c3d378f0df569e Author: Yutaka Hirano <yhirano@chromium.org> Date: Thu Dec 14 00:43:55 2017 Migrate ResourceDispatcherHost unittests to MojoLoading As a preparation step to deprecate resource_messages.h, this change migrates ResourceDispatcherHostTest to LoadingWithMojo. This change also removes some tests that are no longer needed. Bug: 788241 Change-Id: I04ca5649fd621404a177d9c2571384a00a0d7741 Reviewed-on: https://chromium-review.googlesource.com/818925 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#523957} [modify] https://crrev.com/51fa0ebf570902e098876c2884c3d378f0df569e/content/browser/loader/resource_dispatcher_host_unittest.cc [modify] https://crrev.com/51fa0ebf570902e098876c2884c3d378f0df569e/content/public/test/test_url_loader_client.cc [modify] https://crrev.com/51fa0ebf570902e098876c2884c3d378f0df569e/content/public/test/test_url_loader_client.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3dad2835bcb87db92086ea0d5e431b56c36479b2 commit 3dad2835bcb87db92086ea0d5e431b56c36479b2 Author: Yutaka Hirano <yhirano@chromium.org> Date: Thu Dec 14 06:48:16 2017 Remove IPC::Message usages from content::URLLoaderClientImpl We've been using IPC::Message in URLLoaderClientImpl to implement the "deferred loading" feature. This CL replaces it with custom containers having callback parameters, in order to remove IPC messages defined in resources_messages.h. Bug: 788241 Change-Id: I3b5863aa2604c2f3d56c3c0481d88ef865f91b28 Reviewed-on: https://chromium-review.googlesource.com/826882 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#524013} [modify] https://crrev.com/3dad2835bcb87db92086ea0d5e431b56c36479b2/content/renderer/loader/url_loader_client_impl.cc [modify] https://crrev.com/3dad2835bcb87db92086ea0d5e431b56c36479b2/content/renderer/loader/url_loader_client_impl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12c224a1d2b5d78308fd5fd90acd5c43697ac0b6 commit 12c224a1d2b5d78308fd5fd90acd5c43697ac0b6 Author: Yutaka Hirano <yhirano@chromium.org> Date: Tue Dec 19 06:12:35 2017 Use mojo-fied loading IPCs in SecurityExploitBrowserTest In order to delete messages defined in resource_messages.h, this CL replaces such messages in SecurityExploitBrowserTest with mojo messages. Bug: 788241 Change-Id: I05c66ed5cbfd42e6335c011643c91cf1d5b77dee Reviewed-on: https://chromium-review.googlesource.com/831769 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#524952} [modify] https://crrev.com/12c224a1d2b5d78308fd5fd90acd5c43697ac0b6/content/browser/renderer_host/render_process_host_impl.h [modify] https://crrev.com/12c224a1d2b5d78308fd5fd90acd5c43697ac0b6/content/browser/security_exploit_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56ddd0320acc76ba78ff650852b77a8ff8981617 commit 56ddd0320acc76ba78ff650852b77a8ff8981617 Author: Yutaka Hirano <yhirano@chromium.org> Date: Fri Dec 22 06:05:39 2017 [mojo-loading] Remove ChromeIPC code This CL removes all ChromeIPC messages defined in resource_messages.h. The removed code include: - components having counterparts in mojo-loading: - async_resource_handler - sync_resource_handler - components implementing features we are no longer using: - resource_message_delegate - child_resource_message_filter - resource_scheduling_filter - shared_memory_received_data_factory - resource_dispatch_throttler - messages defined in resource_messages.h - a bunch of branches Bug: 788241 Change-Id: I90a95163eb44bd7c34136d28db5d2625204f6f5c Reviewed-on: https://chromium-review.googlesource.com/821796 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#525943} [modify] https://crrev.com/56ddd0320acc76ba78ff650852b77a8ff8981617/content/browser/BUILD.gn [delete] https://crrev.com/2e98e2760d8d3e2ede98392b632c8b2d08938220/content/browser/loader/async_resource_handler.cc [delete] https://crrev.com/2e98e2760d8d3e2ede98392b632c8b2d08938220/content/browser/loader/async_resource_handler.h [delete] https://crrev.com/2e98e2760d8d3e2ede98392b632c8b2d08938220/content/browser/loader/async_resource_handler_browsertest.cc [delete] https://crrev.com/2e98e2760d8d3e2ede98392b632c8b2d08938220/content/browser/loader/async_resource_handler_unittest.cc [modify] https://crrev.com/56ddd0320acc76ba78ff650852b77a8ff8981617/content/browser/loader/resource_dispatcher_host_impl.cc [modify] https://crrev.com/56ddd0320acc76ba78ff650852b77a8ff8981617/content/browser/loader/resource_dispatcher_host_impl.h [modify] https://crrev.com/56ddd0320acc76ba78ff650852b77a8ff8981617/content/browser/loader/resource_loader_unittest.cc [delete] https://crrev.com/2e98e2760d8d3e2ede98392b632c8b2d08938220/content/browser/loader/resource_message_delegate.cc [delete] https://crrev.com/2e98e2760d8d3e2ede98392b632c8b2d08938220/content/browser/loader/resource_message_delegate.h [modify] https://crrev.com/56ddd0320acc76ba78ff650852b77a8ff8981617/content/browser/loader/resource_message_filter.cc [delete] https://crrev.com/2e98e2760d8d3e2ede98392b632c8b2d08938220/content/browser/loader/sync_resource_handler.cc [delete] https://crrev.com/2e98e2760d8d3e2ede98392b632c8b2d08938220/content/browser/loader/sync_resource_handler.h [modify] https://crrev.com/56ddd0320acc76ba78ff650852b77a8ff8981617/content/common/resource_messages.h [modify] https://crrev.com/56ddd0320acc76ba78ff650852b77a8ff8981617/content/renderer/BUILD.gn [delete] https://crrev.com/2e98e2760d8d3e2ede98392b632c8b2d08938220/content/renderer/loader/child_resource_message_filter.cc [delete] https://crrev.com/2e98e2760d8d3e2ede98392b632c8b2d08938220/content/renderer/loader/child_resource_message_filter.h [modify] https://crrev.com/56ddd0320acc76ba78ff650852b77a8ff8981617/content/renderer/loader/request_extra_data.cc [modify] https://crrev.com/56ddd0320acc76ba78ff650852b77a8ff8981617/content/renderer/loader/resource_dispatcher.cc [modify] https://crrev.com/56ddd0320acc76ba78ff650852b77a8ff8981617/content/renderer/loader/resource_dispatcher.h [modify] https://crrev.com/56ddd0320acc76ba78ff650852b77a8ff8981617/content/renderer/loader/resource_dispatcher_unittest.cc [delete] https://crrev.com/2e98e2760d8d3e2ede98392b632c8b2d08938220/content/renderer/loader/resource_scheduling_filter.cc [delete] https://crrev.com/2e98e2760d8d3e2ede98392b632c8b2d08938220/content/renderer/loader/resource_scheduling_filter.h [delete] https://crrev.com/2e98e2760d8d3e2ede98392b632c8b2d08938220/content/renderer/loader/shared_memory_received_data_factory.cc [delete] https://crrev.com/2e98e2760d8d3e2ede98392b632c8b2d08938220/content/renderer/loader/shared_memory_received_data_factory.h [delete] https://crrev.com/2e98e2760d8d3e2ede98392b632c8b2d08938220/content/renderer/loader/shared_memory_received_data_factory_unittest.cc [modify] https://crrev.com/56ddd0320acc76ba78ff650852b77a8ff8981617/content/renderer/loader/sync_load_context.cc [modify] https://crrev.com/56ddd0320acc76ba78ff650852b77a8ff8981617/content/renderer/loader/url_loader_client_impl.cc [modify] https://crrev.com/56ddd0320acc76ba78ff650852b77a8ff8981617/content/renderer/loader/url_loader_client_impl_unittest.cc [modify] https://crrev.com/56ddd0320acc76ba78ff650852b77a8ff8981617/content/renderer/loader/url_response_body_consumer.cc [modify] https://crrev.com/56ddd0320acc76ba78ff650852b77a8ff8981617/content/renderer/loader/url_response_body_consumer_unittest.cc [modify] https://crrev.com/56ddd0320acc76ba78ff650852b77a8ff8981617/content/renderer/loader/web_url_loader_impl.cc [modify] https://crrev.com/56ddd0320acc76ba78ff650852b77a8ff8981617/content/renderer/loader/web_url_loader_impl_unittest.cc [modify] https://crrev.com/56ddd0320acc76ba78ff650852b77a8ff8981617/content/renderer/render_thread_impl.cc [modify] https://crrev.com/56ddd0320acc76ba78ff650852b77a8ff8981617/content/renderer/render_thread_impl.h [modify] https://crrev.com/56ddd0320acc76ba78ff650852b77a8ff8981617/content/renderer/render_thread_impl_browsertest.cc [delete] https://crrev.com/2e98e2760d8d3e2ede98392b632c8b2d08938220/content/renderer/scheduler/resource_dispatch_throttler.cc [delete] https://crrev.com/2e98e2760d8d3e2ede98392b632c8b2d08938220/content/renderer/scheduler/resource_dispatch_throttler.h [delete] https://crrev.com/2e98e2760d8d3e2ede98392b632c8b2d08938220/content/renderer/scheduler/resource_dispatch_throttler_unittest.cc [modify] https://crrev.com/56ddd0320acc76ba78ff650852b77a8ff8981617/content/renderer/service_worker/service_worker_fetch_context_impl.cc [modify] https://crrev.com/56ddd0320acc76ba78ff650852b77a8ff8981617/content/renderer/service_worker/worker_fetch_context_impl.cc [modify] https://crrev.com/56ddd0320acc76ba78ff650852b77a8ff8981617/content/test/BUILD.gn [modify] https://crrev.com/56ddd0320acc76ba78ff650852b77a8ff8981617/third_party/WebKit/Source/core/loader/WorkerFetchContext.cpp [modify] https://crrev.com/56ddd0320acc76ba78ff650852b77a8ff8981617/third_party/WebKit/Source/platform/exported/WebURLRequest.cpp [modify] https://crrev.com/56ddd0320acc76ba78ff650852b77a8ff8981617/third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.cpp [modify] https://crrev.com/56ddd0320acc76ba78ff650852b77a8ff8981617/third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.h [modify] https://crrev.com/56ddd0320acc76ba78ff650852b77a8ff8981617/third_party/WebKit/public/platform/WebURLRequest.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73765eea7390f0cd038191396c9df4535ad48581 commit 73765eea7390f0cd038191396c9df4535ad48581 Author: Marijn Kruisselbrink <mek@chromium.org> Date: Fri Dec 22 22:33:02 2017 Revert "[mojo-loading] Remove ChromeIPC code" This reverts commit 56ddd0320acc76ba78ff650852b77a8ff8981617. Reason for revert: looks like it might be causing crashes in syncxhr Several synxhr tests started crashing somewhat regularly after this landed (see bug for details), reverting to see if this change is actually to blame. Original change's description: > [mojo-loading] Remove ChromeIPC code > > This CL removes all ChromeIPC messages defined in resource_messages.h. > The removed code include: > > - components having counterparts in mojo-loading: > - async_resource_handler > - sync_resource_handler > - components implementing features we are no longer using: > - resource_message_delegate > - child_resource_message_filter > - resource_scheduling_filter > - shared_memory_received_data_factory > - resource_dispatch_throttler > - messages defined in resource_messages.h > - a bunch of branches > > Bug: 788241 > Change-Id: I90a95163eb44bd7c34136d28db5d2625204f6f5c > Reviewed-on: https://chromium-review.googlesource.com/821796 > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#525943} TBR=dcheng@chromium.org,kinuko@chromium.org,yhirano@chromium.org Change-Id: I4a93fc6ad418a26ce646523b9c366512f32cce10 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 788241 , 797374 Reviewed-on: https://chromium-review.googlesource.com/842226 Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#526074} [modify] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/browser/BUILD.gn [add] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/browser/loader/async_resource_handler.cc [add] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/browser/loader/async_resource_handler.h [add] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/browser/loader/async_resource_handler_browsertest.cc [add] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/browser/loader/async_resource_handler_unittest.cc [modify] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/browser/loader/resource_dispatcher_host_impl.cc [modify] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/browser/loader/resource_dispatcher_host_impl.h [modify] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/browser/loader/resource_loader_unittest.cc [add] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/browser/loader/resource_message_delegate.cc [add] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/browser/loader/resource_message_delegate.h [modify] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/browser/loader/resource_message_filter.cc [add] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/browser/loader/sync_resource_handler.cc [add] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/browser/loader/sync_resource_handler.h [modify] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/common/resource_messages.h [modify] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/renderer/BUILD.gn [add] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/renderer/loader/child_resource_message_filter.cc [add] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/renderer/loader/child_resource_message_filter.h [modify] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/renderer/loader/request_extra_data.cc [modify] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/renderer/loader/resource_dispatcher.cc [modify] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/renderer/loader/resource_dispatcher.h [modify] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/renderer/loader/resource_dispatcher_unittest.cc [add] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/renderer/loader/resource_scheduling_filter.cc [add] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/renderer/loader/resource_scheduling_filter.h [add] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/renderer/loader/shared_memory_received_data_factory.cc [add] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/renderer/loader/shared_memory_received_data_factory.h [add] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/renderer/loader/shared_memory_received_data_factory_unittest.cc [modify] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/renderer/loader/sync_load_context.cc [modify] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/renderer/loader/url_loader_client_impl.cc [modify] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/renderer/loader/url_loader_client_impl_unittest.cc [modify] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/renderer/loader/url_response_body_consumer.cc [modify] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/renderer/loader/url_response_body_consumer_unittest.cc [modify] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/renderer/loader/web_url_loader_impl.cc [modify] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/renderer/loader/web_url_loader_impl_unittest.cc [modify] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/renderer/render_thread_impl.cc [modify] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/renderer/render_thread_impl.h [modify] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/renderer/render_thread_impl_browsertest.cc [add] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/renderer/scheduler/resource_dispatch_throttler.cc [add] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/renderer/scheduler/resource_dispatch_throttler.h [add] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/renderer/scheduler/resource_dispatch_throttler_unittest.cc [modify] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/renderer/service_worker/service_worker_fetch_context_impl.cc [modify] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/renderer/service_worker/worker_fetch_context_impl.cc [modify] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/content/test/BUILD.gn [modify] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/third_party/WebKit/Source/core/loader/WorkerFetchContext.cpp [modify] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/third_party/WebKit/Source/platform/exported/WebURLRequest.cpp [modify] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.cpp [modify] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.h [modify] https://crrev.com/73765eea7390f0cd038191396c9df4535ad48581/third_party/WebKit/public/platform/WebURLRequest.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99ab0e0a3bfbaeed167be404db5fcb070bfc82a4 commit 99ab0e0a3bfbaeed167be404db5fcb070bfc82a4 Author: Yutaka Hirano <yhirano@chromium.org> Date: Mon Dec 25 02:36:41 2017 Revert "Revert "[mojo-loading] Remove ChromeIPC code"" This reverts commit 73765eea7390f0cd038191396c9df4535ad48581. Reason for revert: The original change looks innocent for the failure. Original change's description: > Revert "[mojo-loading] Remove ChromeIPC code" > > This reverts commit 56ddd0320acc76ba78ff650852b77a8ff8981617. > > Reason for revert: looks like it might be causing crashes in syncxhr > > Several synxhr tests started crashing somewhat regularly after this landed (see bug for details), reverting to see if this change is actually to blame. > > Original change's description: > > [mojo-loading] Remove ChromeIPC code > > > > This CL removes all ChromeIPC messages defined in resource_messages.h. > > The removed code include: > > > > - components having counterparts in mojo-loading: > > - async_resource_handler > > - sync_resource_handler > > - components implementing features we are no longer using: > > - resource_message_delegate > > - child_resource_message_filter > > - resource_scheduling_filter > > - shared_memory_received_data_factory > > - resource_dispatch_throttler > > - messages defined in resource_messages.h > > - a bunch of branches > > > > Bug: 788241 > > Change-Id: I90a95163eb44bd7c34136d28db5d2625204f6f5c > > Reviewed-on: https://chromium-review.googlesource.com/821796 > > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#525943} > > TBR=dcheng@chromium.org,kinuko@chromium.org,yhirano@chromium.org > > Change-Id: I4a93fc6ad418a26ce646523b9c366512f32cce10 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 788241 , 797374 > Reviewed-on: https://chromium-review.googlesource.com/842226 > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#526074} TBR=dcheng@chromium.org,kinuko@chromium.org,mek@chromium.org,yhirano@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 788241 , 797374 Change-Id: Ib58215e11567a68a3167a3a641da0e4385c052bd Reviewed-on: https://chromium-review.googlesource.com/844175 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#526165} [modify] https://crrev.com/99ab0e0a3bfbaeed167be404db5fcb070bfc82a4/content/browser/BUILD.gn [delete] https://crrev.com/504fd2e8f347bf20638cce9f80ebf065ad017a73/content/browser/loader/async_resource_handler.cc [delete] https://crrev.com/504fd2e8f347bf20638cce9f80ebf065ad017a73/content/browser/loader/async_resource_handler.h [delete] https://crrev.com/504fd2e8f347bf20638cce9f80ebf065ad017a73/content/browser/loader/async_resource_handler_browsertest.cc [delete] https://crrev.com/504fd2e8f347bf20638cce9f80ebf065ad017a73/content/browser/loader/async_resource_handler_unittest.cc [modify] https://crrev.com/99ab0e0a3bfbaeed167be404db5fcb070bfc82a4/content/browser/loader/resource_dispatcher_host_impl.cc [modify] https://crrev.com/99ab0e0a3bfbaeed167be404db5fcb070bfc82a4/content/browser/loader/resource_dispatcher_host_impl.h [modify] https://crrev.com/99ab0e0a3bfbaeed167be404db5fcb070bfc82a4/content/browser/loader/resource_loader_unittest.cc [delete] https://crrev.com/504fd2e8f347bf20638cce9f80ebf065ad017a73/content/browser/loader/resource_message_delegate.cc [delete] https://crrev.com/504fd2e8f347bf20638cce9f80ebf065ad017a73/content/browser/loader/resource_message_delegate.h [modify] https://crrev.com/99ab0e0a3bfbaeed167be404db5fcb070bfc82a4/content/browser/loader/resource_message_filter.cc [delete] https://crrev.com/504fd2e8f347bf20638cce9f80ebf065ad017a73/content/browser/loader/sync_resource_handler.cc [delete] https://crrev.com/504fd2e8f347bf20638cce9f80ebf065ad017a73/content/browser/loader/sync_resource_handler.h [modify] https://crrev.com/99ab0e0a3bfbaeed167be404db5fcb070bfc82a4/content/common/resource_messages.h [modify] https://crrev.com/99ab0e0a3bfbaeed167be404db5fcb070bfc82a4/content/renderer/BUILD.gn [delete] https://crrev.com/504fd2e8f347bf20638cce9f80ebf065ad017a73/content/renderer/loader/child_resource_message_filter.cc [delete] https://crrev.com/504fd2e8f347bf20638cce9f80ebf065ad017a73/content/renderer/loader/child_resource_message_filter.h [modify] https://crrev.com/99ab0e0a3bfbaeed167be404db5fcb070bfc82a4/content/renderer/loader/request_extra_data.cc [modify] https://crrev.com/99ab0e0a3bfbaeed167be404db5fcb070bfc82a4/content/renderer/loader/resource_dispatcher.cc [modify] https://crrev.com/99ab0e0a3bfbaeed167be404db5fcb070bfc82a4/content/renderer/loader/resource_dispatcher.h [modify] https://crrev.com/99ab0e0a3bfbaeed167be404db5fcb070bfc82a4/content/renderer/loader/resource_dispatcher_unittest.cc [delete] https://crrev.com/504fd2e8f347bf20638cce9f80ebf065ad017a73/content/renderer/loader/resource_scheduling_filter.cc [delete] https://crrev.com/504fd2e8f347bf20638cce9f80ebf065ad017a73/content/renderer/loader/resource_scheduling_filter.h [delete] https://crrev.com/504fd2e8f347bf20638cce9f80ebf065ad017a73/content/renderer/loader/shared_memory_received_data_factory.cc [delete] https://crrev.com/504fd2e8f347bf20638cce9f80ebf065ad017a73/content/renderer/loader/shared_memory_received_data_factory.h [delete] https://crrev.com/504fd2e8f347bf20638cce9f80ebf065ad017a73/content/renderer/loader/shared_memory_received_data_factory_unittest.cc [modify] https://crrev.com/99ab0e0a3bfbaeed167be404db5fcb070bfc82a4/content/renderer/loader/sync_load_context.cc [modify] https://crrev.com/99ab0e0a3bfbaeed167be404db5fcb070bfc82a4/content/renderer/loader/url_loader_client_impl.cc [modify] https://crrev.com/99ab0e0a3bfbaeed167be404db5fcb070bfc82a4/content/renderer/loader/url_loader_client_impl_unittest.cc [modify] https://crrev.com/99ab0e0a3bfbaeed167be404db5fcb070bfc82a4/content/renderer/loader/url_response_body_consumer.cc [modify] https://crrev.com/99ab0e0a3bfbaeed167be404db5fcb070bfc82a4/content/renderer/loader/url_response_body_consumer_unittest.cc [modify] https://crrev.com/99ab0e0a3bfbaeed167be404db5fcb070bfc82a4/content/renderer/loader/web_url_loader_impl.cc [modify] https://crrev.com/99ab0e0a3bfbaeed167be404db5fcb070bfc82a4/content/renderer/loader/web_url_loader_impl_unittest.cc [modify] https://crrev.com/99ab0e0a3bfbaeed167be404db5fcb070bfc82a4/content/renderer/render_thread_impl.cc [modify] https://crrev.com/99ab0e0a3bfbaeed167be404db5fcb070bfc82a4/content/renderer/render_thread_impl.h [modify] https://crrev.com/99ab0e0a3bfbaeed167be404db5fcb070bfc82a4/content/renderer/render_thread_impl_browsertest.cc [delete] https://crrev.com/504fd2e8f347bf20638cce9f80ebf065ad017a73/content/renderer/scheduler/resource_dispatch_throttler.cc [delete] https://crrev.com/504fd2e8f347bf20638cce9f80ebf065ad017a73/content/renderer/scheduler/resource_dispatch_throttler.h [delete] https://crrev.com/504fd2e8f347bf20638cce9f80ebf065ad017a73/content/renderer/scheduler/resource_dispatch_throttler_unittest.cc [modify] https://crrev.com/99ab0e0a3bfbaeed167be404db5fcb070bfc82a4/content/renderer/service_worker/service_worker_fetch_context_impl.cc [modify] https://crrev.com/99ab0e0a3bfbaeed167be404db5fcb070bfc82a4/content/renderer/service_worker/worker_fetch_context_impl.cc [modify] https://crrev.com/99ab0e0a3bfbaeed167be404db5fcb070bfc82a4/content/test/BUILD.gn [modify] https://crrev.com/99ab0e0a3bfbaeed167be404db5fcb070bfc82a4/third_party/WebKit/Source/core/loader/WorkerFetchContext.cpp [modify] https://crrev.com/99ab0e0a3bfbaeed167be404db5fcb070bfc82a4/third_party/WebKit/Source/platform/exported/WebURLRequest.cpp [modify] https://crrev.com/99ab0e0a3bfbaeed167be404db5fcb070bfc82a4/third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.cpp [modify] https://crrev.com/99ab0e0a3bfbaeed167be404db5fcb070bfc82a4/third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.h [modify] https://crrev.com/99ab0e0a3bfbaeed167be404db5fcb070bfc82a4/third_party/WebKit/public/platform/WebURLRequest.h
Comment 1 by yhirano@chromium.org
, Nov 23 2017