New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 788239 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

UKM entry names are often duplicated between the generated code and client code

Project Member Reported by asvitk...@chromium.org, Nov 23 2017

Issue description

UKM entry names are often duplicated between the generated code and client code.

We generate the names as kEntryName member of the builder class. However, lots of code currently declares these separately too.

Now, it may be that these get de-duped by compilers/linkers, but it would be better if there was no duplication in the source code and the logging code just referenced kEntryName.

e.g.

https://cs.chromium.org/search/?q=LocalNetworkRequests%5C%22&type=cs

We should also advise the same during code review.
 
Labels: -Type-Bug Type-Task
Status: WontFix (was: Assigned)
Since this does not affect binary size (as compiler merges them which I double checked), I don't think it's a big enough deal to worry about. WontFixing.

Sign in to add a comment