New issue
Advanced search Search tips

Issue 788238 link

Starred by 1 user
Status: Duplicate
Owner: ----
Closed: Nov 2017
Cc:
leon....@intel.com
robertma@chromium.org
foolip@chromium.org
chrome-trooper-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

WPT bots failing at bot_update (KeyError: 'root')

Project Member Reported by robertma@chromium.org, Nov 23 2017 
Note: I am aware of  issue 788038 . This is a different (perhaps related) issue.

Our two cron jobs wpt-importer and wpt-exporter have been constantly failing at bot_update since  issue 788038  was fixed:
https://ci.chromium.org/p/chromium/g/chromium.infra.cron/builders

Both of them are producing the same exception during bot_update:


Traceback (most recent call last):
  File "/b/rr/tmpdUpekt/rw/recipes/.recipe_deps/recipe_engine/recipe_engine/run.py", line 328, in _new_run
    recipe_result = recipe_script.run(api, properties)
  File "/b/rr/tmpdUpekt/rw/recipes/.recipe_deps/recipe_engine/recipe_engine/loader.py", line 98, in run
    self.run_steps, properties, self.PROPERTIES, api=api)
  File "/b/rr/tmpdUpekt/rw/recipes/.recipe_deps/recipe_engine/recipe_engine/loader.py", line 627, in invoke_with_properties
    **additional_args)
  File "/b/rr/tmpdUpekt/rw/recipes/.recipe_deps/recipe_engine/recipe_engine/loader.py", line 588, in _invoke_with_properties
    return callable_obj(*props, **additional_args)
  File "/b/rr/tmpdUpekt/rw/recipes/recipes/wpt_export.py", line 31, in RunSteps
    api.bot_update.ensure_checkout()
  File "/b/rr/tmpdUpekt/rw/recipes/.recipe_deps/recipe_engine/recipe_engine/recipe_api.py", line 745, in _inner
    return func(*a, **kw)
  File "/b/rr/tmpdUpekt/rw/recipes/.recipe_deps/depot_tools/recipes/recipe_modules/bot_update/api.py", line 338, in ensure_checkout
    co_root = result['root']
KeyError: 'root'

Comment 1 by robertma@chromium.org, Nov 24 2017

Cc: foolip@chromium.org

Comment 2 by katthomas@google.com, Nov 27 2017

Owner: tandrii@chromium.org
Status: Assigned (was: Untriaged)
Assigning to tandrii since it looks like he's been working on bot_update lately.

Comment 3 by tandrii@chromium.org, Nov 27 2017

Owner: iannucci@chromium.org
noooooooooooooooooooooooooooooooooooooooooooooooo, this is unfair :(

but I'll be willing to bet $50 that your recipe is in repo into which recipe roller didn't roll the fix.

Comment 4 by tandrii@chromium.org, Nov 27 2017

Mergedinto: 788067
Owner: ----
Status: Duplicate (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/ad0a34727007e73796aee569c754ad28b0041eb4

commit ad0a34727007e73796aee569c754ad28b0041eb4
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Mon Nov 27 18:31:20 2017

Revert "Roll recipe dependencies (trivial)."

This reverts commit c3eceb6fe91133d8386622d53d70ce53ce9d4192.

Reason for revert: bad roll.

Original change's description:
> Roll recipe dependencies (trivial).
> 
> This is an automated CL created by the recipe roller. This CL rolls recipe
> changes from upstream projects (e.g. depot_tools) into downstream projects
> (e.g. tools/build).
> 
> 
> More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
> depot_tools:
>   https://crrev.com/7d9d9233cb657e968831238346917b0b64abb4c1 [depot_tools] Add mock lib (myjang@google.com)
>   https://crrev.com/acc8e3ebaa39bf655def1e33221e56ff9b844ad0 [presubmit] Extend depot tools auth to use luci context (myjang@google.com)
>   https://crrev.com/00fc72856bb0a8f5889409c992b8123e79a852a6 [presubmit] Rename to CheckChangedLUCIConfigs (myjang@google.com)
>   https://crrev.com/6e215cefe22e42559fb6bd96ab385920051a5ee1 Show GIT_TRACE for git command in bot_update.py (tikuta@google.com)
> 
> 
> TBR=iannucci@chromium.org
> 
> Recipe-Tryjob-Bypass-Reason: Autoroller
> Bugdroid-Send-Email: False
> Change-Id: I610293ad0b5c8016efd23e1a08e486e3c63f384f
> Reviewed-on: https://chromium-review.googlesource.com/786492
> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

TBR=iannucci@chromium.org,recipe-roller@chromium.org

Bug:  788238 , 788067
Change-Id: I65e6e068157ee123c6302db746472e70cbb87918
Reviewed-on: https://chromium-review.googlesource.com/791190
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/ad0a34727007e73796aee569c754ad28b0041eb4/recipes/README.recipes.md
[modify] https://crrev.com/ad0a34727007e73796aee569c754ad28b0041eb4/infra/config/recipes.cfg

Comment 6 by tandrii@chromium.org, Nov 27 2017 

Sadly, nobody bet against me, i'd have won it. The above revert fixed your issue: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-exporter/52915 passed bot_update.

Comment 7 by robertma@chromium.org, Nov 27 2017 

Confirmed. Thank you so much!
►

Sign in to add a comment