New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 788230 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Crash in mov_read_sidx

Project Member Reported by ClusterFuzz, Nov 23 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4672038630588416

Fuzzer: inferno_flicker
Job Type: linux_ubsan_vptr_chrome
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0xfffffffc07572604
Crash State:
  mov_read_sidx
  mov_read_default
  mov_read_header
  
Sanitizer: undefined (UBSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_chrome&range=514498:517702

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4672038630588416

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Nov 23 2017

Cc: jstebb...@jetheaddev.com lu...@stabe.de
Labels: Test-Predator-Auto-CC
Automatically adding ccs based on suspected regression changelists:

mov: fix decode of fragments that overlap in time by jstebbins@jetheaddev.com - https://chromium.googlesource.com/chromium/third_party/ffmpeg/+/4a9d32baca3af0d1831f9556a922c7ab5b426b10

avformat: fix id3 chapters by lukas@stabe.de - https://chromium.googlesource.com/chromium/third_party/ffmpeg/+/1fd80106be3dca9fa0ea13fb364c8d221bd27c15

If this is incorrect, please apply the Test-Predator-Wrong-CLs label.
Components: Internals>Media>FFmpeg
Labels: M-63 Pri-1
Project Member

Comment 4 by sheriffbot@chromium.org, Nov 24 2017

Labels: -Security_Impact-Head Security_Impact-Beta
Project Member

Comment 5 by sheriffbot@chromium.org, Nov 24 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: dalecur...@chromium.org
Status: Assigned (was: Untriaged)
Assign to dalecurtis (ffmpeg owner) to help triage and assign to the right owner. Thanks!

Comment 7 by gov...@chromium.org, Nov 25 2017

Cc: awhalley@chromium.org
+awhalley@
Labels: -Security_Impact-Beta -M-63 Security_Impact-Head M-64
Says this just impacts head, with the starting regression at 64.0.3262.0, not beta? Correcting the labels to match what's in CF.

jstebbins@ who doesn't have access to this bug says a fix has been submitted upstream. I'm looking into it now.
Fix from upstream works, landed and DEPS roll out: https://chromium-review.googlesource.com/c/chromium/src/+/790940
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/089483c18ed34c1702534ed23f2e404798734d92

commit 089483c18ed34c1702534ed23f2e404798734d92
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Mon Nov 27 21:09:30 2017

Roll src/third_party/ffmpeg/ abead8cbc..9cb03e570 (1 commit)

https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/abead8cbcf89..9cb03e5705c1

$ git log abead8cbc..9cb03e570 --date=short --no-merges --format='%ad %ae %s'
2017-11-27 jstebbins lavf/mov: fix crash in mov_read_sidx

Created with:
  roll-dep src/third_party/ffmpeg

BUG= 788230 
TEST=test case no longer reproduces
TBR=sandersd

Change-Id: I721aec670a70d1c9ed54f416ddb71f3ec3a9b529
Reviewed-on: https://chromium-review.googlesource.com/790940
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519399}
[modify] https://crrev.com/089483c18ed34c1702534ed23f2e404798734d92/DEPS

Status: Fixed (was: Assigned)
Project Member

Comment 12 by ClusterFuzz, Nov 28 2017

ClusterFuzz has detected this issue as fixed in range 519370:519404.

Detailed report: https://clusterfuzz.com/testcase?key=4672038630588416

Fuzzer: inferno_flicker
Job Type: linux_ubsan_vptr_chrome
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0xfffffffc07572604
Crash State:
  mov_read_sidx
  mov_read_default
  mov_read_header
  
Sanitizer: undefined (UBSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_chrome&range=514498:517702
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_chrome&range=519370:519404

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4672038630588416

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 13 by ClusterFuzz, Nov 28 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 4672038630588416 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 14 by sheriffbot@chromium.org, Nov 28 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 15 by sheriffbot@chromium.org, Mar 6 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 16 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Security_Impact-Head -M-64 M-65 Security_Impact-Stable
Labels: -ReleaseBlock-Stable

Sign in to add a comment