New issue
Advanced search Search tips

Issue 788229 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

[Autofill] Use the AddressNormalizer in ChromeAutofillClientIOS

Project Member Reported by ma...@chromium.org, Nov 23 2017

Issue description

We need to create an iOS factory for the address normalizer and use it in ChromeAutofillClientIOS
 

Comment 1 by ma...@chromium.org, Nov 28 2017

Cc: ma...@chromium.org
Owner: mahmadi@chromium.org
Also in payment_request.mm, we should use the factory for the AddressNormalizer.
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a0d61c7aac7250de05fb7c86fb20dc94eba1d0a

commit 1a0d61c7aac7250de05fb7c86fb20dc94eba1d0a
Author: Mohamad Ahmadi <mahmadi@chromium.org>
Date: Mon Dec 04 19:40:31 2017

[PR][AF] Creates an AddressNormalizerFactory class

This class is to be used in ChromeAutofillClientIOS and PaymentRequest for
lazy instantiation of the AddressNormalizerImpl

Bug:  788229 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ibe57b150e0aeea1777fab5e5a5aebecfd04fdfc3
Reviewed-on: https://chromium-review.googlesource.com/797735
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521410}
[modify] https://crrev.com/1a0d61c7aac7250de05fb7c86fb20dc94eba1d0a/ios/chrome/browser/autofill/BUILD.gn
[add] https://crrev.com/1a0d61c7aac7250de05fb7c86fb20dc94eba1d0a/ios/chrome/browser/autofill/address_normalizer_factory.cc
[add] https://crrev.com/1a0d61c7aac7250de05fb7c86fb20dc94eba1d0a/ios/chrome/browser/autofill/address_normalizer_factory.h
[modify] https://crrev.com/1a0d61c7aac7250de05fb7c86fb20dc94eba1d0a/ios/chrome/browser/payments/payment_request.h
[modify] https://crrev.com/1a0d61c7aac7250de05fb7c86fb20dc94eba1d0a/ios/chrome/browser/payments/payment_request.mm
[modify] https://crrev.com/1a0d61c7aac7250de05fb7c86fb20dc94eba1d0a/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm

Status: Fixed (was: Started)

Sign in to add a comment