New issue
Advanced search Search tips

Issue 788208 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Use-of-uninitialized-value in SkFontRequestCache::Request::Create

Project Member Reported by ClusterFuzz, Nov 23 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5746901340389376

Fuzzer: libFuzzer_paint_op_buffer_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  SkFontRequestCache::Request::Create
  SkFontMgr_FCI::onLegacyMakeTypeface
  SkFontMgr::legacyMakeTypeface
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=518493:518517

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5746901340389376

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Nov 23 2017

Labels: Test-Predator-Auto-Owner
Owner: khushals...@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/7865b5be0f6472b14ed7a30bc7e41896a8ec9e6e (cc: Replace SkImageFilter with PaintFilter in paint recordings.).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.
Components: Internals>Skia>Compositing Internals>Compositing
Labels: M-63
Project Member

Comment 4 by sheriffbot@chromium.org, Nov 24 2017

Labels: -Security_Impact-Head Security_Impact-Beta
Project Member

Comment 5 by sheriffbot@chromium.org, Nov 24 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by sheriffbot@chromium.org, Nov 24 2017

Labels: Pri-1

Comment 7 by gov...@chromium.org, Nov 25 2017

Cc: awhalley@chromium.org
awhalley@

Comment 8 by awhalley@google.com, Nov 27 2017

Labels: -Security_Impact-Beta -M-63 Security_Impact-Head M-64

Comment 9 by mmoroz@google.com, Nov 27 2017

Cc: enne@chromium.org

Comment 10 by enne@chromium.org, Nov 27 2017

Cc: vmp...@chromium.org
Labels: -ReleaseBlock-Stable
This doesn't need to be ReleaseBlock. Its only being hit on PaintOpBuffer serialization which isn't turned on right now.
Project Member

Comment 12 by sheriffbot@chromium.org, Nov 28 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 13 by ClusterFuzz, Dec 2 2017

ClusterFuzz has detected this issue as fixed in range 520972:521000.

Detailed report: https://clusterfuzz.com/testcase?key=5746901340389376

Fuzzer: libFuzzer_paint_op_buffer_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  SkFontRequestCache::Request::Create
  SkFontMgr_FCI::onLegacyMakeTypeface
  SkFontMgr::legacyMakeTypeface
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=518493:518517
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=520972:521000

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5746901340389376

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 14 by ClusterFuzz, Dec 2 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5746901340389376 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 15 by sheriffbot@chromium.org, Dec 2 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 16 by sheriffbot@chromium.org, Mar 10 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 17 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Security_Impact-Head -M-64 M-65 Security_Impact-Stable
Labels: -ReleaseBlock-Stable

Sign in to add a comment