New issue
Advanced search Search tips

Issue 788206 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in blink::SVGStopElement::StopColorIncludingOpacity

Project Member Reported by ClusterFuzz, Nov 23 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5406917097947136

Fuzzer: inferno_twister_c
Job Type: linux_asan_chrome_v8_arm
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x00000034
Crash State:
  blink::SVGStopElement::StopColorIncludingOpacity
  blink::SVGGradientElement::BuildStops
  blink::SVGGradientElement::CollectCommonAttributes
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_v8_arm&range=514498:517702

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5406917097947136

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Nov 23 2017

Components: Blink>SVG
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Nov 23 2017

Labels: Test-Predator-Auto-Owner
Owner: fmalita@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/e3276a9902608cd3930d2a1dad67d56b5ae98313 (Do not instantiate SVG color stop layout objects).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c597622d25e8e36b6116db30a671154c74b3c3fe

commit c597622d25e8e36b6116db30a671154c74b3c3fe
Author: Florin Malita <fmalita@chromium.org>
Date: Tue Nov 28 00:24:07 2017

Handle missing SVG <stop> style gracefully

Undistributed shadow DOM v0 light tree nodes don't seem to enforce
style calculation.

Prior to https://chromium-review.googlesource.com/c/chromium/src/+/767708,
this condition was being caught by checking for null style.

Add back the style check to handle this case gracefully.

BUG= 788206 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I859a78206ca61fa58a6f24c6afd84b98004ed757
Reviewed-on: https://chromium-review.googlesource.com/791213
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519474}
[add] https://crrev.com/c597622d25e8e36b6116db30a671154c74b3c3fe/third_party/WebKit/LayoutTests/svg/custom/stop-style-crash-expected.txt
[add] https://crrev.com/c597622d25e8e36b6116db30a671154c74b3c3fe/third_party/WebKit/LayoutTests/svg/custom/stop-style-crash.svg
[modify] https://crrev.com/c597622d25e8e36b6116db30a671154c74b3c3fe/third_party/WebKit/Source/core/svg/SVGStopElement.cpp

Status: Fixed (was: Assigned)
Project Member

Comment 5 by ClusterFuzz, Nov 28 2017

ClusterFuzz has detected this issue as fixed in range 519433:519508.

Detailed report: https://clusterfuzz.com/testcase?key=5406917097947136

Fuzzer: inferno_twister_c
Job Type: linux_asan_chrome_v8_arm
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x00000034
Crash State:
  blink::SVGStopElement::StopColorIncludingOpacity
  blink::SVGGradientElement::BuildStops
  blink::SVGGradientElement::CollectCommonAttributes
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_v8_arm&range=514498:517702
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_v8_arm&range=519433:519508

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5406917097947136

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Nov 28 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5406917097947136 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment