New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 788200 link

Starred by 1 user
Status: Fixed
Owner:
█ jose.dap...@lge.com
Last visit > 30 days ago
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Task
Team-Accessibility



Sign in to add a comment

Implement AtkValue get_minimum_increment in AXNodePlatformAuraLinux

Project Member Reported by jose.dap...@lge.com, Nov 23 2017 
From https://chromium-review.googlesource.com/c/chromium/src/+/781764/3/ui/accessibility/platform/ax_platform_node_auralinux.cc

"We have AXNodeObject::StepValueForRange() implemented, I'd love to see it plumbed through for platforms that can use it. I've been asking for
aria-valuestep for a while now for ARIA range controls, too."

This task is for exposing StepValueFOrRange through AX, and use it in ATK to have a proper value for AtkValue get_minimum_increment.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46040c08f20c378a9f6b246375713a21632a0dc4

commit 46040c08f20c378a9f6b246375713a21632a0dc4
Author: Jose Dapena Paz <jose.dapena@lge.com>
Date: Thu Nov 30 15:07:46 2017

A11y: add range step increment support on Blink, AX and AuraLinux.

Added ui/accessibility support for the step value on ranges. Exposed
StepValueForRange, already present in AXNodeObject, to the public
Blink accessibility API, and mapped it to the ui/accessibility API.

Then updated the AuraLinux implementation of get_minimum_increment
to properly retrieve the step increment value instead of a
generic one.

Bug:  788200 
Change-Id: Ia8049e56581837b4e5c759ac580bff75dae11601
Reviewed-on: https://chromium-review.googlesource.com/793736
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520542}
[modify] https://crrev.com/46040c08f20c378a9f6b246375713a21632a0dc4/content/renderer/accessibility/blink_ax_tree_source.cc
[modify] https://crrev.com/46040c08f20c378a9f6b246375713a21632a0dc4/content/shell/test_runner/web_ax_object_proxy.cc
[modify] https://crrev.com/46040c08f20c378a9f6b246375713a21632a0dc4/content/shell/test_runner/web_ax_object_proxy.h
[modify] https://crrev.com/46040c08f20c378a9f6b246375713a21632a0dc4/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] https://crrev.com/46040c08f20c378a9f6b246375713a21632a0dc4/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h
[modify] https://crrev.com/46040c08f20c378a9f6b246375713a21632a0dc4/third_party/WebKit/Source/modules/accessibility/AXObject.h
[modify] https://crrev.com/46040c08f20c378a9f6b246375713a21632a0dc4/third_party/WebKit/Source/modules/exported/WebAXObject.cpp
[modify] https://crrev.com/46040c08f20c378a9f6b246375713a21632a0dc4/third_party/WebKit/public/web/WebAXObject.h
[modify] https://crrev.com/46040c08f20c378a9f6b246375713a21632a0dc4/ui/accessibility/ax_enums.idl
[modify] https://crrev.com/46040c08f20c378a9f6b246375713a21632a0dc4/ui/accessibility/ax_node_data.cc
[modify] https://crrev.com/46040c08f20c378a9f6b246375713a21632a0dc4/ui/accessibility/ax_tree_unittest.cc
[modify] https://crrev.com/46040c08f20c378a9f6b246375713a21632a0dc4/ui/accessibility/platform/ax_platform_node_auralinux.cc
[modify] https://crrev.com/46040c08f20c378a9f6b246375713a21632a0dc4/ui/accessibility/platform/ax_platform_node_auralinux.h
[modify] https://crrev.com/46040c08f20c378a9f6b246375713a21632a0dc4/ui/accessibility/platform/ax_platform_node_auralinux_unittest.cc

Comment 2 by jose.dap...@lge.com, Nov 30 2017

Status: Fixed (was: Untriaged)
►

Sign in to add a comment