New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 788178 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 832560



Sign in to add a comment

Generate webview support library boundary implementations

Project Member Reported by gsennton@chromium.org, Nov 23 2017

Issue description

See  crbug.com/788177  for context on boundary interfaces.

This bug is about generating code for each support library class to implement those interfaces, or call into them, depending on whether instances of the class are created in the support library / app, or in the webview apk.

As an example, see
https://googleplex-android-review.git.corp.google.com/c/platform/frameworks/support/+/3217743/3

where WebSettingsImpl:
https://googleplex-android-review.git.corp.google.com/c/platform/frameworks/support/+/3217743/3/webkit/src/main/java/androidx/webkit/WebSettingsImpl.java
implements WebSettingsCompat (app-facing) by calling into the boundary interface WebSettingsInterface.

vs. VisualStateCallbackImpl:
https://googleplex-android-review.git.corp.google.com/c/platform/frameworks/support/+/3217743/3/webkit/src/main/java/androidx/webkit/VisualStateCallbackImpl.java
which implements VisualStateCallbackInterface to call into a VisualStateCallback object created by the app.

How to determine which class should implement the app-facing interface vs. the boundary interface is described here:  crbug.com/788174 
 
Blocking: -788138
Labels: -M-65
Blocking: 832560
Status: WontFix (was: Assigned)
Closing this for now since we're no longer pursuing code generation for the support library.

Sign in to add a comment