Build break on chromium.lkgr Win_SyzyASAN_LKGR |
|||||
Issue descriptionSee https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.lkgr%2FWin_SyzyASAN_LKGR%2F6718%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout [28934/41867] CXX obj/pdf/pdf/pdfium_engine.obj FAILED: obj/pdf/pdf/pdfium_engine.obj ninja -t msvc -e environment.x86 -- "c:\b\c\win_toolchain\vs_files\a9e1098bba66d2acccc377d5ee81265910f29272\vc\tools\msvc\14.11.25503\bin\hostx64\x86/cl.exe" /nologo /showIncludes @obj/pdf/pdf/pdfium_engine.obj.rsp /c ../../pdf/pdfium/pdfium_engine.cc /Foobj/pdf/pdf/pdfium_engine.obj /Fd"obj/pdf/pdf_cc.pdb" c:\b\c\win_toolchain\vs_files\a9e1098bba66d2acccc377d5ee81265910f29272\vc\tools\msvc\14.11.25503\include\xutility(3107): error C2220: warning treated as error - no 'object' file generated c:\b\c\win_toolchain\vs_files\a9e1098bba66d2acccc377d5ee81265910f29272\vc\tools\msvc\14.11.25503\include\xutility(3126): note: see reference to function template instantiation '_InIt std::_Find_unchecked1<_InIt,_Ty>(_InIt,_InIt,const _Ty &,std::false_type)' being compiled with [ _InIt=int *, _Ty=::size_t ] c:\b\c\win_toolchain\vs_files\a9e1098bba66d2acccc377d5ee81265910f29272\vc\tools\msvc\14.11.25503\include\xutility(3135): note: see reference to function template instantiation '_InIt std::_Find_unchecked<int*,_Ty>(_InIt,_InIt,const _Ty &)' being compiled with [ _InIt=int *, _Ty=::size_t ] ../../pdf/pdfium/pdfium_engine.cc(3129): note: see reference to function template instantiation '_InIt std::find<std::_Vector_iterator<std::_Vector_val<std::_Simple_types<_Ty>>>,::size_t>(_InIt,_InIt,const unsigned int &)' being compiled with [ _InIt=std::_Vector_iterator<std::_Vector_val<std::_Simple_types<PP_Resource>>>, _Ty=PP_Resource ]
,
Nov 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/112d7b025fc05fe5a7f6e00c2f0a6717dbe91976 commit 112d7b025fc05fe5a7f6e00c2f0a6717dbe91976 Author: Sigurður Ásgeirsson <siggi@chromium.org> Date: Thu Nov 23 14:23:54 2017 Revert "Count annotation subtypes that appear in PDF documents." This reverts commit 6c9aa01842b041e38243a51e09d446274c7b5297. Reason for revert: breaks chromium.lkgr Win_SyzyASAN_LKG build Bug: 788176 Original change's description: > Count annotation subtypes that appear in PDF documents. > > Bug: chromium:768986 > Change-Id: I25fcf447501224d02be40565c8ec770a06edd2e6 > Reviewed-on: https://chromium-review.googlesource.com/740141 > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> > Reviewed-by: dsinclair <dsinclair@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#518771} TBR=dsinclair@chromium.org,isherman@chromium.org,hnakashima@chromium.org Change-Id: I05c59dcd9488428bf8182216bb81aac8c667ea4e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:768986 Reviewed-on: https://chromium-review.googlesource.com/788030 Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#518929} [modify] https://crrev.com/112d7b025fc05fe5a7f6e00c2f0a6717dbe91976/pdf/BUILD.gn [modify] https://crrev.com/112d7b025fc05fe5a7f6e00c2f0a6717dbe91976/pdf/out_of_process_instance.cc [modify] https://crrev.com/112d7b025fc05fe5a7f6e00c2f0a6717dbe91976/pdf/out_of_process_instance.h [delete] https://crrev.com/57b2dc23b962feeadd2dcf60a399c9f38d2087e3/pdf/pdf_engine.cc [modify] https://crrev.com/112d7b025fc05fe5a7f6e00c2f0a6717dbe91976/pdf/pdf_engine.h [modify] https://crrev.com/112d7b025fc05fe5a7f6e00c2f0a6717dbe91976/pdf/pdfium/pdfium_engine.cc [modify] https://crrev.com/112d7b025fc05fe5a7f6e00c2f0a6717dbe91976/pdf/pdfium/pdfium_page.cc [modify] https://crrev.com/112d7b025fc05fe5a7f6e00c2f0a6717dbe91976/pdf/pdfium/pdfium_page.h [modify] https://crrev.com/112d7b025fc05fe5a7f6e00c2f0a6717dbe91976/pdf/preview_mode_client.cc [modify] https://crrev.com/112d7b025fc05fe5a7f6e00c2f0a6717dbe91976/pdf/preview_mode_client.h [modify] https://crrev.com/112d7b025fc05fe5a7f6e00c2f0a6717dbe91976/tools/metrics/histograms/enums.xml [modify] https://crrev.com/112d7b025fc05fe5a7f6e00c2f0a6717dbe91976/tools/metrics/histograms/histograms.xml
,
Nov 23 2017
,
Nov 23 2017
What's the actual issue here? I don't understand the error output. How do we fix this so we can reland our CL? How do we test the change? Why does this pass all other bots but not compile on this bot?
,
Nov 23 2017
Ah, I see the error is on the bottom, missed it, I found the error in the code. Thanks.
,
Nov 23 2017
I replied on the CL that cause this bug, but this isn't a SyzyAsan specific issue, this is a MSVC build failure. We recently switched the Win builders to Clang and there's no good coverage for the MSVC config right now (the team is working on this), in the meantime the SyzyAsan bot is one of the only one that allows us to catch this kind of issue...
,
Nov 23 2017
Yeah, apparently this is one annoying difference between Clang and MSVC. We're nominally keeping the MSVC build alive for a couple of milestones at least, so I hope we're getting try/build bot coverage for this.
,
Nov 23 2017
Yups, same error on the official build: [38003/52471] CXX obj/pdf/pdf/pdfium_engine.obj FAILED: obj/pdf/pdf/pdfium_engine.obj ninja -t msvc -e environment.x86 -- "c:\b\c\win_toolchain\vs_files\a9e1098bba66d2acccc377d5ee81265910f29272\vc\tools\msvc\14.11.25503\bin\hostx64\x86/cl.exe" /nologo /showIncludes @obj/pdf/pdf/pdfium_engine.obj.rsp /c ../../pdf/pdfium/pdfium_engine.cc /Foobj/pdf/pdf/pdfium_engine.obj /Fd"obj/pdf/pdf_cc.pdb" c:\b\c\win_toolchain\vs_files\a9e1098bba66d2acccc377d5ee81265910f29272\vc\tools\msvc\14.11.25503\include\xutility(3107): error C2220: warning treated as error - no 'object' file generated c:\b\c\win_toolchain\vs_files\a9e1098bba66d2acccc377d5ee81265910f29272\vc\tools\msvc\14.11.25503\include\xutility(3126): note: see reference to function template instantiation '_InIt std::_Find_unchecked1<_InIt,_Ty>(_InIt,_InIt,const _Ty &,std::false_type)' being compiled with [ _InIt=int *, _Ty=::size_t ] c:\b\c\win_toolchain\vs_files\a9e1098bba66d2acccc377d5ee81265910f29272\vc\tools\msvc\14.11.25503\include\xutility(3135): note: see reference to function template instantiation '_InIt std::_Find_unchecked<int*,_Ty>(_InIt,_InIt,const _Ty &)' being compiled with [ _InIt=int *, _Ty=::size_t ] ../../pdf/pdfium/pdfium_engine.cc(3129): note: see reference to function template instantiation '_InIt std::find<std::_Vector_iterator<std::_Vector_val<std::_Simple_types<_Ty>>>,::size_t>(_InIt,_InIt,const unsigned int &)' being compiled with [ _InIt=std::_Vector_iterator<std::_Vector_val<std::_Simple_types<PP_Resource>>>, _Ty=PP_Resource ] c:\b\c\win_toolchain\vs_files\a9e1098bba66d2acccc377d5ee81265910f29272\vc\tools\msvc\14.11.25503\include\xutility(3107): warning C4389: '==': signed/unsigned mismatch
,
Nov 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd7edf2acda4e3a7bc921de6aca3fcbb3599349b commit fd7edf2acda4e3a7bc921de6aca3fcbb3599349b Author: Henrique Nakashima <hnakashima@chromium.org> Date: Wed Nov 29 22:03:49 2017 Reland "Count annotation subtypes that appear in PDF documents." Original: https://chromium-review.googlesource.com/c/chromium/src/+/740141 Revert: https://chromium-review.googlesource.com/c/chromium/src/+/788030 This reverts commit 112d7b025fc05fe5a7f6e00c2f0a6717dbe91976. Bug: 768986 , 788176 TBR: isherman@chromium.org Change-Id: Ie5c8889f73443b9eefccd803f15cd0c0b1cd1ce9 Reviewed-on: https://chromium-review.googlesource.com/788330 Reviewed-by: dsinclair <dsinclair@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#520262} [modify] https://crrev.com/fd7edf2acda4e3a7bc921de6aca3fcbb3599349b/pdf/BUILD.gn [modify] https://crrev.com/fd7edf2acda4e3a7bc921de6aca3fcbb3599349b/pdf/out_of_process_instance.cc [modify] https://crrev.com/fd7edf2acda4e3a7bc921de6aca3fcbb3599349b/pdf/out_of_process_instance.h [add] https://crrev.com/fd7edf2acda4e3a7bc921de6aca3fcbb3599349b/pdf/pdf_engine.cc [modify] https://crrev.com/fd7edf2acda4e3a7bc921de6aca3fcbb3599349b/pdf/pdf_engine.h [modify] https://crrev.com/fd7edf2acda4e3a7bc921de6aca3fcbb3599349b/pdf/pdfium/pdfium_engine.cc [modify] https://crrev.com/fd7edf2acda4e3a7bc921de6aca3fcbb3599349b/pdf/pdfium/pdfium_page.cc [modify] https://crrev.com/fd7edf2acda4e3a7bc921de6aca3fcbb3599349b/pdf/pdfium/pdfium_page.h [modify] https://crrev.com/fd7edf2acda4e3a7bc921de6aca3fcbb3599349b/pdf/preview_mode_client.cc [modify] https://crrev.com/fd7edf2acda4e3a7bc921de6aca3fcbb3599349b/pdf/preview_mode_client.h [modify] https://crrev.com/fd7edf2acda4e3a7bc921de6aca3fcbb3599349b/tools/metrics/histograms/enums.xml [modify] https://crrev.com/fd7edf2acda4e3a7bc921de6aca3fcbb3599349b/tools/metrics/histograms/histograms.xml |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by siggi@chromium.org
, Nov 23 2017