Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 78816 [Mac] Multi-selection in the tabstrip
Starred by 130 users Project Member Reported by rsesek@chromium.org, Apr 8 2011 Back to list
Status: Fixed
Owner: andresantoso@chromium.org
Closed: Mar 2014
Cc: rsesek@chromium.org, meh...@chromium.org, pawli...@chromium.org, dhollowa@chromium.org, vivianz@chromium.org, msrchandra@chromium.org, sky@chromium.org, dpa...@chromium.org, mark@chromium.org
Components:
OS: Mac
Pri: 2
Type: Feature

Blocked on:
issue 178887

Blocking:
issue 30572

Restricted
  • Only users with EditIssue permission may comment.


Sign in to add a comment
Tracking bug for multi-tab selection in the tabstrip on Mac.
 
Comment 1 by rsesek@chromium.org, Apr 20 2011
Blocking: 30572
Comment 2 by dhw@chromium.org, Apr 20 2011
Labels: PlatformParity
Summary: [Mac] Multi-selection in the tabstrip (was: NULL)
Project Member Comment 3 by bugdroid1@chromium.org, Apr 21 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=82543

------------------------------------------------------------------------
r82543 | rsesek@chromium.org | Thu Apr 21 13:18:37 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tabs/tab_window_controller.h?r1=82543&r2=82542&pathrev=82543
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm?r1=82543&r2=82542&pathrev=82543
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/testing_automation_provider_mac.mm?r1=82543&r2=82542&pathrev=82543
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tabs/tab_view.mm?r1=82543&r2=82542&pathrev=82543
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm?r1=82543&r2=82542&pathrev=82543
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tabs/tab_controller_target.h?r1=82543&r2=82542&pathrev=82543
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.h?r1=82543&r2=82542&pathrev=82543
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tabs/tab_controller.mm?r1=82543&r2=82542&pathrev=82543
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/browser_window_controller.mm?r1=82543&r2=82542&pathrev=82543
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tabs/tab_controller_unittest.mm?r1=82543&r2=82542&pathrev=82543
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tabs/tab_controller.h?r1=82543&r2=82542&pathrev=82543
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.mm?r1=82543&r2=82542&pathrev=82543
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/tabs/tab_controller.h?r1=82543&r2=82542&pathrev=82543
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tabs/tab_strip_controller_unittest.mm?r1=82543&r2=82542&pathrev=82543
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tabs/tab_strip_controller.h?r1=82543&r2=82542&pathrev=82543
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/tabs/tab_menu_model.cc?r1=82543&r2=82542&pathrev=82543

[Mac] First pass at multiple selection in the tabstrip.

This hooks up a new TabController state (called 'active') to indicate what
'selected' used to: key/focused state. The selected state can now be applied to
multiple TabControllers.

Currently only commands available through the context menu are usable for a
multi-tab selection. Support for dragging will come in a future CL.

The other notable chane is that tab activation now happens on |-mouseUp:|
rather than |-mouseDown:|, which is in preparation for multi-tab dragging.

BUG= 78816 
TEST=Shift click, Cmd click, and Cmd+Shift click to select tabs in different ways.

Review URL: http://codereview.chromium.org/6821003
------------------------------------------------------------------------
Project Member Comment 4 by bugdroid1@chromium.org, Jun 7 2011
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=88125

------------------------------------------------------------------------
r88125 | rsesek@chromium.org | Tue Jun 07 06:45:30 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tabs/tab_view.h?r1=88125&r2=88124&pathrev=88125
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tabs/tab_controller.mm?r1=88125&r2=88124&pathrev=88125
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tabs/tab_controller_unittest.mm?r1=88125&r2=88124&pathrev=88125
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=88125&r2=88124&pathrev=88125
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tabs/tab_controller.h?r1=88125&r2=88124&pathrev=88125
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tabs/tab_view.mm?r1=88125&r2=88124&pathrev=88125
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.h?r1=88125&r2=88124&pathrev=88125
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm?r1=88125&r2=88124&pathrev=88125
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tabs/tab_controller_target.h?r1=88125&r2=88124&pathrev=88125
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tabs/tab_strip_controller.h?r1=88125&r2=88124&pathrev=88125
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm?r1=88125&r2=88124&pathrev=88125

[Mac] Refactor the logic of tab dragging out of TabView and into a new helper.

The helper TabStripDragController is owned by the TabStripController. It
operates using the TabDraggingEventTarget protocol, which is used to pass the
mouse events from the TabView up through various controllers to the DragController.

This CL introduces no behavioral changes and is just preparatory work for being
able to drag multiple tabs.

BUG= 78816 
TEST=Drag tabs in and out of the tab strip. Everything works as before.

Review URL: http://codereview.chromium.org/7080064
------------------------------------------------------------------------
Comment 5 by rsesek@chromium.org, Jun 27 2011
Cc: rsesek@chromium.org dpa...@chromium.org
Issue 87687 has been merged into this issue.
Comment 6 by rsesek@chromium.org, Oct 12 2011
Issue 99688 has been merged into this issue.
Comment 7 by rsesek@chromium.org, Oct 18 2011
Cc: mark@chromium.org dhollowa@chromium.org sky@chromium.org
Issue 100714 has been merged into this issue.
Issue 112171 has been merged into this issue.
Issue 112838 has been merged into this issue.
Comment 10 by dhw@chromium.org, Feb 13 2012
Issue 113868 has been merged into this issue.
Comment 11 by dhw@chromium.org, Feb 24 2012
Issue 115703 has been merged into this issue.
Cc: meh...@chromium.org
Issue 138232 has been merged into this issue.
Issue 146790 has been merged into this issue.
Owner: ----
Status: Available
Comment 15 by dhw@chromium.org, Oct 31 2012
Issue 158598 has been merged into this issue.
Comment 16 by mark@chromium.org, Dec 6 2012
Cc: msrchandra@chromium.org vivianz@chromium.org
Issue 164366 has been merged into this issue.
Labels: Hotlist-Fixit-Dec-2012
Cc: jeffreyc@chromium.org pawli...@chromium.org
Anyone have ideas on who could tackle this in the last two weeks of December? Would that be reasonable, or would this feature require more time than that?
This is definitely more than a two-week project. It surmounts to an effective rewrite of the Mac tab strip.
Labels: -Hotlist-Fixit-Dec-2012
Darn, OK.

Another time, then.
This bug is really annoying as I was using this technique a lot on a pc. Now I have to pull every single tab one at a time. Still no solution in sight?
Issue 170830 has been merged into this issue.
Project Member Comment 23 by bugdroid1@chromium.org, Mar 10 2013
Labels: -Area-UI -Feature-TabStrip Cr-UI-Browser-TabStrip Cr-UI
Comment 24 by dhw@chromium.org, Mar 22 2013
Issue 152113 has been merged into this issue.
Comment 25 Deleted
For anyone else waiting for this feature, the extension Tabs Outliner can move multiple tabs between windows (among other things). However, because it's an extension, it can't transfer the back/forward history of the tabs.
https://chrome.google.com/webstore/detail/tabs-outliner/eggkanocgddhmamlbiijnphhppkpkmkl
Comment 27 by mark@chromium.org, May 16 2013
Issue 234662 has been merged into this issue.
Comment 28 by dhw@chromium.org, Jun 8 2013
Issue 246930 has been merged into this issue.
Comment 29 by laforge@google.com, Jul 24 2013
Cc: -jeffreyc@chromium.org
Issue 264506 has been merged into this issue.
This issue has been open for over 2.5 years now. When will there be an update to address it?
Probably never, it's obvious no one is active on this other than for merging duplicate tickets.
Comment 33 by Deleted ...@, Sep 1 2013
Agreed. Is there anything else we can do to get their attention? I find it pretty outrageous that such a helpful feature would go unnoticed for so many years.
I find this defect impedes my productivity using chrome on a daily basis, so I would very much like to see it addressed.

Passive aggressiveness aside, perhaps if enough of the 89 people that have starred this issue make noise, it will get some attention.
Comment 35 by aku...@gmail.com, Sep 1 2013
I would be SO grateful for a fix for this issue!  But I'm not in any position to insist upon one since I don't contribute to the project...
Unfortunately the bug tracker is not for "making noise" but to contribute toward improving the project. If you can code, try making inroads toward fixing the issue (as rsesek@chromium.org has done). Otherwise, make noise somewhere else where people not subscribed to this issue can see it (blogs, news sites, forums).
Comment 37 by Deleted ...@, Sep 3 2013
Is right there is no plan to fix it?
Issue 294395 has been merged into this issue.
Comment 39 by cdes...@gmail.com, Nov 26 2013
+1 (if for no other reason that to make noise and get some attention to a major productivity killer)
Vote for this feature
Comment 41 by Deleted ...@, Dec 23 2013
Vote from me as well.
Please google, help to reduce the waste of our computer memory use!!  

I wonder what should be the reason for the absence of such useful feature? At first sight may be trivial to implement it. I mean, just copy a bunch of links to a special folder (maybe named after last google search). And close that windows. 

BTW: Thanks chromium team for such wonderful (and liable) piece of software you are making! It turns my life easier every day! :D
Labels: Restrict-AddIssueComment-EditIssue
Owner: andresantoso@chromium.org
Status: Started
https://codereview.chromium.org/157403004/
Blockedon: chromium:178887
Labels: M-34 Merge-Requested
Status: Fixed
https://src.chromium.org/viewvc/chrome?view=rev&revision=253476

Since the fix is relatively small and fixes weird behavior on cmd-selecting tabs, maybe we want to merge this to m34?
I think this has been broken for a while, I'm not sure it qualifies for merge.
Comment 47 by dxie@chromium.org, Mar 3 2014
Labels: -Merge-Requested Merge-Rejected
and the change doesn't look small.
Issue 361647 has been merged into this issue.
Sign in to add a comment