New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 788157 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

14.4% regression in system_health.common_desktop at 516296:516474

Project Member Reported by hjd@google.com, Nov 23 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Nov 23 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=788157

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=8eab99ba97575c0334ead946b3b8c8b7c409ccb0cf20f4a446661c12cae78457


Bot(s) for this bug's original alert(s):

linux-release
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Nov 23 2017

๐Ÿ“ Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/119f64f3f80000
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Nov 23 2017

๐Ÿ“ Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/119f64f3f80000
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Nov 24 2017

๐Ÿ“ Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/12d5d75bf80000

Comment 5 by hjd@chromium.org, Nov 24 2017

Kicked bisect: regression seems clear.
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Nov 24 2017

Cc: dpranke@chromium.org ajwong@chromium.org thomasanderson@chromium.org caseq@chromium.org brettw@chromium.org pfeldman@chromium.org
Owner: ajwong@chromium.org
Status: Assigned (was: Untriaged)
๐Ÿ“ Found significant differences after each of 3 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/12d5d75bf80000

Revert "[Devtools] Requests can now be intercepted on response"
By dpranke@chromium.org ยท Wed Nov 15 04:02:55 2017
chromium @ ed79b4f36846e8aac9dd90179f25f7351df8a94d

Revert "Revert "[Devtools] Requests can now be intercepted on response""
By thomasanderson@chromium.org ยท Wed Nov 15 04:37:47 2017
chromium @ ddde3f72a8dbadb6974c61fe565c562b77a1426a

Enable frame pointers in linux.
By ajwong@chromium.org ยท Wed Nov 15 06:16:22 2017
chromium @ 9f966099a3d6f91c80016226fe9d33981f291689

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Status: WontFix (was: Assigned)
The frame pointer change moves Linux release inline with other platforms (including ChromeOS) in a way that makes lots the runtime environment more easy to reason about. In particular, it'll allow us to gather much better memory stats from the field.  The tradeoff seems worth it. Also, I'm suspicious of this number as something of this sort should have seen an across-the-board perf hit rather than just a couple of isolated tests. Closing Won't Fix.

Sign in to add a comment