New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 788148 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : Separator line is seen missing between 'SIM card is Locked' message and 'UNLOCK' button in chrome://settings page

Project Member Reported by mmanchala@chromium.org, Nov 23 2017

Issue description

Chrome Version: 64.0.3274.0/10154.0.0 dev-channel Samus,Zako and Winky
OS: Chrome

What steps will reproduce the problem?
1)Sign into User ->Insert Mobile Dongle and ensure it is connected
2)In chrome://settings page -> At Internet Connection click on Cellular connection -> Navigates to Cellular connected page ->Enable 'Enable SIM Card locking(require PIN to use Mobile data) option -> 'ENTER SIM PIN' Dialog box is seen -> Enter correct pin and click 'ENTER'
3)Now remove dongle and again insert Mobile Dongle-> Observe there is no separator line between'SIM card is Locked' message and 'UNLOCK' button is (Please refer video and screenshot)


Expected: Separator line should be seen between'SIM card is Locked' message and 'UNLOCK' button
Actual: Instead Separator line is seen missing between'SIM card is Locked' message  and 'UNLOCK' button

This is Regression issue as same is working fine in 63.03239.50/10032.39.0 beta-channel Winky

@stevenjb : Please confirm the issue
 
Actual_NoSeparatorLine.webm
4.3 MB View Download
Actual_NoSeparatorLine.jpg
118 KB View Download
Expected_SeparatorLine.jpg
68.7 KB View Download
Labels: -Pri-1 -M-64 M-65 Pri-2
Status: Started (was: Assigned)
Minor visual artifact, -> P2, 65

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a727df3f0ca8dce9385527e0aba4b2431d9c40e4

commit a727df3f0ca8dce9385527e0aba4b2431d9c40e4
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Dec 01 23:21:46 2017

Settings: Siminfo: Include .separator CSS

Bug:  788148 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I82a5d1ca789d62effc897ccccd981dc12c93610b
Reviewed-on: https://chromium-review.googlesource.com/804236
Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521112}
[modify] https://crrev.com/a727df3f0ca8dce9385527e0aba4b2431d9c40e4/ui/webui/resources/cr_components/chromeos/network/network_siminfo.html

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 11 2017

Labels: merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79e0eba0a842a557be94216347cd6578d781e867

commit 79e0eba0a842a557be94216347cd6578d781e867
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Dec 11 19:48:05 2017

Settings: Siminfo: Include .separator CSS

TBR=stevenjb@chromium.org

(cherry picked from commit a727df3f0ca8dce9385527e0aba4b2431d9c40e4)

Bug:  788148 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I82a5d1ca789d62effc897ccccd981dc12c93610b
Reviewed-on: https://chromium-review.googlesource.com/804236
Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#521112}
Reviewed-on: https://chromium-review.googlesource.com/820104
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#142}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/79e0eba0a842a557be94216347cd6578d781e867/ui/webui/resources/cr_components/chromeos/network/network_siminfo.html

Checked and Issue is working fine on latest M-70 70.0.3538.41/11021.37.0 beta-channel Candy

Thanks..!!

Sign in to add a comment