New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 788147 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Can't see test case methods in file outline

Project Member Reported by awdf@chromium.org, Nov 23 2017

Issue description

Unlike class methods, test fixtures that are defined such as the IN_PROC_BROWSER_TEST_F tests in https://cs.chromium.org/chromium/src/chrome/browser/notifications/platform_notification_service_interactive_uitest.cc do not appear in the left-hand Outline view, so you can't see an overview of what tests exist all in one place, or navigate between them easily.

I use the Outline view when viewing production code all the time, so it's very annoying that I have to resort to ctrl-f-ing for "TEST_F" to see what's there in test files.
 

Comment 1 by flyboy@chromium.org, Nov 27 2017

Summary: Can't see test case methods in file outline (was: Can't see tests fixtures in file outline)
Understood.  Will investigate to see how feasible this may be.

Comment 2 by j...@chromium.org, May 14 2018

Owner: j...@chromium.org
Status: Assigned (was: Untriaged)
I have an internal CL pending that should solve this, assuming it makes it through code review.

Note that tests that use a plain TEST or TEST_F macro work correctly already, e.g.: https://cs.chromium.org/chromium/src/base/bind_unittest.cc

My planned change will update the lexer to work with any macro which has TEST or TEST_F as a suffix.

Comment 3 by j...@chromium.org, May 14 2018

Status: Started (was: Assigned)

Comment 4 by j...@chromium.org, May 14 2018

CL submitted. I'll update this once the change has made it to production.

Comment 5 by awdf@chromium.org, May 14 2018

Awesome, thanks!

Comment 6 by j...@chromium.org, May 24 2018

Status: Fixed (was: Started)
This change is now live in production.

Comment 7 by awdf@chromium.org, May 24 2018

Nice!! thanks :)

Sign in to add a comment