New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 788141 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Jan 2018
Cc:
█ divya.pa...@techmahindra.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Line clamp ellipsis don't move after horizontal resize

Reported by tresru...@gmail.com, Nov 23 2017 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.94 Safari/537.36

Steps to reproduce the problem:
1. Open https://codepen.io/anon/pen/NvzgWZ
2. Resize browser window

What is the expected behavior?
Ellipsis move with text

What went wrong?
Ellipsis stay without movement

Did this work before? N/A 

Chrome version: 62.0.3202.94  Channel: stable
OS Version: OS X 10.12.6
Flash Version: 

I found that it appears if there is enough space in line to add ellipsis.
I have a fix for that problem but don't know how to write a test for it.
Will send CL soon.

Comment 1 by divya.pa...@techmahindra.com, Nov 24 2017

Cc: divya.pa...@techmahindra.com
Components: Blink>Layout
Labels: Needs-Triage-M62 Needs-Feedback Triaged-ET
Unable to reproduce the issue on reported version 62.0.3202.94 and latest Canary 64.0.3277.0 using Mac 10.13.1. 

Could you please re-try the scenario by creating a new profile / incognito mode / removing unwanted extensions 
1. Press Cmd+option+I to open devtools
2. click on 3dot menu
3. Click on settings
4. Reset to default

Please follow below steps to create a New profile
(i) Click the avatar icon on top right of the browser and click on manage people
(ii) In the new window, on the bottom right, click on Add person
(iii) Enter the person name and click on save

Please find the enclosed screen-cast and let us know if we have missed any steps in the process of reproducing the issue from TE-end
788141(1).mp4
12.2 MB View Download

Comment 2 by apisa...@yandex-team.ru, Nov 24 2017 

On the attached video dots are not moving with test. It is a bug. Why unable to reproduce?
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54f63b81e9ba3b727b83c8ec972f47f2fe2a441b

commit 54f63b81e9ba3b727b83c8ec972f47f2fe2a441b
Author: Alexander Pisarev <apisarev@yandex-team.ru>
Date: Mon Dec 11 21:43:40 2017

Fix line clamp ellipsis with enough free space.

There is a special case in line clamp logic when a line has enough free space at the end. In this situation, a line has no truncation but still has an ellipsis. But all other logic didn't count on it.
This false assumption of truncation for ellipsis was removed from the code.

And fix braces in if's for 2+ lines bodies to be able to commit it.

Bug:  788141 
Change-Id: I06893d47533031f79c610bd6f5258f7359f541f5
Reviewed-on: https://chromium-review.googlesource.com/787590
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523219}
[add] https://crrev.com/54f63b81e9ba3b727b83c8ec972f47f2fe2a441b/third_party/WebKit/LayoutTests/fast/overflow/line-clamp-ellipsis-in-free-space-expected.html
[add] https://crrev.com/54f63b81e9ba3b727b83c8ec972f47f2fe2a441b/third_party/WebKit/LayoutTests/fast/overflow/line-clamp-ellipsis-in-free-space.html
[modify] https://crrev.com/54f63b81e9ba3b727b83c8ec972f47f2fe2a441b/third_party/WebKit/Source/core/layout/LayoutText.cpp
[modify] https://crrev.com/54f63b81e9ba3b727b83c8ec972f47f2fe2a441b/third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp

Comment 4 by e...@chromium.org, Jan 29 2018

Status: Fixed (was: Unconfirmed)
►

Sign in to add a comment