New issue
Advanced search Search tips

Issue 788123 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

[Missing Test]: Enable VaapiDrmPicture on more cases

Project Member Reported by kkaluri@chromium.org, Nov 23 2017

Issue description

Automated tests for the below commit have been missing.Please add test coverage ASAP to avoid regressions in future.

CL: 
----
https://chromium.googlesource.com/chromium/src.git/+/a9dd08addbd53885176f45a205ea992ee815961c

Ref Bug: 
---------
https://bugs.chromium.org/p/chromium/issues/detail?id=785201


Thank you...!!
 
Status: Started (was: Assigned)
Thx for reporting that. Today I made a unit test for it in the new CL https://chromium-review.googlesource.com/c/chromium/src/+/788051
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8580c2220857886dcfa8fea7374bcc559a291416

commit 8580c2220857886dcfa8fea7374bcc559a291416
Author: Julien Isorce <julien.isorce@chromium.org>
Date: Tue Nov 28 12:11:32 2017

Can select DRM(egl) or TFP(glx) at runtime for vaapi video decoding

Fixes overlap with https://chromium-review.googlesource.com/767375

Added unit test this time.

This is a preliminary step for the subsequent CL
https://chromium-review.googlesource.com/c/chromium/src/+/766787

Bug:  785201 ,  788123 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I70620697109fdef7d036be4c26fcecb763ddb4ba
Tests: media_unittests --gtest_filter=*Vaapi*SupportedPlatforms*
Reviewed-on: https://chromium-review.googlesource.com/788051
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Julien Isorce <julien.isorce@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519657}
[modify] https://crrev.com/8580c2220857886dcfa8fea7374bcc559a291416/media/gpu/vaapi/vaapi_picture.cc
[modify] https://crrev.com/8580c2220857886dcfa8fea7374bcc559a291416/media/gpu/vaapi/vaapi_picture_factory.cc
[modify] https://crrev.com/8580c2220857886dcfa8fea7374bcc559a291416/media/gpu/vaapi/vaapi_picture_factory.h
[modify] https://crrev.com/8580c2220857886dcfa8fea7374bcc559a291416/media/gpu/vaapi_video_decode_accelerator_unittest.cc

Labels: vaapi
Status: Fixed (was: Started)

Sign in to add a comment