New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 788117 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: May 2018
Cc:
█ w...@chromium.org
█ meade@chromium.org
kkaluri@chromium.org
yutak@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Missing Test]: Should not have both LinkedHashSet and ListHashSet which are the same but somehow different

Project Member Reported by kkaluri@chromium.org, Nov 23 2017 
Automated tests for the below commit have been missing.Please add test coverage ASAP to avoid regressions in future.

CL: 
----
https://chromium.googlesource.com/chromium/src.git/+/76b83ab9e004da663a8af6bf2354059654796806

Ref Bug: 
---------
https://bugs.chromium.org/p/chromium/issues/detail?id=614112


Thank you...!!

Comment 1 by w...@chromium.org, Nov 23 2017

Cc: w...@chromium.org kkaluri@chromium.org
Owner: meade@chromium.org
kkaluri@: What are the criteria for this bug to be filed?

meade@: Could you help route this to the right owner please?

These are the changed files: 
third_party/WebKit/Source/core/css/CSSPropertyValueSet.h
third_party/WebKit/Source/core/css/MediaQueryList.h
third_party/WebKit/Source/core/css/StyleEngine.h
third_party/WebKit/Source/core/css/resolver/StyleResolver.h

Comment 2 by meade@chromium.org, Nov 24 2017

Cc: meade@chromium.org
Owner: kkaluri@chromium.org
I'm probably the right owner, but I'm confused by this bug - what is the issue here? 

These four files have pretty good coverage via LayoutTests, and the existence of the two classes seems like a reasonable intermediate state while ListHashSet is in the process of being removed.

Assigning back to kkaluri@ to see if they can clarify the intention of this bug. Thanks!

Comment 3 by kkaluri@chromium.org, May 30 2018

Owner: ----
Status: WontFix (was: Assigned)
Closing this issue as test-cases classes are available in Ref bug Issue 614112
►

Sign in to add a comment