Test coverage for minor MC |
||||||
Issue descriptionCurrently, V8's minor MC is neither run in production nor on any bots. The idea is to improve it in the future as we still see potential for the design. Runtime flag --minor-mc The proposal would be to have * optional CQ try bots: linux64 release w/ DCHECK, and linux64 rel w/ TSAN * fyi waterfall: linux64 w/ DCHECK
,
Nov 23 2017
,
Nov 23 2017
It will be much harder to make the feature FYI. Would it be possible to treat the feature as first-class? E.g. disallow breakages? (or diligently disable failing tests in that variant, so that it stays green)?
,
Nov 23 2017
We can also make it a first-class bot, yes. It might require a few teaks to get it green initially but then it should definitely stay green at all times.
,
Nov 29 2017
Work on issue 788104 finished, so that such changes as this can now be driven by V8 devs. Please see updated readme, landing in https://chromium-review.googlesource.com/c/v8/v8/+/796311. You can add a new variant to https://cs.chromium.org/chromium/src/v8/tools/testrunner/local/variants.py?q=variants.py&sq=package:chromium&l=1 and add the wanted configurations to the pyl files in infra/testing.
,
Nov 30 2017
,
Nov 30 2017
,
Nov 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/776721396a70400816ac614346660040a8228b01 commit 776721396a70400816ac614346660040a8228b01 Author: Michael Lippautz <mlippautz@chromium.org> Date: Thu Nov 30 12:37:19 2017 [heap] Minor MC: Fix task computation No-try: true Bug: chromium:651354, chromium:788113 Change-Id: I8955b322b826c0a59f85c32bb2c1ec8c9d4e0761 Reviewed-on: https://chromium-review.googlesource.com/800330 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#49748} [modify] https://crrev.com/776721396a70400816ac614346660040a8228b01/src/heap/mark-compact.cc
,
Nov 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/9ac877fa77a07e1918ed84c5d51af6b6f10626b4 commit 9ac877fa77a07e1918ed84c5d51af6b6f10626b4 Author: Michael Lippautz <mlippautz@chromium.org> Date: Thu Nov 30 13:03:09 2017 [heap] Minor MC: Free and prefree empty remembered set buckets No-try: true Bug: chromium:651354, chromium:788113 Change-Id: Iff2051751c4688c307e8f23ddd08de203974e842 Reviewed-on: https://chromium-review.googlesource.com/800272 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#49751} [modify] https://crrev.com/9ac877fa77a07e1918ed84c5d51af6b6f10626b4/src/heap/mark-compact.cc
,
Nov 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/6b29f1cf281336f5ea62da2f2f5438ca215576f3 commit 6b29f1cf281336f5ea62da2f2f5438ca215576f3 Author: Michael Lippautz <mlippautz@chromium.org> Date: Thu Nov 30 13:13:29 2017 [heap] Minor MC: Support ThinString No-try: true Bug: chromium:651354, chromium:788113 Change-Id: I53cc2f04974671982371d1c26c71bd559450a5aa Reviewed-on: https://chromium-review.googlesource.com/800176 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#49752} [modify] https://crrev.com/6b29f1cf281336f5ea62da2f2f5438ca215576f3/src/heap/mark-compact.cc
,
Nov 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/b4d2f3eb991fd11126ac840c5db16e8a3789546c commit b4d2f3eb991fd11126ac840c5db16e8a3789546c Author: Jakob Gruber <jgruber@chromium.org> Date: Thu Nov 30 13:42:24 2017 Revert "[heap] Minor MC: Support ThinString" This reverts commit 6b29f1cf281336f5ea62da2f2f5438ca215576f3. Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Linux64/builds/21671 Original change's description: > [heap] Minor MC: Support ThinString > > No-try: true > Bug: chromium:651354, chromium:788113 > Change-Id: I53cc2f04974671982371d1c26c71bd559450a5aa > Reviewed-on: https://chromium-review.googlesource.com/800176 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49752} TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org Change-Id: I6268c5c090377cb97a3e8cdf1bb4b19b3c6876da No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:651354, chromium:788113 Reviewed-on: https://chromium-review.googlesource.com/800610 Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#49754} [modify] https://crrev.com/b4d2f3eb991fd11126ac840c5db16e8a3789546c/src/heap/mark-compact.cc
,
Nov 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/bbd9e4a76b0f653607912fa448476d5626b45af0 commit bbd9e4a76b0f653607912fa448476d5626b45af0 Author: Michael Achenbach <machenbach@chromium.org> Date: Thu Nov 30 13:43:29 2017 Revert "[heap] Minor MC: Support ThinString" This reverts commit 6b29f1cf281336f5ea62da2f2f5438ca215576f3. Reason for revert: Breaks many bots. Please no notry: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20verify%20csa/builds/4512 Original change's description: > [heap] Minor MC: Support ThinString > > No-try: true > Bug: chromium:651354, chromium:788113 > Change-Id: I53cc2f04974671982371d1c26c71bd559450a5aa > Reviewed-on: https://chromium-review.googlesource.com/800176 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49752} TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org Change-Id: I0a5f47f144ae9c8d2ba279243124fa10ec99e165 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:651354, chromium:788113 Reviewed-on: https://chromium-review.googlesource.com/800491 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#49755}
,
Nov 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/9fbbe2a4743c11c2df7aca3425ed419aa4fb0dcc commit 9fbbe2a4743c11c2df7aca3425ed419aa4fb0dcc Author: Michael Lippautz <mlippautz@chromium.org> Date: Thu Nov 30 16:40:59 2017 [heap] Full MC/Minor MC: Add support for ThinString This reverts commit b4d2f3eb991fd11126ac840c5db16e8a3789546c. Bug: chromium:651354, chromium:788113 Change-Id: I04b7541e7eb69f737d45e90bbfec591cf8f8190f Reviewed-on: https://chromium-review.googlesource.com/800552 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#49765} [modify] https://crrev.com/9fbbe2a4743c11c2df7aca3425ed419aa4fb0dcc/src/heap/mark-compact.cc [modify] https://crrev.com/9fbbe2a4743c11c2df7aca3425ed419aa4fb0dcc/src/objects/string-inl.h [modify] https://crrev.com/9fbbe2a4743c11c2df7aca3425ed419aa4fb0dcc/src/objects/string.h
,
Dec 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/73210c7f40d91b749ab7db4f168509a0232a4b98 commit 73210c7f40d91b749ab7db4f168509a0232a4b98 Author: Michael Lippautz <mlippautz@chromium.org> Date: Fri Dec 01 11:04:44 2017 Add CI and try bots for --minor-mc Bug: chromium:788113 Change-Id: I205c57869caa24957d63a139f6ba0c6e8cf45749 Reviewed-on: https://chromium-review.googlesource.com/800151 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#49783} [modify] https://crrev.com/73210c7f40d91b749ab7db4f168509a0232a4b98/infra/testing/client.v8.pyl [modify] https://crrev.com/73210c7f40d91b749ab7db4f168509a0232a4b98/infra/testing/tryserver.v8.pyl
,
Dec 1 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by machenb...@chromium.org
, Nov 23 2017