New issue
Advanced search Search tips

Issue 788112 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 617056
Owner:
Closed: Nov 8
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

ToolbarActionViewInteractiveUITest.DoubleClickToolbarActionToClose fails on win debug

Project Member Reported by grt@chromium.org, Nov 23 2017

Issue description

The test passes on non-debug bots but fails consistently on Win7 Tests (dbg)(1). For example, from https://chromium-swarm.appspot.com/task?id=39fdcebd47677410&refresh=10&show_raw=1:

[ RUN      ] ToolbarActionViewInteractiveUITest.DoubleClickToolbarActionToClose

[9140:1224:1122/103900.074:WARNING:chrome_browser_main_win.cc(613)] Command line too long for RegisterApplicationRestart:  --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=ToolbarActionViewInteractiveUITest.DoubleClickToolbarActionToClose --single_process --snapshot-output-dir="e:\b\swarm_slave\w\ionyonhf" --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4164_29024\results4164_16098\test_results.xml" --test-launcher-summary-output="e:\b\swarm_slave\w\ionyonhf\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4164_29024\d4164_8723" --disable-offline-auto-reload --no-first-run --no-default-browser-check --enable-logging=stderr --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=45 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --enable-features=TestFeatureForBrowserTest1 --disable-features=NetworkPrediction,TestFeatureForBrowserTest2 --flag-switches-begin --flag-switches-end --restore-last-session about:blank

[3272:9184:1122/103900.340:INFO:media_foundation_video_encode_accelerator_win.cc(370)] Windows versions earlier than 8 are not supported.

[2368:6380:1122/103903.477:ERROR:render_process_impl.cc(194)] WebFrame LEAKED 1 TIMES

[9140:6772:1122/103903.489:ERROR:process_win.cc(143)] Unable to terminate process: Access is denied. (0x5)

../../chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc(336): error: Value of: view_controller->is_showing_popup()

  Actual: true

Expected: false

../../chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc(337): error:       Expected: nullptr

      Which is: NULL

To be equal to: toolbar_actions_bar->popup_owner()

      Which is: 3379AFE8

[9140:1224:1122/103904.095:INFO:chrome_cryptauth_service.cc(222)] Profile is not authenticated yet; waiting before starting CryptAuth managers.

[9140:1224:1122/103904.224:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.

[  FAILED  ] ToolbarActionViewInteractiveUITest.DoubleClickToolbarActionToClose, where TypeParam =  and GetParam() =  (5081 ms)


 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4113a5c37315e331c50c97929444ce19916a8439

commit 4113a5c37315e331c50c97929444ce19916a8439
Author: Greg Thompson <grt@chromium.org>
Date: Tue Nov 28 08:29:57 2017

Enable interactive_ui_tests on Windows that now run mostly reliably.

r516772 was the last of many commits that resolved a number of problems
that made this test suite flaky on Windows. This CL enables tests that
had been disabled over time due to flakes, yet now seem to run okay.

BUG= 638692 , 764415 , 788112 
This CL was uploaded by git cl split.

Change-Id: I241701b1e72a6bbddb1051181235cd43e566393f
Reviewed-on: https://chromium-review.googlesource.com/787230
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519608}
[modify] https://crrev.com/4113a5c37315e331c50c97929444ce19916a8439/chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc

Components: Tests>Disabled
Labels: Test-Disabled
Labels: Hotlist-DesktopUIChecked
Status: Archived (was: Assigned)
Mass UI Triage.

Comment 5 by pkasting@chromium.org, Jan 16 (6 days ago)

Mergedinto: 617056
Status: Duplicate (was: Archived)
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 17 (6 days ago)

Sign in to add a comment