New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 788102 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Tricium avatar for Gerrit

Project Member Reported by emso@chromium.org, Nov 23 2017

Issue description

Add an avatar for Tricium similar to that used for the CommitQueue. Perhaps a green version of the avatar used for CommitQueue.
 
To clarify: This is about a avatar image on Gerrit for the Tricium service account, e.g. when it adds comments, right? And the commit queue logo is the one used by https://chromium-review.googlesource.com/dashboard/commit-bot@chromium.org?

Comment 2 by emso@chromium.org, Nov 27 2017

Yes, correct. Sorry for being unclear, I should've added some pointers.
I wonder how to change account details on Gerrit for service accounts... would tricium-dev@appspot.gserviceaccount.com and tricium-prod@appspot.gserviceaccount.com have passwords for Gerrit?
The commit queue has a real chromium address commit-bot@chromium.org, as this predates IAM. This is not the case for real service accounts. But since it's really just an OAuth2 identity, maybe it's possible if we find the datasource gerrit is using.
Labels: -Pri-2 Pri-3
Based on https://bugs.chromium.org/p/chromium/issues/detail?id=772391#c24, it sounds like it might not be possible to set avatar images for service accounts.

Relevant code in Gerrit:
https://cs.corp.google.com/piper///depot/google3/java/com/google/devtools/gerritcodereview/server/auth/GoogleAvatar.java?rcl=176395316&l=71
Status: WontFix (was: Available)
Closing based on #5.

Sign in to add a comment