PrerenderBrowserTest.PageLoadMetricsPrerender in site_per_process_browser_tests flakes |
||||||||
Issue descriptionsite_per_process_browser_tests failing on chromium.linux/Linux Tests Builders failed on: - Linux Tests: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests Failing build: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests/builds/64879
,
Nov 23 2017
,
Nov 23 2017
,
Nov 23 2017
,
Nov 23 2017
sorry future sheriffs - won;t have time to update expectations now.
,
Nov 24 2017
I'm disabling it for now.
,
Nov 24 2017
,
Nov 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77ca60a5c8f5592babcb90e0dc349ff3442261c6 commit 77ca60a5c8f5592babcb90e0dc349ff3442261c6 Author: Greg Thompson <grt@chromium.org> Date: Fri Nov 24 10:13:22 2017 Disable PrerenderBrowserTest.PageLoadMetricsPrerender on Linux due to flakes. BUG= 788100 TBR=grt@chromium.org Change-Id: I8c0699b6af9a8d1502e76e94d9dd7e2d2e703303 Reviewed-on: https://chromium-review.googlesource.com/788379 Reviewed-by: Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#519079} [modify] https://crrev.com/77ca60a5c8f5592babcb90e0dc349ff3442261c6/chrome/browser/prerender/prerender_browsertest.cc
,
Nov 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac05e5b2d2d9f987d3e38089a5ca436da8360710 commit ac05e5b2d2d9f987d3e38089a5ca436da8360710 Author: Matthew Cary <mattcary@chromium.org> Date: Thu Nov 30 11:34:41 2017 Prerender: fix flake of PrerenderBrowserTest.PageLoadMetricsPrerender. Like most of the prerender tests, this test first navigates to a loader page which makes a prerender request for a second page. This test examines the page load metrics reported in histograms. The page load metrics infrastructure may compute events out-of-order, and so buffers events and emits them in batches. This means that one can not expect page navigations to be synchronized with page load metrics reporting. This test was flaking due to this race manifesting between the second prerendering page load versus the first loader page load. The fix adds a MetricsWebContentsObserver::TestingObserver in the style of the PageLoadMetricsWaiter used in page_load_metrics_browsertest.cc. Bug: 788100 Change-Id: Ib5d1519597fce5507a8e28f0b153b476f4588c12 Reviewed-on: https://chromium-review.googlesource.com/790392 Reviewed-by: Egor Pasko <pasko@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#520508} [modify] https://crrev.com/ac05e5b2d2d9f987d3e38089a5ca436da8360710/chrome/browser/prerender/prerender_browsertest.cc
,
Nov 30 2017
This CL re-enables the test after hopefully fixing the flake. I'll monitor and close the bug if the flakes have stopped.
,
Dec 1 2017
It's not flaking any more. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=site_per_process_browser_tests&tests=PageLoadMetricsPrerender
,
Jan 24 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by olka@chromium.org
, Nov 23 2017