New issue
Advanced search Search tips

Issue 788099 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Autofill does not work with angular pattern validated fields.

Project Member Reported by olivierrobin@chromium.org, Nov 23 2017

Issue description

Example websited:
Credit card fields on walgreens.com
Credit card date fields on urbanoutfitters.com 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a10ca5efebca5e575910e4fc2602008c7543007

commit 3a10ca5efebca5e575910e4fc2602008c7543007
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Fri Dec 01 16:21:01 2017

Use a single function to set field value.

This single function will make it easier to support more scenario
(events, frameworks...).

Bug:  788099 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib76aadebbb3c6999b20b5261a8b0045689bd2785
Reviewed-on: https://chromium-review.googlesource.com/786239
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520954}
[modify] https://crrev.com/3a10ca5efebca5e575910e4fc2602008c7543007/components/autofill/ios/browser/resources/autofill_controller.js
[modify] https://crrev.com/3a10ca5efebca5e575910e4fc2602008c7543007/ios/web/web_state/js/resources/common.js

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53742f613ca38e3e84c33905d05a6b6b2ccd84ad

commit 53742f613ca38e3e84c33905d05a6b6b2ccd84ad
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Fri Dec 01 17:03:20 2017

Autofill support AngularJS fields

Data bound fields need to have the backend value updated before sending
the input event.
Example website:
- nordstrom.com
- walgreens.com

Bug:  788099 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I5b8467a76d15b6ad83061730b3a627f274342c27
Reviewed-on: https://chromium-review.googlesource.com/787433
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520963}
[modify] https://crrev.com/53742f613ca38e3e84c33905d05a6b6b2ccd84ad/ios/web/web_state/js/resources/common.js

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7526172345eee3dc448e4ae057d2720b424ca052

commit 7526172345eee3dc448e4ae057d2720b424ca052
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Tue Dec 19 18:44:14 2017

Check for each angular method before calling.

Angular works using modules and all modules may not be loaded.
E.g. staples.com does not provide the angular.element function. This
result in a script error.
Check existence of each function before calling.

Bug:  788099 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I04c09530b2a9189e5e916c6e6a76be93cb7f26d8
Reviewed-on: https://chromium-review.googlesource.com/806498
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525091}
[modify] https://crrev.com/7526172345eee3dc448e4ae057d2720b424ca052/ios/web/web_state/js/resources/common.js

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49bf3cbf7cc6d70643197a604090f8729f9d7404

commit 49bf3cbf7cc6d70643197a604090f8729f9d7404
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Fri Apr 20 10:25:04 2018

[Autofill iOS] Create a temporary property for HTML input.

This fixes the issues on many websites that use properties to keep track of the
field value, including
- target.com
- nordstrom.com
- dickblick.com
- broadway.com
- childrensplace.com

Also add focus and blur events if the field is not focused.

This also make the workaround for React obsolete.

Bug: 732360,  788099 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iedc082b9b965f2c2d335566ce750a211e66d8805
Reviewed-on: https://chromium-review.googlesource.com/1013573
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552297}
[modify] https://crrev.com/49bf3cbf7cc6d70643197a604090f8729f9d7404/components/autofill/ios/fill/resources/fill.js

Status: Fixed (was: Started)

Sign in to add a comment