Autofill does not work if multiple forms have the same name |
|||
Issue descriptionGetFormElementFromIdentifier will return the first form with a given name.
,
Nov 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5642e6d44472614889c3778ddbeed07cb96e7c2b commit 5642e6d44472614889c3778ddbeed07cb96e7c2b Author: Olivier Robin <olivierrobin@chromium.org> Date: Tue Nov 28 15:26:37 2017 [Autofill] Disambiguate forms with same names Autofill relies on the identity __gCrWeb.common.getFormElementFromIdentifier( __gCrWeb.common.getFormIdentifier(form)) === form. This is not the case if multiple forms have the same name. Do not use the name if it does not allow to access the form. Bug: 788093 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I95e602a46736fdfd86aa3a4708eb0b062a470009 Reviewed-on: https://chromium-review.googlesource.com/786017 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Peter Lee <pkl@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#519694} [modify] https://crrev.com/5642e6d44472614889c3778ddbeed07cb96e7c2b/ios/chrome/browser/autofill/autofill_controller_js_unittest.mm [modify] https://crrev.com/5642e6d44472614889c3778ddbeed07cb96e7c2b/ios/web/web_state/js/resources/common.js
,
May 1 2018
,
May 15 2018
Was this fixed? |
|||
►
Sign in to add a comment |
|||
Comment 1 by olivierrobin@chromium.org
, Nov 23 2017