New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 788086 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Nov 2017
Cc:
█ mgiuca@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----

Blocking:
issue 785809



Sign in to add a comment

ExternalProtocolHandlerTest.TestUrlEscape failing on multiple builders

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Nov 23 2017 
unit_tests failing on multiple builders

Builders failed on: 
- linux-chromeos-dbg: 
  https://build.chromium.org/p/chromium.chromiumos/builders/linux-chromeos-dbg
- Linux Tests (dbg)(1)(32): 
  https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29
- Mac10.9 Tests (dbg): 
  https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29

Example broken build:
https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29%2832%29/46140

Clearly caused by introduction of ExternalProtocolHandlerTest.TestUrlEscape in r518848.

Comment 1 by mgiuca@chromium.org, Nov 23 2017

Blocking: 785809
Status: Fixed (was: Available)
commit 51d62ca4ad777a73d35b91b27f39acbb5d8a4053
Author: Matt Giuca <mgiuca@chromium.org>
Date: Thu Nov 23 07:01:22 2017

Revert "Launching an external protocol handler now escapes the URL."

This reverts commit 2401e58572884b3561e4348d64f11ac74667ef02.

Reason for revert: Broke unit_tests on builders.
https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29%2832%29/46140

Original change's description:
> Launching an external protocol handler now escapes the URL.
> 
> Fixes bug introduced in r102449.
> 
> Bug:   785809  
> Change-Id: I9e6dd1031dd7e7b8d378b138ab151daefdc0c6dc
> Reviewed-on: https://chromium-review.googlesource.com/778747
> Commit-Queue: Matt Giuca <mgiuca@chromium.org>
> Reviewed-by: Eric Lawrence <elawrence@chromium.org>
> Reviewed-by: Ben Wells <benwells@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#518848}

TBR=benwells@chromium.org,mgiuca@chromium.org,elawrence@chromium.org

Change-Id: I74fa862034e6fba34ddb0b2ef848c700d5287c83
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:   785809  
Reviewed-on: https://chromium-review.googlesource.com/787031
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518868}
[modify] https://crrev.com/51d62ca4ad777a73d35b91b27f39acbb5d8a4053/chrome/browser/external_protocol/external_protocol_handler.cc
[modify] https://crrev.com/51d62ca4ad777a73d35b91b27f39acbb5d8a4053/chrome/browser/external_protocol/external_protocol_handler_unittest.cc

Comment 2 by mgiuca@chromium.org, Nov 23 2017 

 Issue 788085  has been merged into this issue.
►

Sign in to add a comment