Consolidate Desktop PWA flags so there is just one to turn on |
||||
Issue descriptionCurrently there are four relevant flags to Desktop PWAs: 1. #enable-app-banners / AppBanners: old app banners, enabled by default on CrOS for some time. 2. #enable-experimental-app-banners / ExperimentalAppBanners: new app banners. Implies AppBanners. 3. #bypass-app-banner-engagement-checks / --bypass-app-banner-engagement-checks: special debug mode. 4. #enable-desktop-pwa-windowing / DesktopPWAWindowing: new window UI. #1 and #3 can stay as-is. Particularly, #3 should not be implied by any other flag because it is for debugging only. We want one flag to tell people to turn on to try the full DPWA feature set. I propose that we unify #2 and #4 into a single flag: #enable-desktop-pwas / DesktopPWAs, which also implies AppBanners. Alternatively (simpler), we could just have #4 imply #2.
,
Nov 23 2017
#1 Good point, OK I will keep the flag #2 but make #4 imply #2. Arguably, the flag is part of marketing since we tell people to activate it. It should use the branded name, not the internal name. (Though #enable-experimental-app-list says different.)
,
Nov 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d487043f96cb39e2fc405cb7369257dcd432de4e commit d487043f96cb39e2fc405cb7369257dcd432de4e Author: Matt Giuca <mgiuca@chromium.org> Date: Fri Nov 24 01:04:38 2017 Simplify Desktop PWA flags. - desktop-pwa-windowing now implies experimental-app-banners. - Renamed desktop-pwa-windowing to desktop-pwas. (This will de-activate the existing flag for anyone who has it turned on.) - Updated flag descriptions in about:flags. - Fixed code behind experimental-app-banners to use the function to check if it's turned on. Note that the internal feature name DesktopPWAWindowing (i.e., what you would use on the command line) has not changed, and is now a misnomer as it also turns on experimental app banners. Bug: 788072 Tbr: msw@chromium.org Change-Id: Ic39674c20313e632f427bb795557d70dce894599 Reviewed-on: https://chromium-review.googlesource.com/786357 Reviewed-by: Ben Wells <benwells@chromium.org> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#519038} [modify] https://crrev.com/d487043f96cb39e2fc405cb7369257dcd432de4e/chrome/browser/about_flags.cc [modify] https://crrev.com/d487043f96cb39e2fc405cb7369257dcd432de4e/chrome/browser/banners/app_banner_manager.cc [modify] https://crrev.com/d487043f96cb39e2fc405cb7369257dcd432de4e/chrome/browser/extensions/extension_util.cc [modify] https://crrev.com/d487043f96cb39e2fc405cb7369257dcd432de4e/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/d487043f96cb39e2fc405cb7369257dcd432de4e/chrome/browser/flag_descriptions.h [modify] https://crrev.com/d487043f96cb39e2fc405cb7369257dcd432de4e/chrome/browser/ui/toolbar/app_menu_model.cc
,
Nov 24 2017
,
Jan 22 2018
,
Jan 23 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by ortuno@chromium.org
, Nov 23 2017