New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 788065 link

Starred by 1 user
Status: Fixed
Owner:
█ mcgreevy@chromium.org
Last visit > 30 days ago
Closed: Nov 2017
Cc:
dominickn@chromium.org
█ bgalbs@google.com
pcovell@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

We don't show the install banner/dialog when we get an early prompt and experimental app banners is enabled.

Project Member Reported by mcgreevy@chromium.org, Nov 23 2017 
I noticed this when reading the AppBannerManager::OnBannerPromptReply code, and verified manually (with the gesture check commented out: to ensure that the prompt happened "early", I had to do call prompt() without waiting for a user click).

Cleanup cl/fix to follow shortly.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7ef12733f526eeae6ea6df2e8750c4023eae5ab

commit d7ef12733f526eeae6ea6df2e8750c4023eae5ab
Author: Michael McGreevy <mcgreevy@chromium.org>
Date: Fri Nov 24 01:33:08 2017

Show banner in experimental mode when prompt is called early.

Bug:  788065 
Change-Id: I38ebe3780951b77fa3b3ed01536bf25fe3bac137
Reviewed-on: https://chromium-review.googlesource.com/786851
Commit-Queue: Michael McGreevy <mcgreevy@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519043}
[modify] https://crrev.com/d7ef12733f526eeae6ea6df2e8750c4023eae5ab/chrome/browser/banners/app_banner_manager.cc

Comment 2 by mcgreevy@chromium.org, Nov 24 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment