New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 788045 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

[Autofill] A hidden character filters out local cards on Stripe Elements

Project Member Reported by ma...@chromium.org, Nov 23 2017

Issue description

Precondition: Have a local credit card saved in chrome://settings/autofill (not Google Payments).

Go to https://stripe.github.io/elements-examples/

Type in the credit card field or double click, the card doesn't show up.

This is because there is a hidden character in the field (\u200E) that triggers our filtering.


 

Comment 1 by ma...@chromium.org, Nov 23 2017

Cc: se...@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/532f3c67ad698c4dc45912590a70f61ec9aebb78

commit 532f3c67ad698c4dc45912590a70f61ec9aebb78
Author: Mathieu Perreault <mathp@chromium.org>
Date: Thu Nov 23 14:06:14 2017

[Autofill] Trim some invisible unicode characters when suggesting credit cards

As reported in the wild.

Bug:  788045 
Test: AutofillManagerTest
Change-Id: I9b21d0fcec51a1b43281d0b8497e71b0cc60eea6
Reviewed-on: https://chromium-review.googlesource.com/786213
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518922}
[modify] https://crrev.com/532f3c67ad698c4dc45912590a70f61ec9aebb78/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/532f3c67ad698c4dc45912590a70f61ec9aebb78/components/autofill/core/browser/autofill_manager_unittest.cc

Comment 3 by ma...@chromium.org, Nov 23 2017

Status: Fixed (was: Started)

Comment 4 by ma...@chromium.org, Nov 24 2017

Labels: -M-64 Merge-Request-63 M-63
Requesting merge to M63 for a bug affecting a lot of credit card forms (Stripe). The fix is very low risk and well tested. 
Project Member

Comment 5 by sheriffbot@chromium.org, Nov 24 2017

Labels: -Merge-Request-63 Merge-Review-63 Hotlist-Merge-Review
This bug requires manual review: Less than 7 days to go before AppStore submit on M63
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by cma...@chromium.org, Nov 27 2017

mathp@, is this a regression in M63? This is the last week of M63 beta before it goes to stable and unless something is very critical, we should be careful merging it into M63 at this point. Could you give more details on the impact of this bug? Could this fix get worse if something is missing?

Comment 7 by ma...@chromium.org, Nov 27 2017

This fix is a 1-line change that will fix Autofill on Stripe elements which is a very large e-commerce solutions provider. As we get into the holiday season this fix becomes really important.

This can't worsen the situation in any way, as it is simply checking for an additional case when filling credit cards. 

Happy to chat more about it if you'd like.

Comment 8 by cmasso@google.com, Nov 28 2017

Labels: -Hotlist-Merge-Review -Pri-2 -Merge-Review-63 Merge-Approved-63 Pri-1
Merge approved. Please make sure to verify the fix on branch 3239 after merging it.
Verified the issue (OS-iOS) on the build 63.0.3239.68 beta and 64.0.3279.0 Canary tested on iPnone7+(iOS 11)

M63 : 
Saved local credit card are not displayed on tapping on credit card section in "https://stripe.github.io/elements-examples/"

Video:
https://drive.google.com/a/google.com/file/d/1rM4NrRq2EGP7lVhSXv0luzydcYhrIN_J/view?usp=sharing

M64 :
Saved local credit card popup are displayed on the keyboard.Card details are not entered in credit card section"https://stripe.github.io/elements-examples/"

Video :
https://drive.google.com/a/google.com/file/d/1uIS--rR5245R0SkjJIlwyR6TsETFAwF1/view?usp=sharing

Pls merge your change to M63 branch 3239 before 12:30 PM, Tuesday (11/28/17) so we can take it in for this week last Beta release. Thank you.
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 28 2017

Labels: -merge-approved-63 merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99f10e2c0ab17574a002f0559e85601c92ac9208

commit 99f10e2c0ab17574a002f0559e85601c92ac9208
Author: Mathieu Perreault <mathp@chromium.org>
Date: Tue Nov 28 15:17:37 2017

[M63][Autofill] Trim some invisible unicode characters when suggesting credit cards

As reported in the wild.

TBR=mathp@chromium.org

(cherry picked from commit 532f3c67ad698c4dc45912590a70f61ec9aebb78)

Bug:  788045 
Test: AutofillManagerTest
Change-Id: I9b21d0fcec51a1b43281d0b8497e71b0cc60eea6
Reviewed-on: https://chromium-review.googlesource.com/786213
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#518922}
Reviewed-on: https://chromium-review.googlesource.com/793870
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#579}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/99f10e2c0ab17574a002f0559e85601c92ac9208/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/99f10e2c0ab17574a002f0559e85601c92ac9208/components/autofill/core/browser/autofill_manager_unittest.cc

Cc: ranjitkan@chromium.org
Labels: TE-verified-63.0.3239.70 TE-Verified-M63
Rechecked this issue on Windows 10, Mac 10.12.6, Ubuntu 14.04 using chrome version 63.0.3239.70 as per the steps mentioned in the issue description and fix is working as intended. 

Adding TE-Verified labels for M63.

Thanks.!

Sign in to add a comment