New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 788044 link

Starred by 1 user
Status: Fixed
Owner:
█ chenwilliam@chromium.org
Last visit > 30 days ago
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Infinite recursion when calling TestRunner.addResult while debuggins.

Project Member Reported by eostroukhov@chromium.org, Nov 23 2017 
What steps will reproduce the problem?
(1) Use dtrun test -d to debug a test that has TestRunner.addResult
(2) Step over code that call TestRunner.addResult

What is the expected result? Console output

What happens instead? Infinite recursion.

This is a regression caused by https://chromium-review.googlesource.com/c/chromium/src/+/780806
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1806acde53fd3d543d0fe8d1021e20434fdd165

commit b1806acde53fd3d543d0fe8d1021e20434fdd165
Author: Will Chen <chenwilliam@chromium.org>
Date: Mon Nov 27 23:53:26 2017

DevTools: fix TestRunner.addResult when debugging test

My previous CL broke the test debugging workflow because it resulted in
TestRunner.addResult causing a stack overflow:
https://chromium-review.googlesource.com/c/chromium/src/+/780806

This fixes the issue by preserving original console functions when debugging tests.

Bug:  788044 
Change-Id: I06a93e674ee80d35460f12ba84a4168030c5a029
Reviewed-on: https://chromium-review.googlesource.com/791370
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519461}
[modify] https://crrev.com/b1806acde53fd3d543d0fe8d1021e20434fdd165/third_party/WebKit/Source/devtools/front_end/test_runner/TestRunner.js

Comment 2 by chenwilliam@chromium.org, Dec 14 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment