New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 788040 link

Starred by 2 users
Status: Fixed
Owner:
jinsuk...@chromium.org
Closed: Nov 2017
Cc:
mdjones@chromium.org
█ donnd@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Gray patch at the bottom of contextual search panel

Project Member Reported by jinsuk...@chromium.org, Nov 23 2017 
This is a regression caused by https://crrev.com/c/752963. Started looking into it now.

Comment 1 by jinsuk...@chromium.org, Nov 23 2017 

Screenshot
gray.png
232 KB View Download

Comment 2 by jinsuk...@chromium.org, Nov 23 2017 

Issue 788158 has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e177073cd98747406955b581cdfdbe4694997ed0

commit e177073cd98747406955b581cdfdbe4694997ed0
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Thu Nov 23 21:56:44 2017

Fix a bug showing a gray patch on contextual search

Browser control size to be returned through WebContentsDelegate-
Android should be in DIP while it was returning physical pixel.
This CL sets the unit right to eliminate the regression.

Bug:  788040 
Change-Id: I97f1a2475a0893bb8a36d64ccad78d591c532266

TBR=donnd@chromium.org

Change-Id: I97f1a2475a0893bb8a36d64ccad78d591c532266
Reviewed-on: https://chromium-review.googlesource.com/786871
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519021}
[modify] https://crrev.com/e177073cd98747406955b581cdfdbe4694997ed0/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java

Comment 4 by jinsuk...@chromium.org, Nov 23 2017

Status: Fixed (was: Started)
►

Sign in to add a comment